feedparser - npm Package Compare versions

Comparing version 0.17.0 to 0.18.0

History.md

 
+v0.18.0 / 2014-06-18
+==================
+
+ * Enforce de-duping on atom enclosures
+ * Fix modification by reference defeating indexOf checking
+ * Fix inverted index checking
+ * Update test and fixture with tougher test case suggested by #111
+ * Revert "test for different enclosure type"
+ * test for different enclosure type
+
 v0.17.0 / 2014-05-27
@@ -3,0 +13,0 @@ ==================

main.js

@@ -725,3 +725,3 @@ /**********************************************************************
       , attrs = el['@']
-      , enclosure = {};
+      , enclosure;
     if (normalize) {
@@ -764,6 +764,9 @@ switch(name){
                 if (link['@']['rel'] == 'enclosure') {
+                  enclosure = {};
                   enclosure.url = link['@']['href'];
                   enclosure.type = utils.get(link['@'], 'type');
                   enclosure.length = utils.get(link['@'], 'length');
-                  item.enclosures.push(enclosure);
+                  if (indexOfObject(item.enclosures, enclosure, ['url', 'type']) === -1) {
+                    item.enclosures.push(enclosure);
+                  }
                 }
@@ -785,6 +788,9 @@ } else {
               if (el['@']['rel'] == 'enclosure') {
+                enclosure = {};
                 enclosure.url = el['@']['href'];
                 enclosure.type = utils.get(el['@'], 'type');
                 enclosure.length = utils.get(el['@'], 'length');
-                item.enclosures.push(enclosure);
+                if (indexOfObject(item.enclosures, enclosure, ['url', 'type']) === -1) {
+                  item.enclosures.push(enclosure);
+                }
               }
@@ -859,6 +865,7 @@ } else {
           el.forEach(function (enc){
+            enclosure = {};
             enclosure.url = utils.get(enc['@'], 'url');
             enclosure.type = utils.get(enc['@'], 'type');
             enclosure.length = utils.get(enc['@'], 'length');
-            if (indexOfObject(item.enclosures, enclosure, ['url', 'type']) === -1) {
+            if (~indexOfObject(item.enclosures, enclosure, ['url', 'type'])) {
               item.enclosures.splice(indexOfObject(item.enclosures, enclosure, ['url', 'type']), 1, enclosure);
@@ -870,6 +877,7 @@ } else {
         } else {
+          enclosure = {};
           enclosure.url = utils.get(el['@'], 'url');
           enclosure.type = utils.get(el['@'], 'type');
           enclosure.length = utils.get(el['@'], 'length');
-          if (indexOfObject(item.enclosures, enclosure, ['url', 'type']) === -1) {
+          if (~indexOfObject(item.enclosures, enclosure, ['url', 'type'])) {
             item.enclosures.splice(indexOfObject(item.enclosures, enclosure, ['url', 'type']), 1, enclosure);
@@ -884,2 +892,3 @@ } else {
           el.forEach(function (enc){
+            enclosure = {};
             enclosure.url = utils.get(enc['@'], 'url');
@@ -893,2 +902,3 @@ enclosure.type = utils.get(enc['@'], 'type') || utils.get(enc['@'], 'medium');
         } else {
+          enclosure = {};
           enclosure.url = utils.get(el['@'], 'url');
@@ -895,0 +905,0 @@ enclosure.type = utils.get(el['@'], 'type') || utils.get(el['@'], 'medium');

package.json

@@ -5,3 +5,3 @@ {
   "description": "Robust RSS Atom and RDF feed parsing using sax js",
-  "version": "0.17.0",
+  "version": "0.18.0",
   "keywords": [
@@ -8,0 +8,0 @@ "rss",

test/duplicate-enclosures.js

@@ -9,3 +9,3 @@ describe('duplicate enclosures', function(){
         var stream = this;
-        assert.ok(stream.read().enclosures.length === 1);
+        assert.strictEqual(stream.read().enclosures.length, 2);
         done();
@@ -12,0 +12,0 @@ })

No alert changes

Improved metrics

Total package byte prevSize

293914

increased by0.29%

Lines of code

1551

increased by0.65%

No dependency changes