find-port - npm Package Compare versions

Comparing version 0.0.3 to 1.0.0

lib/findPort.js

@@ -33,8 +33,8 @@ var net = require('net')
 
-	async.filter(ports, connect, callback)
+	async.filter(ports, probe, callback)
 }
 
-function connect(port, callback) {
+function probe(port, callback) {
 
-	var socket = net.connect(port)
+	var server = net.createServer().listen(port)
 
@@ -50,20 +50,19 @@ var calledOnce = false
 
-	socket.on('connect', function(socket) {
+	var connected = false
+
+	server.on('listening', function() {
 		clearTimeout(timeoutRef)
 
-		if (socket)
-			socket.end()
+		if (server)
+			server.close()
 
 		if (!calledOnce) {
 			calledOnce = true
-			callback(false)
+			callback(true)
 		}
 	})
 
-	socket.on('error', function(err) {
+	server.on('error', function(err) {
 		clearTimeout(timeoutRef)
 
-		if (socket)
-			socket.end();
-
 		var result = true
@@ -70,0 +69,0 @@ if (err.code === 'EADDRINUSE')

package.json

 {
   "name": "find-port",
-  "version": "0.0.3",
+  "version": "1.0.0",
   "description": "find an unused port in your localhost",
@@ -5,0 +5,0 @@ "main": "lib/findPort.js",

test/findPort.test.js

@@ -37,3 +37,2 @@ var findPort = require('../lib/findPort.js')
 
-
 		findPort(9000, 9003, function(ports) {
@@ -40,0 +39,0 @@ assert.deepEqual(ports, [9001, 9002, 9003])

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

4558

decreased by-0.09%

Lines of code

90

decreased by-1.1%

No dependency changes