finished - npm Package Compare versions

Comparing version 1.1.4 to 1.2.0

index.js

@@ -9,4 +9,6 @@
   var res = thingie.res || thingie
-  if (!socket.writable)
+
+  if (res.finished || !socket.writable) {
     return defer(callback)
+  }
 
@@ -13,0 +15,0 @@ socket.on('error', done)

package.json

 {
   "name": "finished",
   "description": "Execute a callback when a request closes, finishes, or errors",
-  "version": "1.1.4",
-  "author": {
-    "name": "Jonathan Ong",
-    "email": "[e-mail]",
-    "url": "http://jongleberry.com",
-    "twitter": "https://twitter.com/jongleberry"
-  },
+  "version": "1.2.0",
+  "author": "Jonathan Ong <[e-mail]> (http://jongleberry.com)",
   "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/expressjs/finished.git"
-  },
-  "bugs": {
-    "mail": "[e-mail]",
-    "url": "https://github.com/expressjs/finished/issues"
-  },
+  "repository": "expressjs/finished",
   "devDependencies": {
-    "mocha": "*",
-    "should": "*"
+    "istanbul": "0.2.10",
+    "mocha": "~1.20.1",
+    "should": "~4.0.1"
   },
@@ -28,4 +17,6 @@ "engine": {
   "scripts": {
-    "test": "mocha --require should --reporter spec"
+    "test": "mocha --reporter dot test/",
+    "test-cov": "istanbul cover node_modules/mocha/bin/_mocha -- --reporter dot test/",
+    "test-travis": "istanbul cover node_modules/mocha/bin/_mocha --report lcovonly -- --reporter spec test/"
   }
 }

README.md

@@ -1,3 +0,7 @@
-# finished [![Build Status](https://travis-ci.org/expressjs/finished.svg?branch=master)](https://travis-ci.org/expressjs/finished) [![NPM Version](https://badge.fury.io/js/finished.svg)](http://badge.fury.io/js/finished)
+# finished
 
+[![NPM Version](https://badge.fury.io/js/finished.svg)](http://badge.fury.io/js/finished)
+[![Build Status](https://travis-ci.org/expressjs/finished.svg?branch=master)](https://travis-ci.org/expressjs/finished)
+[![Coverage Status](https://img.shields.io/coveralls/expressjs/finished.svg?branch=master)](https://coveralls.io/r/expressjs/finished)
+
 Execute a callback when a request closes, finishes, or errors.
@@ -7,3 +11,5 @@
 
-`npm install finished`
+```sh
+$ npm install finished
+```
 
@@ -10,0 +16,0 @@ #### Uses

New alerts

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4633

increased by20.4%

Number of package files

5

increased by25%

Lines of code

21

increased by5%

Number of lines in readme file

89

increased by7.23%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Dev dependency count

3

increased by50%

Number of low maintenance alerts

2

increased by100%

Number of low supply chain risk alerts

1

increased byInfinity%

No dependency changes