github-url-from-git - npm Package Compare versions

Comparing version 1.0.0 to 1.1.0

index.js

@@ -0,8 +1,9 @@
+var re = /^(?:https?:\/\/|git:\/\/)?(?:[^@]+@)?(gist.github.com|github.com)[:\/]([^\/]+\/[^\/]+?|[0-9]+)$/
 
 module.exports = function(url){
   try {
-    var m = /^.*?github\.com[:\/]([^\/]+)\/([^\/.]+)(?:\.git)?/.exec(url);
-    var user = m[1];
-    var repo = m[2];
-    return 'https://github.com/' + user + '/' + repo;
+    var m = re.exec(url.replace(/\.git$/, ''));
+    var host = m[1];
+    var path = m[2];
+    return 'https://' + host + '/' + path;
   } catch (err) {
@@ -9,0 +10,0 @@ // ignore

package.json

 {
   "name": "github-url-from-git",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "Parse a github git url and return the github repo url",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "mocha test.js --reporter spec --require should"
   },
@@ -9,0 +9,0 @@ "repository": "",

Readme.md

@@ -25,3 +25,18 @@
   })
-});
+
+  it('should return undefined on failure', function(){
+    var url = 'git://github.com/justgord/.git';
+    assert(null == parse(url));
+  })
+
+  it('should parse git@gist urls', function() {
+    var url = '[e-mail]:3135914.git';
+    parse(url).should.equal('https://gist.github.com/3135914')
+  })
+
+  it('should parse https://gist urls', function() {
+    var url = 'https://gist.github.com/3135914.git';
+    parse(url).should.equal('https://gist.github.com/3135914')
+  })
+})
 ```

test.js

@@ -30,2 +30,12 @@
   })
+
+  it('should parse git@gist urls', function() {
+    var url = '[e-mail]:3135914.git';
+    parse(url).should.equal('https://gist.github.com/3135914')
+  })
+
+  it('should parse https://gist urls', function() {
+    var url = 'https://gist.github.com/3135914.git';
+    parse(url).should.equal('https://gist.github.com/3135914')
+  })
 })

Fixed alerts

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3565

increased by37.01%

Number of package files

7

increased by16.67%

Lines of code

43

increased by26.47%

Number of low quality alerts

1

decreased by-50%

Number of lines in readme file

42

increased by55.56%

No dependency changes