hapi-csv - npm Package Compare versions

Comparing version 3.0.1 to 3.0.2

lib/index.js

@@ -24,3 +24,3 @@ 'use strict';
                 if (route.settings.response.schema) {
-                    internals.routeMap.set(route.path, route.settings.response.schema);
+                    internals.routeMap.set(internals.createRouteMethodString(route.path, route.method), route.settings.response.schema);
                 }
@@ -64,4 +64,4 @@ });
 
-        if (preferedType && internals.routeMap.has(request.route.path)) {
-            const schema = internals.routeMap.get(request.route.path);
+        if (preferedType && internals.routeMap.has(internals.createRouteMethodString(request.route.path, request.route.method))) {
+            const schema = internals.routeMap.get(internals.createRouteMethodString(request.route.path, request.route.method));
             const csv = internals.schemaToCsv(schema, request.response.source, options.separator, options.resultKey);
@@ -254,1 +254,3 @@
 };
+
+internals.createRouteMethodString = (route, method) => route + '_' + method;

LICENSE.txt

@@ -0,0 +0,0 @@ The MIT License (MIT)

package.json

 {
   "name": "hapi-csv",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Hapi plugin for converting a Joi response schema and dataset to csv",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

README.md

@@ -0,0 +0,0 @@ # Hapi-csv [![Build Status](https://travis-ci.org/Salesflare/hapi-csv.svg?branch=master)](https://travis-ci.org/Salesflare/hapi-csv)

test/index.js

@@ -45,2 +45,6 @@ 'use strict';
         const userCSV = 'first_name,last_name,age,\n"firstName","lastName","25",';
+        const postUser = {
+            first_name: user.first_name
+        };
+        const postUserCSV = 'first_name,\n"firstName",';
         const testResponseSchema = Joi.object().keys({
@@ -51,2 +55,5 @@ first_name: Joi.string(),
         });
+        const testPostResponseSchema = Joi.array().items(Joi.object().keys({
+            first_name: Joi.string()
+        })).single();
 
@@ -70,3 +77,16 @@ before((done) => {
                 }
-            }, {
+            },
+                {
+                    method: 'POST',
+                    path: '/user',
+                    config: {
+                        handler: function (request, reply) {
+
+                            return reply(postUser);
+                        },
+                        response: {
+                            schema: testPostResponseSchema
+                        }
+                    }
+                }, {
                 method: 'GET',
@@ -267,2 +287,20 @@ path: '/userWithoutSchema',
         });
+
+        it('Replies with the right response when there are similar routes with different methods', (done) => {
+
+            return simpleServer.inject({
+                method: 'POST',
+                url: '/user',
+                headers: {
+                    'Accept': 'text/csv'
+                }
+            }, (res) => {
+
+                expect(res.result).to.equal(postUserCSV);
+                expect(res.headers['content-type']).to.equal('text/csv; charset=utf-8');
+                expect(res.headers['content-disposition']).to.equal('attachment;');
+
+                return done();
+            });
+        });
     });
@@ -269,0 +307,0 @@

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

34658

increased by1.48%

Lines of code

732

increased by4.87%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes