heroku-apps - npm Package Compare versions

Comparing version 2.4.13 to 2.4.14

lib/commands/apps/create.js

@@ -6,2 +6,3 @@ 'use strict';
 const { flags } = require('cli-engine-heroku');
+const { BuildpackCompletion, RegionComletion, RemoteCompletion, SpaceCompletion, StackCompletion } = require('cli-engine-heroku/lib/completions');
 
@@ -101,3 +102,3 @@ function* run(context, heroku) {
   args: [{ name: 'app', optional: true, description: 'name of app to create' }],
-  flags: [{ name: 'app', char: 'a', hasValue: true, hidden: true }, { name: 'addons', hasValue: true, description: 'comma-delimited list of addons to install' }, { name: 'buildpack', char: 'b', hasValue: true, description: 'buildpack url to use for this app' }, { name: 'no-remote', char: 'n', description: 'do not create a git remote' }, { name: 'remote', char: 'r', hasValue: true, description: 'the git remote to create, default "heroku"' }, { name: 'stack', char: 's', hasValue: true, description: 'the stack to create the app on' }, { name: 'space', hasValue: true, description: 'the private space to create the app in' }, { name: 'region', hasValue: true, description: 'specify region for the app to run in' }, { name: 'ssh-git', description: 'use SSH git protocol for local git remote' }, { name: 'kernel', hidden: true, hasValue: true }, { name: 'locked', hidden: true }, { name: 'json', description: 'output in json format' },
+  flags: [{ name: 'app', char: 'a', hasValue: true, hidden: true }, { name: 'addons', hasValue: true, description: 'comma-delimited list of addons to install' }, { name: 'buildpack', char: 'b', hasValue: true, description: 'buildpack url to use for this app', completion: BuildpackCompletion }, { name: 'no-remote', char: 'n', description: 'do not create a git remote' }, { name: 'remote', char: 'r', hasValue: true, description: 'the git remote to create, default "heroku"', completion: RemoteCompletion }, { name: 'stack', char: 's', hasValue: true, description: 'the stack to create the app on', completion: StackCompletion }, { name: 'space', hasValue: true, description: 'the private space to create the app in', completion: SpaceCompletion }, { name: 'region', hasValue: true, description: 'specify region for the app to run in', completion: RegionComletion }, { name: 'ssh-git', description: 'use SSH git protocol for local git remote' }, { name: 'kernel', hidden: true, hasValue: true }, { name: 'locked', hidden: true }, { name: 'json', description: 'output in json format' },
   // flags.org({name: 'org', hasValue: true}),
@@ -104,0 +105,0 @@ flags.team({ name: 'team', hasValue: true })],

lib/commands/apps/index.js

@@ -6,2 +6,3 @@ 'use strict';
 const { flags } = require('cli-engine-heroku');
+const { SpaceCompletion } = require('cli-engine-heroku/lib/completions');
 
@@ -80,3 +81,3 @@ function* run(context, heroku) {
     example2
-    
+
     === Collaborated Apps
@@ -86,3 +87,3 @@ theirapp   [e-mail]`,
   wantsOrg: true,
-  flags: [{ name: 'all', char: 'A', description: 'include apps in all teams' }, { name: 'json', description: 'output in json format' }, { name: 'space', char: 's', hasValue: true, description: 'filter by space' }, { name: 'personal', char: 'p', description: 'list apps in personal account when a default team is set' },
+  flags: [{ name: 'all', char: 'A', description: 'include apps in all teams' }, { name: 'json', description: 'output in json format' }, { name: 'space', char: 's', hasValue: true, description: 'filter by space', completion: SpaceCompletion }, { name: 'personal', char: 'p', description: 'list apps in personal account when a default team is set' },
   // flags.org({name: 'org', hasValue: true}),
@@ -89,0 +90,0 @@ flags.team({ name: 'team', hasValue: true })],

lib/commands/auth/whoami.js

@@ -25,3 +25,3 @@ 'use strict';
   notloggedin() {
-    this.out.error('not logged in', 100);
+    this.out.error('not logged in', { exitCode: 100 });
   }
@@ -28,0 +28,0 @@ }

lib/commands/domains/index.js

@@ -5,2 +5,3 @@ 'use strict';
 let co = require('co');
+let Uri = require('urijs');
 
@@ -22,5 +23,8 @@ function* run(context, heroku) {
     if (customDomains.length > 0) {
+      customDomains.forEach(record => {
+        record.recordType = isApexDomain(record.hostname) ? 'ALIAS or ANAME' : 'CNAME';
+      });
       cli.styledHeader(`${context.app} Custom Domains`);
       cli.table(customDomains, {
-        columns: [{ key: 'hostname', label: 'Domain Name' }, { key: 'cname', label: 'DNS Target' }]
+        columns: [{ key: 'hostname', label: 'Domain Name' }, { key: 'recordType', label: 'DNS Record Type' }, { key: 'cname', label: 'DNS Target' }]
       });
@@ -31,2 +35,7 @@ }
 
+function isApexDomain(hostname) {
+  let a = new Uri('http://' + hostname);
+  return a.subdomain() === '';
+}
+
 module.exports = {
@@ -43,5 +52,5 @@ topic: 'domains',
     === example Custom Domains
-    Domain Name  DNS Target
-    ───────────  ─────────────────────
-    example.com  example.herokuapp.com
+    Domain Name      DNS Record Type  DNS Target
+    ───────────      ───────────────  ──────────
+    www.example.com  CNAME            www.example.herokudns.com
   `,
@@ -48,0 +57,0 @@ needsApp: true,

package.json

 {
   "name": "heroku-apps",
   "description": "Heroku CLI plugin to manage apps.",
-  "version": "2.4.13",
+  "version": "2.4.14",
   "author": "Jeff Dickey (@dickeyxxx)",
@@ -11,10 +11,10 @@ "bugs": {
     "bluebird": "^3.5.0",
-    "cli-engine-command": "^8.0.15",
-    "cli-engine-config": "^3.2.0",
-    "cli-engine-heroku": "^4.0.1",
+    "cli-engine-command": "^8.0.17",
+    "cli-engine-config": "^3.3.1",
+    "cli-engine-heroku": "^4.1.0",
     "co": "^4.6.0",
     "co-wait": "^0.0.0",
     "filesize": "^3.5.10",
-    "heroku-cli-util": "^6.2.7",
-    "inquirer": "^3.2.3",
+    "heroku-cli-util": "^6.2.8",
+    "inquirer": "^3.3.0",
     "lodash": "^4.17.4",
@@ -44,3 +44,3 @@ "lodash.compact": "^3.0.1",
     "mkdirp": "^0.5.1",
-    "mz": "^2.6.0",
+    "mz": "^2.7.0",
     "netrc-parser": "^2.0.3",
@@ -56,4 +56,4 @@ "shell-escape": "^0.2.0",
     "babel-core": "^6.26.0",
-    "babel-eslint": "^7.2.3",
-    "babel-jest": "^21.0.2",
+    "babel-eslint": "^8.0.1",
+    "babel-jest": "^21.2.0",
     "babel-plugin-transform-class-properties": "^6.24.1",
@@ -64,26 +64,27 @@ "babel-plugin-transform-es2015-modules-commonjs": "^6.26.0",
     "changelog": "^1.3.0",
-    "eslint": "^4.6.1",
+    "eslint": "^4.7.2",
     "eslint-config-standard": "^10.2.1",
-    "eslint-plugin-flowtype": "^2.35.1",
+    "eslint-plugin-flowtype": "^2.36.0",
     "eslint-plugin-import": "^2.7.0",
-    "eslint-plugin-jest": "^21.0.2",
+    "eslint-plugin-jest": "^21.2.0",
     "eslint-plugin-node": "^5.1.1",
     "eslint-plugin-promise": "^3.5.0",
     "eslint-plugin-standard": "^3.0.1",
-    "flow-bin": "^0.54.1",
-    "fs-extra": "^4.0.1",
+    "flow-bin": "0.54",
+    "fs-extra": "^4.0.2",
     "istanbul-combine": "^0.3.0",
-    "jest": "^21.0.2",
+    "jest": "^21.2.0",
     "lolex": "^2.1.2",
-    "mocha": "^3.5.0",
+    "mocha": "^3.5.3",
     "mocha-junit-reporter": "1.13.0",
     "mockdate": "^2.0.2",
-    "nock": "^9.0.14",
+    "nock": "9.0.14",
     "nyc": "^11.2.1",
     "proxyquire": "^1.8.0",
-    "rimraf": "^2.6.1",
+    "rimraf": "^2.6.2",
     "std-mocks": "1.0.1",
-    "testdouble": "^3.2.5",
+    "testdouble": "^3.2.6",
     "time-require": "0.1.2",
-    "unexpected": "^10.35.0"
+    "unexpected": "^10.35.0",
+    "urijs": "^1.18.12"
   },
@@ -90,0 +91,0 @@ "files": [

No alert changes

Improved metrics

Total package byte prevSize

124295

increased by0.66%

Lines of code

2888

increased by0.35%

Worsened metrics

Dev dependency count

34

increased by3.03%

Dependency changes

• Updatedcli-engine-command@^8.0.17

• Updatedcli-engine-config@^3.3.1

• Updatedcli-engine-heroku@^4.1.0

• Updatedheroku-cli-util@^6.2.8

• Updatedinquirer@^3.3.0

• Updatedmz@^2.7.0