http-proxy - npm Package Compare versions

Comparing version 1.16.0 to 1.16.1

lib/http-proxy/passes/web-outgoing.js

@@ -87,9 +87,14 @@ var url    = require('url'),
     var rewriteCookieDomainConfig = options.cookieDomainRewrite,
+        // In proxyRes.rawHeaders Set-Cookie headers are sparse.
+        // so, we'll collect Set-Cookie headers, and set them in the response as an array.
+        setCookies = [],
         setHeader = function(key, header) {
-          if (header != undefined) {
-            if (rewriteCookieDomainConfig && key.toLowerCase() === 'set-cookie') {
-              header = common.rewriteCookieDomain(header, rewriteCookieDomainConfig);
-            }
-            res.setHeader(String(key).trim(), header);
+          if (header == undefined) return;
+          if (key.toLowerCase() !== 'set-cookie') {
+            return res.setHeader(String(key).trim(), header);
           }
+          if (rewriteCookieDomainConfig) {
+            header = common.rewriteCookieDomain(header, rewriteCookieDomainConfig);
+          }
+          setCookies.push(header); // defer to the end when we have all of them
         };
@@ -108,3 +113,3 @@
         setHeader(key, header);
-      };
+      }
     } else {
@@ -116,2 +121,5 @@ Object.keys(proxyRes.headers).forEach(function(key) {
     }
+    if (setCookies.length) {
+      res.setHeader('Set-Cookie', setCookies.length === 1 ? setCookies[0] : setCookies);
+    }
   },
@@ -118,0 +126,0 @@

package.json

 {
   "name": "http-proxy",
-  "version": "1.16.0",
+  "version": "1.16.1",
   "repository": {
@@ -5,0 +5,0 @@ "type": "git",

No alert changes

Improved metrics

Total package byte prevSize

47223

increased by0.87%

Lines of code

831

increased by0.97%

No dependency changes