http2 - npm Package Compare versions

Comparing version 3.3.5 to 3.3.6

HISTORY.md

 Version history
 ===============
 
+### 3.3.6 (2016-09-16) ###
+* We were not appropriately sending HPACK context updates when receiving SETTINGS_HEADER_TABLE_SIZE. This release fixes that bug.
+
 ### 3.3.5 (2016-09-06) ###
@@ -5,0 +8,0 @@ * Fix issues with large DATA frames (https://github.com/molnarg/node-http2/issues/207)

lib/protocol/compressor.js

@@ -1093,2 +1093,6 @@ // The implementation of the [HTTP/2 Header Compression][http2-compression] spec is separated from
   this._table = new HeaderTable(this._log);
+
+  this.tableSizeChangePending = false;
+  this.lowestTableSizePending = 0;
+  this.tableSizeSetting = DEFAULT_HEADER_TABLE_LIMIT;
 }
@@ -1099,2 +1103,7 @@
   this._table.setSizeLimit(size);
+  if (!this.tableSizeChangePending || size < this.lowestTableSizePending) {
+    this.lowestTableSizePending = size;
+  }
+  this.tableSizeSetting = size;
+  this.tableSizeChangePending = true;
 };
@@ -1107,2 +1116,12 @@
   var compressor = new HeaderSetCompressor(this._log, this._table);
+
+  if (this.tableSizeChangePending) {
+    if (this.lowestTableSizePending < this.tableSizeSetting) {
+      compressor.send({contextUpdate: true, newMaxSize: this.lowestTableSizePending,
+                       name: "", value: "", index: 0});
+    }
+    compressor.send({contextUpdate: true, newMaxSize: this.tableSizeSetting,
+                     name: "", value: "", index: 0});
+    this.tableSizeChangePending = false;
+  }
   var colonHeaders = [];
@@ -1109,0 +1128,0 @@ var nonColonHeaders = [];

lib/protocol/flow.js

@@ -170,3 +170,3 @@ var assert = require('assert');
 
-    assert((moreNeeded == false) ||                              // * output queue is full
+    assert((!moreNeeded) ||                              // * output queue is full
            (this._queue.length === 0) ||                         // * flow control queue is empty
@@ -173,0 +173,0 @@ (!this._window && (this._queue[0].type === 'DATA'))); // * waiting for window update

package.json

 {
   "name": "http2",
-  "version": "3.3.5",
+  "version": "3.3.6",
   "description": "An HTTP/2 client and server implementation",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

No alert changes

Improved metrics

Lines of code

7697

increased by48.71%

Worsened metrics

Total package byte prevSize

958146

decreased by-67.53%

Number of package files

24

decreased by-25%

No dependency changes