iobroker.comfoairq - npm Package Compare versions

Comparing version 0.0.3 to 0.0.4

io-package.json

 {
     "common": {
         "name": "comfoairq",
-        "version": "0.0.3",
+        "version": "0.0.4",
         "news": {
+            "0.0.4": {
+                "en": "Improved discovery of comfoairq devices",
+                "de": "Finden von ComfoAirQ Geräten verbessert"
+            },
             "0.0.3": {
@@ -59,3 +63,4 @@ "en": "Bugfixes",
         "pin": "0000",
-        "port": "56747"
+        "port": "56747",
+        "multicastAddr": "192.168.1.255"
     },
@@ -62,0 +67,0 @@ "objects": [],

main.js

@@ -82,3 +82,3 @@ /* jshint -W097 */
 
-        if (this.config.host && this.config.port && this.config.uuid) {
+        if (this.config.host && this.config.port && this.config.uuid && this.config.pin) {
             if (this.sensors.length > 0) {
@@ -89,12 +89,12 @@ this.log.debug('Active sensors by configuration: ' + JSON.stringify(this.sensors));
                     {
-                        'uuid' : this.uuid,
-                        'device' : this.deviceName,
+                        uuid: this.uuid,
+                        device: this.deviceName,
 
-                        'comfoair': this.config.host,
-                        'port': Number(this.config.port),
-                        'comfouuid': this.config.uuid,
-                        'pin': parseInt(this.config.pin),
+                        comfoair: this.config.host,
+                        port: Number(this.config.port),
+                        comfouuid: this.config.uuid,
+                        pin: parseInt(this.config.pin),
 
-                        'debug': false,
-                        'logger': this.log.debug
+                        debug: false,
+                        logger: this.log.debug
                     }
@@ -168,13 +168,15 @@ );
             }
-        } else {
+        } else if (this.config.multicastAddr && this.config.port) {
             // Dicover Zehnder devices
-            this.log.warn('Device information not configured - starting discovery');
+            this.log.warn('Device information not configured - starting discovery on ' + this.config.multicastAddr);
 
             this.zehnder = new comfoconnect(
                 {
-                    'uuid' : this.uuid,
-                    'device' : this.deviceName,
-                    'port': Number(this.config.port),
-                    'debug': false,
-                    'logger': this.log.debug
+                    uuid: this.uuid,
+                    device: this.deviceName,
+
+                    port: Number(this.config.port),
+
+                    debug: false,
+                    logger: this.log.debug
                 }
@@ -184,7 +186,9 @@ );
             try {
-                const discoverResult = await this.zehnder.discover('172.16.255.255');
-                this.log.info('Device discovery finished: ' + JSON.stringify(discoverResult));
+                const discoverResult = await this.zehnder.discover(this.config.multicastAddr);
+                this.log.info('Device discovery finished - use these information for instance configuration: ' + JSON.stringify(discoverResult));
             } catch (ex) {
                 this.log.error('error while discovery: ' + JSON.stringify(ex));
             }
+        } else {
+            this.log.error('Instance configuration invalid');
         }
@@ -191,0 +195,0 @@ }

package.json

 {
   "name": "iobroker.comfoairq",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "ioBroker ComfoAirQ Adapter",
@@ -5,0 +5,0 @@ "author": {

README.md

@@ -21,12 +21,8 @@ ![Logo](admin/comfoairq.png)
 
-## Credits
+## Changelog
 
-Development of this ioBroker Adapter was possible on the work performed by:
+### 0.0.4
 
-* Jan Van Belle (https://github.com/herrJones/node-comfoairq)
-* Michael Arnauts (https://github.com/michaelarnauts/comfoconnect)
-* Marco Hoyer (https://github.com/marco-hoyer/zcan) and its forks on github (djwlindenaar, decontamin4t0R)
+* (klein0r) Improved discovery of comfoairq devices
 
-## Changelog
-
 ### 0.0.3
@@ -48,2 +44,10 @@
 
+## Credits
+
+Development of this ioBroker Adapter was possible on the work performed by:
+
+* Jan Van Belle (https://github.com/herrJones/node-comfoairq)
+* Michael Arnauts (https://github.com/michaelarnauts/comfoconnect)
+* Marco Hoyer (https://github.com/marco-hoyer/zcan) and its forks on github (djwlindenaar, decontamin4t0R)
+
 ## License
@@ -50,0 +54,0 @@

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

61420

increased by1.37%

Lines of code

462

increased by0.43%

Number of lines in readme file

73

increased by5.8%

Number of medium supply chain risk alerts

0

decreased by-100%

No dependency changes