ldap-filter - npm Package Compare versions

Comparing version 0.2.0 to 0.2.1

lib/and_filter.js

@@ -49,3 +49,4 @@ // Copyright 2014 Mark Cavage, Inc.  All rights reserved.
   if (this.filters.length === 0) {
-    return false;
+    /* true per RFC4526 */
+    return true;
   }
@@ -52,0 +53,0 @@

package.json

@@ -9,3 +9,3 @@ {
   "description": "API for handling LDAP-style filters",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "license": "MIT",
@@ -12,0 +12,0 @@ "repository": {

test/and.test.js

@@ -76,7 +76,6 @@ // Copyright 2014 Mark Cavage, Inc.  All rights reserved.
 
-test('match empty', function (t) {
+test('RFC-4526 - empty AND', function (t) {
   var f = new AndFilter();
-  t.ok(f);
-  t.ok(!f.matches({ foo: 'bar', zig: 'zonk' }));
+  t.ok(f.matches({}));
   t.end();
 });

test/or.test.js

@@ -75,1 +75,7 @@ // Copyright 2014 Mark Cavage, Inc.  All rights reserved.
 });
+
+test('RFC-4526 - empty OR', function (t) {
+  var f = new OrFilter();
+  t.notOk(f.matches({}));
+  t.end();
+});

No alert changes

Improved metrics

Total package byte prevSize

59959

increased by0.18%

Lines of code

2160

increased by0.23%

No dependency changes