lens-core - npm Package Compare versions

Comparing version 0.0.1 to 0.0.2

coverage/coverage-final.json

@@ -1,2 +0,2 @@
-{"/Users/ricardocanastro/dev/personal/lens/packages/core/src/index.js": {"path":"/Users/ricardocanastro/dev/personal/lens/packages/core/src/index.js","statementMap":{"0":{"start":{"line":10,"column":19},"end":{"line":10,"column":51}},"1":{"start":{"line":11,"column":4},"end":{"line":11,"column":21}},"2":{"start":{"line":12,"column":4},"end":{"line":12,"column":22}},"3":{"start":{"line":14,"column":4},"end":{"line":14,"column":18}},"4":{"start":{"line":23,"column":19},"end":{"line":23,"column":58}},"5":{"start":{"line":24,"column":16},"end":{"line":24,"column":39}},"6":{"start":{"line":25,"column":4},"end":{"line":25,"column":35}},"7":{"start":{"line":26,"column":4},"end":{"line":26,"column":37}},"8":{"start":{"line":27,"column":4},"end":{"line":27,"column":38}},"9":{"start":{"line":29,"column":4},"end":{"line":29,"column":30}},"10":{"start":{"line":43,"column":19},"end":{"line":50,"column":6}},"11":{"start":{"line":53,"column":19},"end":{"line":53,"column":53}},"12":{"start":{"line":54,"column":20},"end":{"line":54,"column":43}},"13":{"start":{"line":55,"column":4},"end":{"line":55,"column":37}},"14":{"start":{"line":58,"column":4},"end":{"line":58,"column":29}},"15":{"start":{"line":61,"column":22},"end":{"line":61,"column":58}},"16":{"start":{"line":63,"column":4},"end":{"line":110,"column":7}},"17":{"start":{"line":64,"column":23},"end":{"line":64,"column":24}},"18":{"start":{"line":67,"column":8},"end":{"line":109,"column":9}},"19":{"start":{"line":69,"column":12},"end":{"line":69,"column":31}},"20":{"start":{"line":71,"column":12},"end":{"line":73,"column":13}},"21":{"start":{"line":72,"column":16},"end":{"line":72,"column":59}},"22":{"start":{"line":76,"column":31},"end":{"line":81,"column":13}},"23":{"start":{"line":82,"column":27},"end":{"line":82,"column":52}},"24":{"start":{"line":84,"column":12},"end":{"line":108,"column":19}},"25":{"start":{"line":90,"column":20},"end":{"line":94,"column":22}},"26":{"start":{"line":96,"column":20},"end":{"line":96,"column":31}},"27":{"start":{"line":98,"column":20},"end":{"line":107,"column":21}},"28":{"start":{"line":99,"column":24},"end":{"line":106,"column":26}},"29":{"start":{"line":113,"column":0},"end":{"line":113,"column":30}},"30":{"start":{"line":114,"column":0},"end":{"line":114,"column":66}},"31":{"start":{"line":115,"column":0},"end":{"line":115,"column":34}}},"fnMap":{"0":{"name":"getCanvas","decl":{"start":{"line":9,"column":9},"end":{"line":9,"column":18}},"loc":{"start":{"line":9,"column":25},"end":{"line":15,"column":1}},"line":9},"1":{"name":"convertImageDataToCanvasURL","decl":{"start":{"line":22,"column":9},"end":{"line":22,"column":36}},"loc":{"start":{"line":22,"column":48},"end":{"line":30,"column":1}},"line":22},"2":{"name":"applyFilter","decl":{"start":{"line":42,"column":9},"end":{"line":42,"column":20}},"loc":{"start":{"line":42,"column":57},"end":{"line":111,"column":1}},"line":42},"3":{"name":"(anonymous_3)","decl":{"start":{"line":63,"column":23},"end":{"line":63,"column":24}},"loc":{"start":{"line":63,"column":34},"end":{"line":110,"column":5}},"line":63},"4":{"name":"(anonymous_4)","decl":{"start":{"line":86,"column":22},"end":{"line":86,"column":23}},"loc":{"start":{"line":86,"column":34},"end":{"line":108,"column":17}},"line":86}},"branchMap":{"0":{"loc":{"start":{"line":58,"column":15},"end":{"line":58,"column":28}},"type":"binary-expr","locations":[{"start":{"line":58,"column":15},"end":{"line":58,"column":23}},{"start":{"line":58,"column":27},"end":{"line":58,"column":28}}],"line":58},"1":{"loc":{"start":{"line":71,"column":12},"end":{"line":73,"column":13}},"type":"if","locations":[{"start":{"line":71,"column":12},"end":{"line":73,"column":13}},{"start":{"line":71,"column":12},"end":{"line":73,"column":13}}],"line":71},"2":{"loc":{"start":{"line":98,"column":20},"end":{"line":107,"column":21}},"type":"if","locations":[{"start":{"line":98,"column":20},"end":{"line":107,"column":21}},{"start":{"line":98,"column":20},"end":{"line":107,"column":21}}],"line":98}},"s":{"0":2,"1":2,"2":2,"3":2,"4":1,"5":1,"6":1,"7":1,"8":1,"9":1,"10":1,"11":1,"12":1,"13":1,"14":1,"15":1,"16":1,"17":1,"18":1,"19":4,"20":4,"21":1,"22":4,"23":4,"24":4,"25":4,"26":4,"27":4,"28":1,"29":1,"30":1,"31":1},"f":{"0":2,"1":1,"2":1,"3":1,"4":4},"b":{"0":[1,0],"1":[1,3],"2":[1,3]},"_coverageSchema":"332fd63041d2c1bcb487cc26dd0d5f7d97098a6c","hash":"93d25b3a9c9e802fbc1ffdc7583d502b9070704e"}
+{"/Users/ricardocanastro/dev/personal/lens/packages/core/src/index.js": {"path":"/Users/ricardocanastro/dev/personal/lens/packages/core/src/index.js","statementMap":{"0":{"start":{"line":10,"column":19},"end":{"line":10,"column":51}},"1":{"start":{"line":11,"column":4},"end":{"line":11,"column":21}},"2":{"start":{"line":12,"column":4},"end":{"line":12,"column":22}},"3":{"start":{"line":14,"column":4},"end":{"line":14,"column":18}},"4":{"start":{"line":23,"column":19},"end":{"line":23,"column":58}},"5":{"start":{"line":24,"column":16},"end":{"line":24,"column":39}},"6":{"start":{"line":25,"column":4},"end":{"line":25,"column":35}},"7":{"start":{"line":26,"column":4},"end":{"line":26,"column":37}},"8":{"start":{"line":27,"column":4},"end":{"line":27,"column":38}},"9":{"start":{"line":29,"column":4},"end":{"line":29,"column":30}},"10":{"start":{"line":43,"column":19},"end":{"line":55,"column":6}},"11":{"start":{"line":58,"column":19},"end":{"line":58,"column":53}},"12":{"start":{"line":59,"column":20},"end":{"line":59,"column":43}},"13":{"start":{"line":60,"column":4},"end":{"line":60,"column":37}},"14":{"start":{"line":63,"column":4},"end":{"line":63,"column":29}},"15":{"start":{"line":66,"column":22},"end":{"line":66,"column":58}},"16":{"start":{"line":68,"column":4},"end":{"line":115,"column":7}},"17":{"start":{"line":69,"column":23},"end":{"line":69,"column":24}},"18":{"start":{"line":72,"column":8},"end":{"line":114,"column":9}},"19":{"start":{"line":74,"column":12},"end":{"line":74,"column":31}},"20":{"start":{"line":76,"column":12},"end":{"line":78,"column":13}},"21":{"start":{"line":77,"column":16},"end":{"line":77,"column":59}},"22":{"start":{"line":81,"column":31},"end":{"line":86,"column":13}},"23":{"start":{"line":87,"column":27},"end":{"line":87,"column":52}},"24":{"start":{"line":89,"column":12},"end":{"line":113,"column":19}},"25":{"start":{"line":95,"column":20},"end":{"line":99,"column":22}},"26":{"start":{"line":101,"column":20},"end":{"line":101,"column":31}},"27":{"start":{"line":103,"column":20},"end":{"line":112,"column":21}},"28":{"start":{"line":104,"column":24},"end":{"line":111,"column":26}},"29":{"start":{"line":118,"column":0},"end":{"line":118,"column":30}},"30":{"start":{"line":119,"column":0},"end":{"line":119,"column":66}},"31":{"start":{"line":120,"column":0},"end":{"line":120,"column":34}}},"fnMap":{"0":{"name":"getCanvas","decl":{"start":{"line":9,"column":9},"end":{"line":9,"column":18}},"loc":{"start":{"line":9,"column":25},"end":{"line":15,"column":1}},"line":9},"1":{"name":"convertImageDataToCanvasURL","decl":{"start":{"line":22,"column":9},"end":{"line":22,"column":36}},"loc":{"start":{"line":22,"column":48},"end":{"line":30,"column":1}},"line":22},"2":{"name":"applyFilter","decl":{"start":{"line":42,"column":9},"end":{"line":42,"column":20}},"loc":{"start":{"line":42,"column":61},"end":{"line":116,"column":1}},"line":42},"3":{"name":"(anonymous_3)","decl":{"start":{"line":68,"column":23},"end":{"line":68,"column":24}},"loc":{"start":{"line":68,"column":34},"end":{"line":115,"column":5}},"line":68},"4":{"name":"(anonymous_4)","decl":{"start":{"line":91,"column":22},"end":{"line":91,"column":23}},"loc":{"start":{"line":91,"column":34},"end":{"line":113,"column":17}},"line":91}},"branchMap":{"0":{"loc":{"start":{"line":63,"column":15},"end":{"line":63,"column":28}},"type":"binary-expr","locations":[{"start":{"line":63,"column":15},"end":{"line":63,"column":23}},{"start":{"line":63,"column":27},"end":{"line":63,"column":28}}],"line":63},"1":{"loc":{"start":{"line":76,"column":12},"end":{"line":78,"column":13}},"type":"if","locations":[{"start":{"line":76,"column":12},"end":{"line":78,"column":13}},{"start":{"line":76,"column":12},"end":{"line":78,"column":13}}],"line":76},"2":{"loc":{"start":{"line":103,"column":20},"end":{"line":112,"column":21}},"type":"if","locations":[{"start":{"line":103,"column":20},"end":{"line":112,"column":21}},{"start":{"line":103,"column":20},"end":{"line":112,"column":21}}],"line":103}},"s":{"0":2,"1":2,"2":2,"3":2,"4":1,"5":1,"6":1,"7":1,"8":1,"9":1,"10":1,"11":1,"12":1,"13":1,"14":1,"15":1,"16":1,"17":1,"18":1,"19":4,"20":4,"21":1,"22":4,"23":4,"24":4,"25":4,"26":4,"27":4,"28":1,"29":1,"30":1,"31":1},"f":{"0":2,"1":1,"2":1,"3":1,"4":4},"b":{"0":[1,0],"1":[1,3],"2":[1,3]},"_coverageSchema":"332fd63041d2c1bcb487cc26dd0d5f7d97098a6c","hash":"0c60051f8af58ff2a6633906b09ad9ba18fa256d"}
 }

dist/lens-core.umd.js

@@ -157,7 +157,12 @@ (function(global, factory) {
      */
-    function applyFilter(data, transform, options, nWorkers) {
+    function applyFilter(_ref) {
+        var data = _ref.data,
+            transform = _ref.transform,
+            options = _ref.options,
+            nWorkers = _ref.nWorkers;
+
         var worker = workerize(
             '\n        var transform = ' +
                 transform +
-                ';\n\n        export function execute(canvas, index, length, options) {\n            transform(canvas.data, length, options);\n            return { result: canvas, index };\n        }\n    '
+                ';\n\n        export function execute(canvas, index, length, options) {\n            canvas.data = transform({ \n                data: canvas.data, \n                length: length, \n                options: options\n            });\n\n            return { result: canvas, index: index };\n        }\n    '
         );
@@ -164,0 +169,0 @@

package.json

 {
   "name": "lens-core",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "Core module for lens-filter",
@@ -5,0 +5,0 @@ "main": "dist/lens-core.umd.js",

sandbox/bundle.js

@@ -48,3 +48,3 @@ (function (global, factory) {
      */
-    function applyFilter(data, transform, options, nWorkers) {
+    function applyFilter({ data, transform, options, nWorkers }) {
         const worker = workerize(`
@@ -54,4 +54,9 @@ var transform = ${transform};
         export function execute(canvas, index, length, options) {
-            transform(canvas.data, length, options);
-            return { result: canvas, index };
+            canvas.data = transform({ 
+                data: canvas.data, 
+                length: length, 
+                options: options
+            });
+
+            return { result: canvas, index: index };
         }
@@ -103,3 +108,7 @@ `);
 
-    const transform = (data, length, options) => {
+    // exports.getCanvas = getCanvas;
+    // exports.convertImageDataToCanvasURL = convertImageDataToCanvasURL;
+    // exports.applyFilter = applyFilter;
+
+    const transform = ({ data, length, options }) => {
         const hex = options.color.charAt(0) === '#' ? options.color.substr(1) : options.color;
@@ -117,2 +126,4 @@ const colorRGB = {
         }
+
+        return data;
     };
@@ -130,4 +141,6 @@
             const data = context.getImageData(0, 0, img.width, img.height);
+            const options = { color: '#008080', level: 50 };
+            const nWorkers = 4;
 
-            return applyFilter(data, transform, { color: '#008080', level: 50 }, 4).then(function (results) {
+            return applyFilter({ data, transform, options, nWorkers }).then(results => {
                 const target = document.querySelectorAll('#target-1')[0];
@@ -134,0 +147,0 @@ const image = document.createElement('img');

sandbox/sandbox.js

 import { applyFilter, convertImageDataToCanvasURL } from '../src/index';
 
-const transform = (data, length, options) => {
+const transform = ({ data, length, options }) => {
     const hex =
@@ -19,2 +19,4 @@ options.color.charAt(0) === '#'
     }
+
+    return data;
 };
@@ -32,14 +34,13 @@
         const data = context.getImageData(0, 0, img.width, img.height);
+        const options = { color: '#008080', level: 50 };
+        const nWorkers = 4;
 
-        return applyFilter(
-            data,
-            transform,
-            { color: '#008080', level: 50 },
-            4
-        ).then(function(results) {
-            const target = document.querySelectorAll('#target-1')[0];
-            const image = document.createElement('img');
-            image.setAttribute('src', convertImageDataToCanvasURL(results));
-            target.appendChild(image);
-        });
+        return applyFilter({ data, transform, options, nWorkers }).then(
+            results => {
+                const target = document.querySelectorAll('#target-1')[0];
+                const image = document.createElement('img');
+                image.setAttribute('src', convertImageDataToCanvasURL(results));
+                target.appendChild(image);
+            }
+        );
     };
@@ -46,0 +47,0 @@

src/__tests__/index-spec.js

@@ -74,8 +74,8 @@ import workerize from 'workerize';
 
-            result = await victim.applyFilter(
+            result = await victim.applyFilter({
                 data,
-                mockTransform,
+                transform: mockTransform,
                 options,
                 nWorkers
-            );
+            });
         });
@@ -82,0 +82,0 @@

src/index.js

@@ -42,3 +42,3 @@ import workerize from 'workerize';
  */
-function applyFilter(data, transform, options, nWorkers) {
+function applyFilter({ data, transform, options, nWorkers }) {
     const worker = workerize(`
@@ -48,4 +48,9 @@ var transform = ${transform};
         export function execute(canvas, index, length, options) {
-            transform(canvas.data, length, options);
-            return { result: canvas, index };
+            canvas.data = transform({ 
+                data: canvas.data, 
+                length: length, 
+                options: options
+            });
+
+            return { result: canvas, index: index };
         }
@@ -52,0 +57,0 @@ `);

No alert changes

Improved metrics

Total package byte prevSize

167446

increased by1.22%

Lines of code

1154

increased by1.58%

No dependency changes