leo-connector-common - npm Package Compare versions

Comparing version 1.1.4 to 1.1.5-109-ga8339d0

botHelper.js

@@ -219,3 +219,3 @@ "use strict";
 						} else {
-							stats.checkpoint(callback)
+							stats.checkpoint(callback);
 						}
@@ -295,4 +295,4 @@ });
 			}
-		}
+		};
 	};
 };

datawarehouse/combine.js

@@ -24,3 +24,3 @@ const exec = require('child_process').exec;
 		if (count % 10000 == 0) {
-			console.log(count);
+			console.log(count, obj.eid);
 		}
@@ -112,27 +112,27 @@ let payload = obj.payload;
 		ls.pipe(fs.createReadStream(sortedFile), ls.split(), ls.through((line, done, push) => {
-				try {
-					var id = line.substr(0, 32);
-					var data = JSON.parse(line.substr(42));
-				} catch (e) {
-					console.log(e);
-					console.log(file);
-					console.log(line.toString());
-					process.exit();
-				}
-				if (lastObj && id === lastId) {
-					lastObj = merge(lastObj, data);
-				} else {
-					if (lastObj) {
-						push(lastObj);
-					}
-					lastObj = data;
-				}
-				lastId = id;
-				done();
-			},
-			function(done) {
+			try {
+				var id = line.substr(0, 32);
+				var data = JSON.parse(line.substr(42));
+			} catch (e) {
+				console.log(e);
+				console.log(file);
+				console.log(line.toString());
+				process.exit();
+			}
+			if (lastObj && id === lastId) {
+				lastObj = merge(lastObj, data);
+			} else {
 				if (lastObj) {
-					done(null, lastObj);
+					push(lastObj);
 				}
-			}), pass, (err) => {
+				lastObj = data;
+			}
+			lastId = id;
+			done();
+		},
+		function(done) {
+			if (lastObj) {
+				done(null, lastObj);
+			}
+		}), pass, (err) => {
 			if (err) {
@@ -147,2 +147,2 @@ pass.emit('error', err);
 	return pass;
-}
+}

datawarehouse/load.js

@@ -7,2 +7,3 @@ "use strict";
 const async = require("async");
+
 module.exports = function(client, tableConfig, stream, callback) {
@@ -121,3 +122,3 @@ let tableStatuses = {};
 									on: f,
-									destination: client.getDimensionColumn(f),
+									destination: client.getDimensionColumn(f, field),
 									link_date: "_auditdate",
@@ -124,0 +125,0 @@ sk: tableSks[link.table]

package.json

 {
 	"name": "leo-connector-common",
-	"version": "1.1.4",
+	"version": "1.1.5-109-ga8339d0",
 	"description": "Common package for all Leo Platform database connectors",
@@ -23,10 +23,9 @@ "main": "index.js",
 		"eslint": "^4.17.0",
-		"mocha": "^5.0.0",
-		"mysql": "^2.15.0"
+		"mocha": "^5.0.0"
 	},
 	"dependencies": {
 		"async": "^2.6.0",
-		"leo-sdk": "^1.1.0",
+		"leo-sdk": "^1.1.1",
 		"moment": "^2.22.1"
 	}
 }

sql/loader/lib.js

@@ -31,3 +31,3 @@ const async = require("async");
 										done(err);
-									});
+									}, {inRowMode: false});
 								} else {
@@ -41,3 +41,3 @@ let sql = idthing.query.replace(/\(\?\)/, lookupIds);
 										done(err);
-									});
+									}, {inRowMode: false});
 								}
@@ -62,3 +62,3 @@
 							done(err);
-						});
+						}, {inRowMode: false});
 					});
@@ -65,0 +65,0 @@ }

sql/loaderJoinTable.js

@@ -62,4 +62,2 @@ "use strict";
 
-
-
 	function submit(push, done) {
@@ -241,2 +239,12 @@ async.doWhilst((done) => {
 		});
+		function getId(o) {
+			if (Array.isArray(idKeys)) {
+				return {
+					[idKeys[0]]: o[idKeys[0]],
+					[idKeys[1]]: o[idKeys[1]]
+				};
+			} else {
+				return o[idKeys];
+			}
+		}
 		async.parallelLimit(tasks, 5, (err) => {
@@ -248,13 +256,2 @@ if (err) {
 
-				function getId(o) {
-					if (Array.isArray(idKeys)) {
-						return {
-							[idKeys[0]]: o[idKeys[0]],
-							[idKeys[1]]: o[idKeys[1]]
-						};
-					} else {
-						return o[idKeys];
-					}
-				}
-
 				ids.forEach((id, i) => {
@@ -261,0 +258,0 @@ // skip the domain if there is no data with it

sql/snapshotter.js

@@ -69,3 +69,3 @@ const leo = require("leo-sdk");
 		if (err) {
-			callback(err)
+			callback(err);
 		} else {
@@ -88,3 +88,3 @@ // reuse an existing bucket key if we’re resuming, otherwise create a new one.
 			if (Array.isArray(id)) {
-				transform = loaderJoin(client, id, domain, {
+				transform = loaderJoin(client, id, null, domain, {
 					source: 'snapshot',
@@ -91,0 +91,0 @@ isSnapshot: true

sql/test/test.js

@@ -22,4 +22,4 @@ require("chai").should();
 			if (!stream.write({
-					test: [++count, ++count, ++count]
-				})) {
+				test: [++count, ++count, ++count]
+			})) {
 				stream.once('drain', done);
@@ -59,3 +59,3 @@ } else {
 							callback(err, result, fields);
-						})
+						});
 					},
@@ -100,2 +100,2 @@ disconnect: m.end
 	});
-});
+});

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

92428

increased by0.03%

Dev dependency count

3

decreased by-25%

Lines of code

3404

increased by0.06%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

Dependency changes

• Updatedleo-sdk@^1.1.1