makeerror - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

lib-cov/makeerror.js

@@ -9,7 +9,10 @@ /* automatically generated by JSCoverage - do not edit */
   _$jscoverage['makeerror.js'][30] = 0;
-  _$jscoverage['makeerror.js'][31] = 0;
   _$jscoverage['makeerror.js'][32] = 0;
   _$jscoverage['makeerror.js'][33] = 0;
+  _$jscoverage['makeerror.js'][34] = 0;
   _$jscoverage['makeerror.js'][35] = 0;
   _$jscoverage['makeerror.js'][36] = 0;
+  _$jscoverage['makeerror.js'][39] = 0;
+  _$jscoverage['makeerror.js'][40] = 0;
+  _$jscoverage['makeerror.js'][42] = 0;
 }
@@ -21,20 +24,26 @@ _$jscoverage['makeerror.js'][1]++;
   _$jscoverage['makeerror.js'][29]++;
+  defaultMessage = defaultMessage || "";
+  _$jscoverage['makeerror.js'][30]++;
+  defaultData = defaultData || {};
+  _$jscoverage['makeerror.js'][32]++;
   var CustomError = (function (message, data) {
-  _$jscoverage['makeerror.js'][30]++;
+  _$jscoverage['makeerror.js'][33]++;
   if (! (this instanceof CustomError)) {
-    _$jscoverage['makeerror.js'][30]++;
+    _$jscoverage['makeerror.js'][33]++;
     return new CustomError(message, data);
   }
-  _$jscoverage['makeerror.js'][31]++;
+  _$jscoverage['makeerror.js'][34]++;
   this.name = name;
-  _$jscoverage['makeerror.js'][32]++;
-  this.message = message || defaultMessage || "";
-  _$jscoverage['makeerror.js'][33]++;
-  this.data = data || defaultData || {};
-});
   _$jscoverage['makeerror.js'][35]++;
-  CustomError.prototype = new Error();
+  this.message = message || defaultMessage;
   _$jscoverage['makeerror.js'][36]++;
+  this.data = data || defaultData;
+});
+  _$jscoverage['makeerror.js'][39]++;
+  CustomError.prototype = defaultData.proto || new Error();
+  _$jscoverage['makeerror.js'][40]++;
+  delete defaultData.proto;
+  _$jscoverage['makeerror.js'][42]++;
   return CustomError;
 }
-_$jscoverage['makeerror.js'].source = ["module.exports = makeError","","/**"," * Makes an Error function with the signature:"," *"," *   function(message, data)"," *"," * You'll typically do something like:"," *"," *   var UnknownFileTypeError = makeError("," *     'UnknownFileTypeError',"," *     'The specified type is not known.'"," *   )"," *   var er = UnknownFileTypeError()"," *"," * `er` will have a prototype chain that ensures:"," *"," *   er instanceof Error"," *   er instanceof UnknownFileTypeError"," *"," * You can also do `var er = new UnknownFileTypeError()` if you really like the"," * `new` keyword."," *"," * @param String  The name of the error."," * @param String  The default message string."," * @param Object  The default data object, merged with per instance data."," */","function makeError(name, defaultMessage, defaultData) {","  var CustomError = function(message, data) {","    if (!(this instanceof CustomError)) return new CustomError(message, data)","    this.name = name","    this.message = message || defaultMessage || ''","    this.data = data || defaultData || {}","  }","  CustomError.prototype = new Error()","  return CustomError","}"];
+_$jscoverage['makeerror.js'].source = ["module.exports = makeError","","/**"," * Makes an Error function with the signature:"," *"," *   function(message, data)"," *"," * You'll typically do something like:"," *"," *   var UnknownFileTypeError = makeError("," *     'UnknownFileTypeError',"," *     'The specified type is not known.'"," *   )"," *   var er = UnknownFileTypeError()"," *"," * `er` will have a prototype chain that ensures:"," *"," *   er instanceof Error"," *   er instanceof UnknownFileTypeError"," *"," * You can also do `var er = new UnknownFileTypeError()` if you really like the"," * `new` keyword."," *"," * @param String  The name of the error."," * @param String  The default message string."," * @param Object  The default data object, merged with per instance data."," */","function makeError(name, defaultMessage, defaultData) {","  defaultMessage = defaultMessage || ''","  defaultData = defaultData || {}","","  var CustomError = function(message, data) {","    if (!(this instanceof CustomError)) return new CustomError(message, data)","    this.name = name","    this.message = message || defaultMessage","    this.data = data || defaultData","  }","","  CustomError.prototype = defaultData.proto || new Error()","  delete defaultData.proto","","  return CustomError","}"];

lib/makeerror.js

@@ -29,10 +29,16 @@ module.exports = makeError
 function makeError(name, defaultMessage, defaultData) {
+  defaultMessage = defaultMessage || ''
+  defaultData = defaultData || {}
+
   var CustomError = function(message, data) {
     if (!(this instanceof CustomError)) return new CustomError(message, data)
     this.name = name
-    this.message = message || defaultMessage || ''
-    this.data = data || defaultData || {}
+    this.message = message || defaultMessage
+    this.data = data || defaultData
   }
-  CustomError.prototype = new Error()
+
+  CustomError.prototype = defaultData.proto || new Error()
+  delete defaultData.proto
+
   return CustomError
 }

package.json

 {
   "name": "makeerror",
   "description": "A library to make errors.",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "author": "Naitik Shah <[e-mail]>",
@@ -6,0 +6,0 @@ "main": "lib/makeerror",

readme.md

 makeerror
 =========
 
-A library to make errors. Makes an Error constructor function with the signature:
+A library to make errors. Makes an Error constructor function with the
+signature:
 
-  function(message, data)
+```javascript
+function(message, data)
+```
 
 You'll typically do something like:
 
-  var makeError = require('makeerror')
-  var UnknownFileTypeError = makeError(
-    'UnknownFileTypeError',
-    'The specified type is not known.'
-  )
-  var er = UnknownFileTypeError()
+```javascript
+var makeError = require('makeerror')
+var UnknownFileTypeError = makeError(
+  'UnknownFileTypeError',
+  'The specified type is not known.'
+)
+var er = UnknownFileTypeError()
+```
 
 `er` will have a prototype chain that ensures:
 
-  er instanceof Error
-  er instanceof UnknownFileTypeError
+```javascript
+er instanceof Error
+er instanceof UnknownFileTypeError
+```
 
 You can also do `var er = new UnknownFileTypeError()` if you really like the
 `new` keyword.

No alert changes

Improved metrics

Total package byte prevSize

5258

increased by13.39%

Lines of code

90

increased by16.88%

Number of lines in readme file

31

increased by29.17%

No dependency changes