monaca-lib - npm Package Compare versions

Comparing version 3.0.0-beta.2 to 3.0.0-beta.3

package.json

 {
   "name": "monaca-lib",
-  "version": "3.0.0-beta.2",
+  "version": "3.0.0-beta.3",
   "description": "Monaca cloud and localkit API bindings for JavaScript",
@@ -29,3 +29,4 @@ "main": "./src/main.js",
     "jasmine": "^3.1.0",
-    "jasmine-node": "^1.14.5"
+    "jasmine-node": "^1.14.5",
+    "validate-npm-package-name": "^3.0.0"
   },
@@ -32,0 +33,0 @@ "dependencies": {

src/migration.js

@@ -7,2 +7,6 @@ const path = require('path');
 const packageBackupJsonFile = 'package.backup.json';
+const oldMonacaPlugin = 'mobi.monaca.plugins.Monaca';
+const newMonacaPlugin = 'monaca-plugin-monaca-core';
+const oldBackendMonacaPlugin = 'mobi.monaca.plugins.MonacaBackend';
+const newBackendMonacaPlugin = 'monaca-plugin-backend';
 
@@ -47,4 +51,48 @@ /**
 
-  createPackageJsonBackup(projectDir, packageJsonContent);
+  // change invalid name, if any
+  if (packageJsonContent.name) {
+    try {
+      const nameValidate = require('validate-npm-package-name');
+      const result = nameValidate(packageJsonContent.name);
+      if (!result || (!result.validForNewPackages && !result.validForOldPackages) || result.errors) {
+        const defaultPackageJsonName = getPackageJsonName();
+        utils.info('[package.json] invalid name:');
+        utils.info(result.errors);
+        utils.info(`[package.json] change name to ${defaultPackageJsonName}`);
+        packageJsonContent.name = defaultPackageJsonName;
+      }
+    } catch (e) {
+      utils.info(`[package.json] change name to ${defaultPackageJsonName}`);
+      packageJsonContent.name = getPackageJsonName();
+    }
+  }
 
+  // convert private monaca plugins
+  if (packageJsonContent.dependencies) {
+    // dependencies
+    if (packageJsonContent.dependencies[oldMonacaPlugin]) {
+      utils.info(`[package.json] dependencies - replace ${oldMonacaPlugin} with ${newMonacaPlugin}`);
+      packageJsonContent.dependencies[newMonacaPlugin] = packageJsonContent.dependencies[oldMonacaPlugin]
+      delete packageJsonContent.dependencies[oldMonacaPlugin];
+    }
+    if (packageJsonContent.dependencies[oldBackendMonacaPlugin]) {
+      utils.info(`[package.json] dependencies - replace ${oldBackendMonacaPlugin} with ${newBackendMonacaPlugin}`);
+      packageJsonContent.dependencies[newBackendMonacaPlugin] = packageJsonContent.dependencies[oldBackendMonacaPlugin]
+      delete packageJsonContent.dependencies[oldBackendMonacaPlugin];
+    }
+  }
+  if (packageJsonContent.cordova && packageJsonContent.cordova.plugins) {
+    // plugins
+    if (packageJsonContent.cordova.plugins[oldMonacaPlugin]) {
+      utils.info(`[package.json] plugins - replace ${oldMonacaPlugin} with ${newMonacaPlugin}`);
+      packageJsonContent.cordova.plugins[newMonacaPlugin] = packageJsonContent.cordova.plugins[oldMonacaPlugin]
+      delete packageJsonContent.cordova.plugins[oldMonacaPlugin];
+    }
+    if (packageJsonContent.cordova.plugins[oldBackendMonacaPlugin]) {
+      utils.info(`[package.json] plugins - replace ${oldBackendMonacaPlugin} with ${newBackendMonacaPlugin}`);
+      packageJsonContent.cordova.plugins[newBackendMonacaPlugin] = packageJsonContent.cordova.plugins[oldBackendMonacaPlugin]
+      delete packageJsonContent.cordova.plugins[oldBackendMonacaPlugin];
+    }
+  }
+
   // Check scripts tag
@@ -85,3 +133,12 @@ if (packageJsonContent.scripts) {
 /**
+ * Function to return default package.json's name
+ * @return {String}
  *
+*/
+const getPackageJsonName = () => {
+  return 'monaca-project';
+}
+
+/**
+ *
  * Function to create a backup from package.json
@@ -198,3 +255,3 @@ *
     const packageContent = {
-      "name": projectDir.substring(projectDir.lastIndexOf('/') + 1),
+      "name": "monaca-project",
       "description": "Monaca project",
@@ -201,0 +258,0 @@ };

No alert changes

Improved metrics

Total package byte prevSize

32029260

increased by0.01%

Lines of code

191235

increased by0.03%

Worsened metrics

Dev dependency count

3

increased by50%

No dependency changes