mongodb-core - npm Package Compare versions

Comparing version 2.1.16 to 2.1.17

HISTORY.md

@@ -0,1 +1,5 @@
+2.1.17 2017-10-11
+-----------------
+* fix a typo that completely broke SCRAM-SHA1 authentication
+
 2.1.16 2017-10-11
@@ -6,4 +10,4 @@ -----------------
 * NODE-990 cache the ScramSHA1 salted passwords up to 200 entries
-* NODE-1158 ensure that errors are propagated on force destroy
-* NODE-1158 ensure inUse and connecting queues are cleared on reauth
+* NODE-1153 ensure that errors are propagated on force destroy
+* NODE-1153 ensure inUse and connecting queues are cleared on reauth
 
@@ -10,0 +14,0 @@ 2.1.15 2017-08-08

lib/auth/scram.js

@@ -77,9 +77,15 @@ "use strict";
 
-var _hiCache = {}, _hiCacheCount = 0;
-var _hiCachePurge = function() { _hiCache = {}; _hiCacheCount = 0; }
+var _hiCache = {};
+var _hiCacheCount = 0;
+var _hiCachePurge = function() {
+  _hiCache = {};
+  _hiCacheCount = 0;
+};
 
 var hi = function(data, salt, iterations) {
   // omit the work if already generated
-  var key = data + '_' + salt.toString('base64') + '_' + iterations;
-  if (_hiCache[key] !== undefined) return _hiCache[key];
+  var key = [data, salt.toString('base64'), iterations].join('_');
+  if (_hiCache[key] !== undefined) {
+    return _hiCache[key];
+  }
 
@@ -90,8 +96,10 @@ // generate the salt
   // cache a copy to speed up the next lookup, but prevent unbounded cache growth
-  if (_hiCacheCount >= 200) _hiCachePurge();
-  _hiCache[key] = data;
+  if (_hiCacheCount >= 200) {
+    _hiCachePurge();
+  }
+
+  _hiCache[key] = saltedData;
   _hiCacheCount += 1;
-
   return saltedData;
-}
+};
 
@@ -234,3 +242,3 @@ /**
       var clientFinal = [withoutProof, clientProof].join(',');
-      
+
       //
@@ -237,0 +245,0 @@ // Create continue message

package.json

 {
   "name": "mongodb-core",
-  "version": "2.1.16",
+  "version": "2.1.17",
   "description": "Core MongoDB driver functionality, no bells and whistles and meant for integration not end applications",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Improved metrics

Total package byte prevSize

534856

increased by19.69%

Number of package files

41

increased by2.5%

Lines of code

10551

increased by0.08%

No dependency changes