mouse-pressed - npm Package Compare versions

Comparing version 0.0.1 to 1.0.0

index.js

 var Emitter = require('events/')
 var map = [
-    'left'
-  , 'middle'
-  , 'right'
+  'left',
+  'middle',
+  'right'
 ]
@@ -10,4 +10,4 @@
 
-function pressed(element, preventDefault) {
-  var mouse = new Emitter
+function pressed (element, preventDefault) {
+  var mouse = new Emitter()
 
@@ -17,2 +17,3 @@ mouse.left = false
   mouse.middle = false
+  mouse.dispose = dispose
 
@@ -22,8 +23,6 @@ if (typeof window !== 'undefined') {
     element.addEventListener('mousedown', mousedown, false)
-    element.addEventListener('mouseup', mouseup, false)
+    window.addEventListener('mouseup', mouseup, false)
 
     if (preventDefault) {
-      element.addEventListener('contextmenu', function(e) {
-        return e.preventDefault && e.preventDefault() && false
-      }, false)
+      element.addEventListener('contextmenu', preventDefaulter, false)
     }
@@ -34,3 +33,3 @@ }
 
-  function mousedown(e) {
+  function mousedown (e) {
     mouse.right = false
@@ -46,3 +45,3 @@ mouse[map[e.button]] = true
 
-  function mouseup(e) {
+  function mouseup (e) {
     mouse.right = false
@@ -57,2 +56,18 @@ mouse[map[e.button]] = false
   }
+
+  function preventDefaulter (e) {
+    return e.preventDefault && e.preventDefault() && false
+  }
+
+  function dispose () {
+    mouse.left = false
+    mouse.right = false
+    mouse.middle = false
+
+    if (element) {
+      element.removeEventListener('contextmenu', preventDefaulter, false)
+      element.removeEventListener('mousedown', mousedown, false)
+      window.removeEventListener('mouseup', mouseup, false)
+    }
+  }
 }

package.json

 {
   "name": "mouse-pressed",
-  "version": "0.0.1",
+  "version": "1.0.0",
   "description": "Simple module to detect if a mouse button is pressed or not.",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -36,4 +36,8 @@ # mouse-pressed [![experimental](http://badges.github.io/stability-badges/dist/experimental.svg)](http://github.com/badges/stability-badges)
 
+### pressed.dispose()
+
+To be called when this instance is no longer required: removes all of the attached event listeners.
+
 ## License
 
 MIT. See [LICENSE.md](http://github.com/hughsk/mouse-pressed/blob/master/LICENSE.md) for details.

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4963

increased by11.35%

Lines of code

66

increased by22.22%

Number of low quality alerts

1

decreased by-50%

Number of lines in readme file

43

increased by10.26%

No dependency changes