mysql-simple-query - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

lib/mysqlSimpleQuery.js

@@ -1,2 +0,1 @@
-const db = require('mysql-promise')();
 const dbQuery = require('./util/dbQuery');
@@ -6,5 +5,3 @@ const { isEmpty } = require('./util/common');
 class mysqlSimpleQuery {
-    constructor(creds) {
-        this.creds = creds;
-
+    constructor() {
         this.selectStatement = '';
@@ -70,7 +67,7 @@ this.joinStatement = {};
     queryRaw(query) {
-        return this._queryMysql(query);
+        return query.trim();
     }
 
     // Handles all querying
-    query(rawQuery = false) {
+    query() {
         let queryStatement = '';
@@ -106,10 +103,6 @@
 
-        if (rawQuery) {
-            return queryStatement.trim();
-        }
-
-        return this._queryMysql(queryStatement.trim());
+        return queryStatement.trim();
     }
 
-    insert(table, data, rawQuery = false) {
+    insert(table, data) {
         const last = Object.keys(data)[Object.keys(data).length - 1];
@@ -141,10 +134,6 @@ let query = `INSERT INTO ${table} `;
 
-        if (rawQuery) {
-            return query;
-        }
-
-        return this._queryMysql(query);
+        return query.trim();
     }
 
-    update(table, data, rawQuery = false) {
+    update(table, data) {
         let query = '';
@@ -158,10 +147,6 @@
 
-        if (rawQuery) {
-            return query;
-        }
-
-        return this._queryMysql(query);
+        return query.trim();
     }
 
-    delete(table, rawQuery = false) {
+    delete(table) {
         let query = '';
@@ -175,23 +160,6 @@
 
-        if (rawQuery) {
-            return query;
-        }
-
-        return this._queryMysql(query);
+        return query.trim();
     }
-
-    _queryMysql(query) {
-        db.configure({
-            host: process.env.MYSQL_SQ_HOST || this.creds.host,
-            database: process.env.MYSQL_SQ_DATABASE || this.creds.database,
-            user: process.env.MYSQL_SQ_USER || this.creds.user,
-            password: process.env.MYSQL_SQ_PASSWORD || this.creds.password
-        });
-
-        return db.query(query.trim()).spread(function (data) {
-            return data;
-        });
-    }
 }
 
 module.exports = mysqlSimpleQuery;

package.json

 {
   "name": "mysql-simple-query",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Simple query wrapper for mysql-promise to make querying, inserting, updating, and deleting easier for developers.",
@@ -33,4 +33,3 @@ "main": "mysqlSimpleQuery.js",
   "dependencies": {
-    "mysql-promise": "^5.0.0"
   }
 }

README.md

@@ -6,3 +6,3 @@ MySQL Simple Query
 
-Simple query wrapper for mysql-promise to make querying, inserting, updating, and deleting easier for developers.
+Simple mysql query builder to make querying, inserting, updating, and deleting easier for developers. This library can be used with any mysql library. 
 
@@ -31,3 +31,2 @@ * * *
 All calls need to be have a reference to the mysql-simple-query class.
-Passing credentials to mysql-promise can be done in two ways:
 
@@ -37,19 +36,2 @@ ```js
 
-const db = new mysqlQuery({
-    host: 'someHost',
-    database: 'someDatabase',
-    user: 'someUser',
-    password: 'somePassword'
-});
-```
-
-OR it can be configured using the following environment variables placed on your server or system.
-```js
-MYSQL_SQ_HOST="someHost"
-MYSQL_SQ_DATABASE="someDatabse"
-MYSQL_SQ_USER="someUser"
-MYSQL_SQ_PASSWORD="somePassword"
-
-const mysqlQuery = require("mysql-simple-query");
-
 const db = new mysqlQuery();
@@ -56,0 +38,0 @@

src/mysqlSimpleQuery.js

@@ -1,2 +0,1 @@
-const db = require('mysql-promise')();
 const dbQuery = require('./util/dbQuery');
@@ -6,6 +5,4 @@ const { isEmpty } = require('./util/common');
 class mysqlSimpleQuery {
-    constructor(creds)
+    constructor()
     {
-        this.creds = creds;
-
         this.selectStatement = '';
@@ -73,7 +70,7 @@ this.joinStatement = {};
     queryRaw(query) {
-        return this._queryMysql(query);
+        return query.trim();
     }
 
     // Handles all querying
-    query(rawQuery = false) {
+    query() {
         let queryStatement = '';
@@ -109,11 +106,6 @@
 
-        if(rawQuery)
-        {
-            return queryStatement.trim();
-        }
-
-        return this._queryMysql(queryStatement.trim());
+        return queryStatement.trim();
     }
 
-    insert(table, data, rawQuery = false) {
+    insert(table, data) {
         const last = Object.keys(data)[Object.keys(data).length-1];
@@ -147,11 +139,6 @@ let query = `INSERT INTO ${table} `;
 
-        if(rawQuery)
-        {
-            return query;
-        }
-
-        return this._queryMysql(query);
+        return query.trim();
     }
 
-    update(table, data, rawQuery = false) {
+    update(table, data) {
         let query = '';
@@ -165,11 +152,6 @@
 
-        if(rawQuery)
-        {
-            return query;
-        }
-
-        return this._queryMysql(query);
+        return query.trim();
     }
 
-    delete(table, rawQuery = false)
+    delete(table)
     {
@@ -184,24 +166,6 @@ let query = '';
 
-        if(rawQuery)
-        {
-            return query;
-        }
-
-        return this._queryMysql(query);
+        return query.trim();
     }
-
-    _queryMysql(query) {
-        db.configure({
-            host: process.env.MYSQL_SQ_HOST || this.creds.host,
-            database: process.env.MYSQL_SQ_DATABASE || this.creds.database,
-            user: process.env.MYSQL_SQ_USER || this.creds.user,
-            password: process.env.MYSQL_SQ_PASSWORD || this.creds.password,
-        });
-
-        return db.query(query.trim()).spread(function (data) {
-            return data;
-        });
-    }
 }
 
 module.exports = mysqlSimpleQuery;

test/mysqlSimpleQueryTest.js

@@ -62,4 +62,5 @@ const expect = require('chai').expect;
         const results = test.delete('product_option_set', true);
+        console.log(results);
         expect(results).to.equal('DELETE FROM product_option_set WHERE product_id="2222"');
     });
 });

Fixed alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 4 instances in 1 package

Improved metrics

Dependency count

0

decreased by-100%

Number of low supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

21694

decreased by-9.54%

Lines of code

536

decreased by-9%

Number of lines in readme file

230

decreased by-7.26%

Dependency changes

• - Removedmysql-promise@^5.0.0

• - Removedbignumber.js@9.0.0(transitive)

• - Removedbluebird@3.7.2(transitive)

• - Removedcore-util-is@1.0.3(transitive)

• - Removedinherits@2.0.4(transitive)

• - Removedisarray@1.0.0(transitive)

• - Removedmysql@2.18.1(transitive)

• - Removedmysql-promise@5.0.0(transitive)

• - Removedprocess-nextick-args@2.0.1(transitive)

• - Removedreadable-stream@2.3.7(transitive)

• - Removedsafe-buffer@5.1.2(transitive)

• - Removedsqlstring@2.3.1(transitive)

• - Removedstring_decoder@1.1.1(transitive)

• - Removedutil-deprecate@1.0.2(transitive)