node-notifier - npm Package Compare versions

Comparing version 8.0.0 to 9.0.0

CHANGELOG.md

 # Changelog
 
+### `v9.0.0`
+
+Breaking changes:
+
+- Corrects mapping on snoretoast activate event. See [#347](https://github.com/mikaelbr/node-notifier/pull/347).
+
+#### Patches
+
+- Fix named pipe in WSL. See [#342](https://github.com/mikaelbr/node-notifier/pull/342).
+- fixes possible injection issue for notify-send
+
 ### `v8.0.0`
@@ -4,0 +15,0 @@

lib/utils.js

@@ -316,3 +316,5 @@ var shellwords = require('shellwords');
   initial.forEach(function (val) {
-    args.push(escapeFn(val));
+    if (typeof val === 'string') {
+      args.push(escapeFn(val));
+    }
   });
@@ -319,0 +321,0 @@ for (var key in options) {

notifiers/toaster.js

@@ -18,2 +18,3 @@ /**
 const PIPE_PATH_PREFIX = '\\\\.\\pipe\\';
+const PIPE_PATH_PREFIX_WSL = '/tmp/';
 
@@ -50,3 +51,4 @@ module.exports = WindowsToaster;
 function getPipeName() {
-  return `${PIPE_PATH_PREFIX}${PIPE_NAME}-${uuid()}`;
+  var pathPrefix = utils.isWSL() ? PIPE_PATH_PREFIX_WSL : PIPE_PATH_PREFIX;
+  return `${pathPrefix}${PIPE_NAME}-${uuid()}`;
 }
@@ -112,7 +114,4 @@
       err,
-      utils.actionJackerDecorator(
-        this,
-        options,
-        callback,
-        (data) => data || false
+      utils.actionJackerDecorator(this, options, callback, (data) =>
+        data === 'activate' ? 'click' : data || false
       )
@@ -119,0 +118,0 @@ );

package.json

 {
   "name": "node-notifier",
-  "version": "8.0.0",
+  "version": "9.0.0",
   "description": "A Node.js module for sending notifications on native Mac, Windows (post and pre 8) and Linux (or Growl as fallback)",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -73,4 +73,5 @@ # node-notifier [![NPM version][npm-image]][npm-url] [![Build Status][travis-image]][travis-url]
   },
-  function (err, response) {
+  function (err, response, metadata) {
     // Response is response from notification
+    // Metadata contains activationType, activationAt, deliveredAt
   }
@@ -359,3 +360,3 @@ );
 
-  wait: false, // Defaults no exipre time set. If true expire time of 5 seconds is used
+  wait: false, // Defaults no expire time set. If true expire time of 5 seconds is used
   timeout: 10, // Alias for expire-time, time etc. Time before notify-send expires. Defaults to 10 seconds.
@@ -392,2 +393,7 @@
 
+### Windows and WSL2
+
+If you don't see notifications within WSL2, you might have to change premission of exe vendor files (snoreToast).
+[See issue for more info](https://github.com/mikaelbr/node-notifier/issues/353)
+
 ### Use inside tmux session
@@ -394,0 +400,0 @@

No alert changes

Improved metrics

Total package byte prevSize

5688371

increased by0.01%

Lines of code

1057

increased by0.09%

Number of lines in readme file

468

increased by1.3%

No dependency changes