node-red-contrib-spark - npm Package Compare versions

Comparing version 2.0.4 to 2.0.5

CHANGELOG.md

@@ -0,1 +1,8 @@
+#### 2.0.5: Maintenance Release
+
+  - Fixed issues with existing API Nodes not loading node form parameters on page refresh.
+  - Attempt to fix why nodes are not showing on palette when viewing on nodered.org.
+  - Changed references from httpAdmin to httpNode.
+  - Fixed issue with webhook node nott showing form elements once a profile is created when webhook node is first node to be initialized.
+
 #### 2.0.4: Maintenance Release
@@ -2,0 +9,0 @@

package.json

 {
   "name": "node-red-contrib-spark",
-  "version": "2.0.4",
+  "version": "2.0.5",
   "description": "Node-RED Nodes to integrate with the Cisco Spark API",
@@ -5,0 +5,0 @@ "dependencies": {

spark/spark-api.js

@@ -410,25 +410,29 @@ module.exports = function(RED) {
 
-  RED.nodes.registerType('Spark API', SparkApiNode);
+  if(RED.settings.httpNodeRoot !== false) {
+    RED.httpNode.get('/swagger-client-web.js', function(req, res) {
+      var clientPath = path.resolve(__dirname, './swagger-client-web.js');
+      fs.readFile(clientPath, function(err, data) {
+        if(err) {
+          res.set('Content-Type', 'text/javascript').send('{ "error": "' + err.message + '", "message": "Error reading swagger-client-web.js" }');
+        } else {
+          res.set('Content-Type', 'text/javascript').send(data);
+        }
+      });
+    });
 
-  RED.httpAdmin.get('/swagger-client-web.js', function(req, res) {
-    var clientPath = path.resolve(__dirname, './swagger-client-web.js');
-    fs.readFile(clientPath, function(err, data) {
-      if(err) {
-        res.set('Content-Type', 'text/javascript').send('{ "error": "' + err.message + '", "message": "Error reading swagger-client-web.js" }');
-      } else {
-        res.set('Content-Type', 'text/javascript').send(data);
-      }
+    RED.httpNode.get('/api/cisco_spark_v1.json', function(req, res) {
+      var apiPath = path.resolve(__dirname, './api/cisco_spark_v1.json');
+      fs.readFile(apiPath, function(err, data) {
+        if(err) {
+          res.set('Content-Type', 'text/javascript').send('{ "error": "' + err.message + '", "message": "Error reading api/cisco_spark_v1.json" }');
+        } else {
+          res.set('Content-Type', 'text/javascript').send(data);
+        }
+      });
     });
-  });
+  } else {
+    this.warn('httpNodeRoot is disabled in node-red settings');
+  }
 
-  RED.httpAdmin.get('/api/cisco_spark_v1.json', function(req, res) {
-    var apiPath = path.resolve(__dirname, './api/cisco_spark_v1.json');
-    fs.readFile(apiPath, function(err, data) {
-      if(err) {
-        res.set('Content-Type', 'text/javascript').send('{ "error": "' + err.message + '", "message": "Error reading api/cisco_spark_v1.json" }');
-      } else {
-        res.set('Content-Type', 'text/javascript').send(data);
-      }
-    });
-  });
+  RED.nodes.registerType('Spark API', SparkApiNode);
 };

spark/spark-webhook.js

@@ -302,14 +302,19 @@ module.exports = function(RED) {
 
+  if(RED.settings.httpNodeRoot !== false) {
+    RED.httpNode.get('/webhook/cisco_spark_v1.json', function(req, res) {
+      var swaggerPath = path.resolve(__dirname, './webhook/cisco_spark_v1.json');
+      fs.readFile(swaggerPath, function(err, data) {
+        if(err) {
+          res.set('Content-Type', 'text/javascript').send('{ "error": "' + err.message + '", "message": "Error reading webhook/cisco_spark_v1.json" }');
+        } else {
+          res.set('Content-Type', 'text/javascript').send(data);
+        }
+      });
+    });
+
+  } else {
+    this.warn('httpNodeRoot is disabled in node-red settings');
+  }
+
   RED.nodes.registerType('Spark Webhook', SparkWebhookNode);
-
-  RED.httpAdmin.get('/webhook/cisco_spark_v1.json', function(req, res) {
-    var swaggerPath = path.resolve(__dirname, './webhook/cisco_spark_v1.json');
-    fs.readFile(swaggerPath, function(err, data) {
-      if(err) {
-        res.set('Content-Type', 'text/javascript').send('{ "error": "' + err.message + '", "message": "Error reading webhook/cisco_spark_v1.json" }');
-      } else {
-        res.set('Content-Type', 'text/javascript').send(data);
-      }
-    });
-  });
 };

No alert changes

Improved metrics

Total package byte prevSize

1099886

increased by0.15%

Lines of code

18570

increased by0.04%

No dependency changes