node-red-node-random - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

package.json

 {
     "name"          : "node-red-node-random",
-    "version"       : "0.4.0",
+    "version"       : "0.4.1",
     "description"   : "A Node-RED node that when triggered generates a random number between two values.",
@@ -9,3 +9,4 @@ "dependencies"  : {
         "type":"git",
-        "url":"https://github.com/node-red/node-red-nodes/tree/master/function/random"
+        "url":"https://github.com/node-red/node-red-nodes.git",
+        "directory": "tree/master/function/random"
     },
@@ -12,0 +13,0 @@ "license": "Apache-2.0",

random.js

@@ -21,5 +21,4 @@
             } else if ('from' in msg) { // else see if a 'from' is in the msg
-                if (Number(msg.from)) { // if it is, and is a number, use it
-                    tmp.low = Number(msg.from);
-                } else {                // otherwise setup NaN error
+                tmp.low = Number(msg.from);
+                if (isNaN(msg.from)) { // if it isn't a number setup NaN error
                     tmp.low = NaN;
@@ -35,5 +34,4 @@ tmp.low_e = " From: " + msg.from; // setup to show bad incoming msg.from
             } else if ('to' in msg) {   // else see if a 'to' is in the msg
-                if (Number(msg.to)) {   // if it is, and is a number, use it
-                    tmp.high = Number(msg.to);
-                } else {                // otherwise setup NaN error
+                tmp.high = Number(msg.to);
+                if (isNaN(msg.to)) {   // if it isn't a number setup NaN error
                     tmp.high = NaN
@@ -40,0 +38,0 @@ tmp.high_e = " To: " + msg.to // setup to show bad incoming msg.to

No alert changes

Worsened metrics

Total package byte prevSize

10890

decreased by-1.04%

Lines of code

104

decreased by-1.89%

No dependency changes