object.entries - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

CHANGELOG.md

@@ -0,1 +1,5 @@
+1.0.2 / 2015-09-25
+=================
+  * [Fix] Not-yet-visited keys deleted on a `[[Get]]` must not show up in the output (#1)
+
 1.0.1 / 2015-09-21
@@ -2,0 +6,0 @@ =================

implementation.js

@@ -5,2 +5,3 @@ 'use strict';
 var keys = require('object-keys');
+var has = require('has');
 
@@ -12,5 +13,7 @@ module.exports = function entries(O) {
 	for (var i = 0; i < objKeys.length; ++i) {
-		entrys.push([objKeys[i], obj[objKeys[i]]]);
+		if (has(obj, objKeys[i])) {
+			entrys.push([objKeys[i], obj[objKeys[i]]]);
+		}
 	}
 	return entrys;
 };

package.json

 {
 	"name": "object.entries",
-	"version": "1.0.1",
+	"version": "1.0.2",
 	"author": "Jordan Harband",
@@ -39,2 +39,3 @@ "description": "ES7 spec-compliant Object.entries shim.",
 		"es-abstract": "^1.3.1",
+		"has": "^1.0.1",
 		"object-keys": "^1.0.7"
@@ -41,0 +42,0 @@ },

test/tests.js

@@ -5,2 +5,3 @@ 'use strict';
 var map = require('array-map');
+var define = require('define-properties');
 
@@ -58,2 +59,14 @@ var hasSymbols = typeof Symbol === 'function' && typeof Symbol() === 'symbol';
 	});
+
+	t.test('not-yet-visited keys deleted on [[Get]] must not show up in output', { skip: !define.supportsDescriptors }, function (st) {
+		var o = { a: 1, b: 2, c: 3 };
+		Object.defineProperty(o, 'a', {
+			get: function () {
+				delete this.b;
+				return 1;
+			}
+		});
+		st.deepEqual(entries(o), [['a', 1], ['c', 3]], 'when "b" is deleted prior to being visited, it should not show up');
+		st.end();
+	});
 };

No alert changes

Improved metrics

Total package byte prevSize

15175

increased by4.71%

Lines of code

216

increased by7.46%

Worsened metrics

Dependency count

4

increased by33.33%

Dependency changes

• + Addedhas@^1.0.1

• + Addedhas@1.0.4(transitive)