paypal-checkout-components - npm Package Compare versions

Comparing version 4.1.28 to 4.1.29

package.json

 {
   "name": "paypal-checkout-components",
-  "version": "4.1.28",
+  "version": "4.1.29",
   "description": "PayPal Checkout components, for integrating checkout products.",
@@ -5,0 +5,0 @@ "main": "index.js",

src/buttons/component.jsx

@@ -6,3 +6,3 @@ /* @flow */
 import { getLogger, getLocale, getClientID, getEnv, getIntent, getCommit,
-    getVault, getPayPalDomain, getCurrency, getSDKMeta, isEligible, getBrowser,
+    getVault, getPayPalDomainRegex, getCurrency, getSDKMeta, isEligible, getBrowser,
     createOrder, type OrderCreateRequest, type OrderGetResponse, type OrderCaptureResponse, type OrderAuthorizeResponse } from 'paypal-braintree-web-client/src';
@@ -64,3 +64,3 @@ import { ZalgoPromise } from 'zalgo-promise/src';
     url:    getButtonUrl(),
-    domain: getPayPalDomain(),
+    domain: getPayPalDomainRegex(),
 
@@ -71,4 +71,3 @@ contexts: {
     },
-
-    scrolling:       false,
+    
     listenForResize: true,
@@ -93,3 +92,4 @@
         iframe: {
-            allowpaymentrequest: 'allowpaymentrequest'
+            allowpaymentrequest: 'allowpaymentrequest',
+            scrolling:           'no'
         }
@@ -96,0 +96,0 @@ },

src/buttons/template/containerTemplate.jsx

@@ -68,2 +68,6 @@ /* @flow */
 
+    if (!container) {
+        throw new Error(`Expected container`);
+    }
+
     const getContainerDimensions = () => {
@@ -70,0 +74,0 @@ let cont = container;

src/checkout/component.js

 /* @flow */
 /* eslint max-lines: 0 */
 
-import { getPayPalDomain, getLogger, getLocale, getEnv, getClientID, getCommit, getSDKMeta, isEligible } from 'paypal-braintree-web-client/src';
+import { getPayPalDomainRegex, getLogger, getLocale, getEnv, getClientID, getCommit, getSDKMeta, isEligible } from 'paypal-braintree-web-client/src';
 import { ZalgoPromise } from 'zalgo-promise/src';
@@ -22,5 +22,9 @@ import { create, CONSTANTS, PopupOpenError } from 'zoid/src';
 
-    scrolling: true,
+    attributes: {
+        iframe: {
+            scrolling: 'yes'
+        }
+    },
 
-    buildUrl(props) : string {
+    url(props) : string {
         const { fundingSource } = props;
@@ -40,3 +44,3 @@ const fundingConfig = FUNDING_CONFIG[fundingSource];
 
-    domain: getPayPalDomain(),
+    domain: getPayPalDomainRegex(),
 
@@ -43,0 +47,0 @@ contexts: {

src/config/config.js

 /* @flow */
 
-import { buildPayPalUrl } from 'paypal-braintree-web-client/src';
+import { getPayPalDomain } from 'paypal-braintree-web-client/src';
 
@@ -33,23 +33,23 @@ export const SESSION_LIFETIME = 5 * 60 * 1000;
 export function getPayPalUrl() : string {
-    return buildPayPalUrl();
+    return getPayPalDomain();
 }
 
 export function getCheckoutUrl() : string {
-    return buildPayPalUrl(URI.CHECKOUT);
+    return `${ getPayPalDomain() }${ URI.CHECKOUT }`;
 }
 
 export function getButtonUrl() : string {
-    return buildPayPalUrl(URI.BUTTON);
+    return `${ getPayPalDomain() }${ URI.BUTTON }`;
 }
 
 export function getGuestUrl() : string {
-    return buildPayPalUrl(URI.GUEST);
+    return `${ getPayPalDomain() }${ URI.GUEST }`;
 }
 
 export function getCardUrl() : string {
-    return buildPayPalUrl(URI.CARD);
+    return `${ getPayPalDomain() }${ URI.CARD }`;
 }
 
 export function getAltPayUrl() : string {
-    return buildPayPalUrl(URI.ALTPAY);
+    return `${ getPayPalDomain() }${ URI.ALTPAY }`;
 }

No alert changes

Improved metrics

Total package byte prevSize

417710

increased by0.04%

Worsened metrics

Lines of code

3713

decreased by-15.71%

No dependency changes