pdi - npm Package Compare versions

Comparing version 1.1.1 to 1.2.0

package.json

 {
   "name": "pdi",
-  "version": "1.1.1",
+  "version": "1.2.0",
   "description": "Minimal Promise based dependency injection framework",
@@ -8,3 +8,4 @@ "main": "src/index.js",
     "test": "mocha",
-    "test:watch": "mocha -w"
+    "test:watch": "mocha -w",
+    "lint": "eslint src/"
   },
@@ -14,14 +15,12 @@ "author": "",
   "dependencies": {
-    "bluebird": "^3.4.1",
-    "debug": "^3.0.0",
-    "ramda": "^0.21.0"
+    "bluebird": "^3.5.1",
+    "debug": "^3.1.0",
+    "ramda": "^0.25.0"
   },
   "devDependencies": {
-    "@mft/eslint-config-momentumft": "^0.2.2",
-    "babel-eslint": "^6.1.2",
-    "eslint": "^3.2.2",
-    "eslint-plugin-babel": "^3.3.0",
-    "mocha": "^3.0.1",
-    "sinon": "^1.17.5"
+    "@mft/eslint-config-momentumft": "^3.1.5",
+    "eslint": "^4.18.1",
+    "mocha": "^5.0.1",
+    "sinon": "^4.4.2"
   }
 }

src/index.js

@@ -38,5 +38,5 @@ const Promise = require("bluebird")
 
-const mapper = curry((hash, { name, deps, fn }) => {
+const mapper = curry((hash, {name, deps, fn}) => {
   const result = reduce(reducer(hash, name), [], deps)
-  return { result, deps, name, fn }
+  return {result, deps, name, fn}
 })
@@ -57,3 +57,3 @@
     const sorted = compose(pluck("name"), flatten)(output)
-    const ready = filter(({ result }) => {
+    const ready = filter(({result}) => {
       return difference(result, sorted).length === 0
@@ -83,2 +83,5 @@ }, input)
 
+const addToRegistry = (registry, name, deps, fn) =>
+  (registry[name] = {fn, deps, name})
+
 function createInstance() {
@@ -99,17 +102,15 @@ let registry = {}
     if (is(Array, name) && is(Function, deps)) {
-      fn = deps
-      deps = name
-      name = "__pdi_side_effect_" + nameIdx++
+      nameIdx += 1
+      return addToRegistry(registry, "__pdi_side_effect_" + nameIdx, name, deps)
     }
-    if (!fn) {
-      fn = deps
-      deps = []
-    }
     if (registry[name]) {
       throw new Error(`Attempted to register module: ${name} multiple times`)
     }
+    if (!fn) {
+      return addToRegistry(registry, name, [], deps)
+    }
     if (!is(Function, fn)) {
-      fn = always(fn)
+      return addToRegistry(registry, name, deps, always(fn))
     }
-    registry[name] = { fn, deps, name }
+    return addToRegistry(registry, name, deps, fn)
   }
@@ -154,3 +155,3 @@ function start(deps, fn) {
 
-  return { add, start, clear, __test }
+  return {add, start, clear, __test}
 }
@@ -157,0 +158,0 @@

No alert changes

Improved metrics

Total package byte prevSize

48403

increased by0.25%

Dev dependency count

4

decreased by-33.33%

Worsened metrics

Number of package files

8

decreased by-11.11%

Dependency changes

• + Addedramda@0.25.0(transitive)

• - Removedramda@0.21.0(transitive)

• Updatedbluebird@^3.5.1

• Updateddebug@^3.1.0

• Updatedramda@^0.25.0