playwright-core - npm Package Compare versions

Comparing version 1.45.0-alpha-2024-05-15 to 1.45.0-alpha-2024-05-16

browsers.json

@@ -30,3 +30,3 @@ {
       "name": "webkit",
-      "revision": "2007",
+      "revision": "2009",
       "installByDefault": true,
@@ -33,0 +33,0 @@ "revisionOverrides": {

lib/server/electron/electron.js

@@ -159,3 +159,3 @@ "use strict";
       // --remote-debugging-port=0 must be the last playwright's argument, loader.ts relies on it.
-      const electronArguments = ['--inspect=0', '--remote-debugging-port=0', ...args];
+      let electronArguments = ['--inspect=0', '--remote-debugging-port=0', ...args];
       if (_os.default.platform() === 'linux') {
@@ -186,2 +186,12 @@ const runningAsRoot = process.geteuid && process.geteuid() === 0;
       }
+      let shell = false;
+      if (process.platform === 'win32') {
+        // On Windows in order to run .cmd files, shell: true is required.
+        // https://github.com/nodejs/node/issues/52554
+        shell = true;
+        // On Windows, we need to quote the executable path due to shell: true.
+        command = `"${command}"`;
+        // On Windows, we need to quote the arguments due to shell: true.
+        electronArguments = electronArguments.map(arg => `"${arg}"`);
+      }
 
@@ -204,5 +214,3 @@ // When debugging Playwright test that runs Electron, NODE_OPTIONS
         },
-        // On Windows in order to run .cmd files, shell: true is required.
-        // https://github.com/nodejs/node/issues/52554
-        shell: process.platform === 'win32',
+        shell,
         stdio: 'pipe',
@@ -209,0 +217,0 @@ cwd: options.cwd,

package.json

 {
   "name": "playwright-core",
-  "version": "1.45.0-alpha-2024-05-15",
+  "version": "1.45.0-alpha-2024-05-16",
   "description": "A high-level API to automate web browsers",
@@ -5,0 +5,0 @@ "repository": {

No alert changes

Improved metrics

Total package byte prevSize

7125725

increased by0.02%

Lines of code

100059

increased by0.01%

No dependency changes