pomo - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

History.md

@@ -0,1 +1,11 @@
+## v1.1.1 - September 19, 2013
+
+ * Fix typo in `--help` where it read "secs" instead of "mins"
+ * Fix bug where the Tmux status doesn't clear on exit sometimes
+ * Fix logging error that happens when running break-less pomodoros.
+ * Fix `-b 0` not working in certain circumstances.
+ * The '3, 2, 1' countdown is now not being growled.
+ * Add a shortcut `pomojs 25 10` to run a 25min + 10min timer.
+ * Pomo now doesn't clear the screen on startup.
+
 ## v1.1.0 - June 20, 2013
@@ -10,3 +20,3 @@
 
- * Update log format to show duration (eg, `6:55am - 7:25am`).
+ * Update log format to show duration (eg, `6:55am - 7:25am`)
 
@@ -13,0 +23,0 @@ ## v1.0.6 - June 18, 2013

lib/reporters/landing.js

@@ -18,4 +18,2 @@ var strRepeat = require('../../lib/helpers').strRepeat;
     'start': function() {
-      clear();
-
       var str = format("time for %s (%s)",
@@ -22,0 +20,0 @@ pomo.reason, duration(pomo.work.duration));

lib/reporters/logger.js

@@ -30,3 +30,3 @@ var fs       = require('fs');
       duration    : pomo.work.elapsed(),
-      'break'     : pomo.snack.elapsed(),
+      'break'     : pomo.snack && pomo.snack.elapsed(),
       interrupted : pomo.interrupted
@@ -33,0 +33,0 @@ });

lib/reporters/speaker.js

@@ -15,3 +15,5 @@ var Helpers = require('../../lib/helpers');
     if (!options.quiet) self.speak(words);
-    self.growl(words);
+
+    // Don't growl the '3, 2, 1' part
+    if (typeof words === 'string') self.growl(words);
   };
@@ -18,0 +20,0 @@

lib/reporters/tmux.js

@@ -19,3 +19,7 @@ var fs        = require('fs');
 
-      fs.writeFile(fn, str, function(err) { if (err) throw(err); });
+      // For last few seconds, write synchronously to guarantee sequentiality
+      if (remaining < 5000)
+        fs.writeFileSync(fn, str);
+      else
+        fs.writeFile(fn, str, function(err) { if (err) throw(err); });
     },
@@ -22,0 +26,0 @@

lib/runner.js

@@ -37,3 +37,3 @@ var EventEmitter = require('events').EventEmitter;
   this.work        = new Timer(work, {mode: 'work'});
-  this.snack       = snack ? new Timer(snack, {mode: 'snack'}) : null;
+  this.snack       = snack > 0 ? new Timer(snack, {mode: 'snack'}) : null;
   // Start and end times
@@ -40,0 +40,0 @@ this.start       = null;

package.json

@@ -10,3 +10,3 @@ {
   "author": "Rico Sta. Cruz <[e-mail]>",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "repository": {
@@ -13,0 +13,0 @@ "type": "git",

Readme.md

@@ -88,2 +88,14 @@ # Pomo ![Pomo](http://rstacruz.github.io/pomo.js/tomato-small.png)
 
+#### Shortcut syntax
+
+You can use this syntax to save some keystrokes.
+
+``` sh
+# pomojs <work> <break> <reason>
+pomojs 25 2 Do things
+
+# the same as:
+pomojs --work 25 --break 2 Do things
+```
+
 -----
@@ -90,0 +102,0 @@

test/runner_test.js

@@ -8,2 +8,12 @@ require('./setup');
 describe('Runner', function() {
+  var clock;
+
+  beforeEach(function() {
+    clock = sinon.useFakeTimers();
+  });
+
+  afterEach(function() {
+    clock.restore();
+  });
+
   this.timeout(30*secs);
@@ -17,2 +27,3 @@
       'start': function() {
+        process.stdout.write(':');
         events.push(['start', v(arguments)]);
@@ -22,4 +33,4 @@ },
       'timer': function(mode, perc, elapsed, remaining, words) {
-        process.stdout.write('.');
         events.push(['timer', [ mode, r(perc, 0.1), r(elapsed, 500), r(remaining, 500), words ] ]);
+        process.nextTick(function() { clock.tick(1001); });
       },
@@ -29,5 +40,7 @@
         events.push(['snack', v(arguments)]);
+        process.nextTick(function() { clock.tick(3001); });
       },
 
       'finish': function() {
+        process.stdout.write(':');
         events.push(['finish', v(arguments)]);
@@ -59,3 +72,5 @@
       }
-    }).run();
+    });
+
+    runner.run();
   });
@@ -62,0 +77,0 @@ });

New alerts

Shell access

Supply chain risk

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 3 instances in 1 package

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Fixed alerts

Shell access

Supply chain risk

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 3 instances in 1 package

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

70256

2.11%

Lines of code

1042

1.46%

Number of lines in readme file

121

11.01%

No dependency changes