promise-rat-race - npm Package Compare versions

Comparing version 1.4.0 to 1.5.1

package.json

@@ -1,29 +0,1 @@
-{
-  "name": "promise-rat-race",
-  "version": "1.4.0",
-  "description": "like Promise.race, but doesn't care about the losers in the race",
-  "main": "rat-race.js",
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/Financial-Times/promise-rat-race.git"
-  },
-  "keywords": [
-    "promise",
-    "race"
-  ],
-  "author": [
-    "Rhys Evans <[e-mail]>",
-    "Matt Andrews <[e-mail]>"
-  ],
-  "license": "MIT",
-  "bugs": {
-    "url": "https://github.com/Financial-Times/promise-rat-race/issues"
-  },
-  "homepage": "https://github.com/Financial-Times/promise-rat-race#readme",
-  "devDependencies": {
-    "chai": "^3.5.0",
-    "eslint": "^2.2.0",
-    "lintspaces-cli": "^0.1.1",
-    "mocha": "^2.5.3"
-  }
-}
+{"name":"promise-rat-race","version":"1.5.1","description":"like Promise.race, but doesn't care about the losers in the race","main":"rat-race.js","repository":{"type":"git","url":"git+https://github.com/Financial-Times/promise-rat-race.git"},"keywords":["promise","race"],"author":["Rhys Evans <[e-mail]>","Matt Andrews <[e-mail]>"],"license":"MIT","bugs":{"url":"https://github.com/Financial-Times/promise-rat-race/issues"},"homepage":"https://github.com/Financial-Times/promise-rat-race#readme","devDependencies":{"chai":"^3.5.0","eslint":"^2.2.0","lintspaces-cli":"^0.1.1","mocha":"^2.5.3","npm-prepublish":"^1.2.2"}}

test.js

@@ -0,1 +1,2 @@
+'use strict';
 const expect = require('chai').expect;
@@ -79,8 +80,8 @@ const ratRace = require('./rat-race');
 
-	it('should hang when any promise hangs', () => {
-		const resolved = false;
+	it('should hang when any promise hangs', done => {
+		let resolved = false;
 		const hanging = new Promise(() => null);
-		return ratRace([
+		ratRace([
 			hanging,
-			delay(30, 3),
+			delay(30, 3, true),
 			delay(10, 1, true),
@@ -95,2 +96,3 @@ delay(40, 4, true)
 			expect(resolved).to.be.false;
+			done()
 		}, 300)
@@ -97,0 +99,0 @@ });

New alerts

No contributors or author data

Maintenance

Package does not specify a list of contributors or an author in package.json.

Found 1 instance in 1 package

Fixed alerts

No contributors or author data

Maintenance

Package does not specify a list of contributors or an author in package.json.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

14484

increased by38.94%

Number of package files

10

increased by11.11%

Lines of code

160

increased by1.27%

Worsened metrics

Dev dependency count

5

increased by25%

No dependency changes