protractor-cucumber-framework - npm Package Compare versions

Comparing version 0.3.2 to 0.3.3

index.js

@@ -5,3 +5,4 @@ var q = require('q'),
     debug = require('debug')('protractor-cucumber-framework'),
-    Cucumber = require('cucumber');
+    Cucumber = require('cucumber'),
+    state = require('./lib/runState');
 
@@ -17,7 +18,9 @@ /**
   var results = {}
-  require('./lib/runState').initialize(runner, results);
 
   return runner.runTestPreparer().then(function() {
+    var opts = runner.getConfig().cucumberOpts;
+    state.initialize(runner, results, opts.strict);
+
     return q.promise(function(resolve, reject) {
-      var cliArguments = convertOptionsToCliArguments(runner.getConfig().cucumberOpts);
+      var cliArguments = convertOptionsToCliArguments(opts);
       cliArguments.push('--require', path.resolve(__dirname, 'lib', 'resultsCapturer.js'));
@@ -33,3 +36,2 @@ cliArguments = cliArguments.concat(specs);
           }
-
           resolve(results);
@@ -36,0 +38,0 @@ } catch (err) {

lib/resultsCapturer.js

@@ -62,21 +62,30 @@ var state = require('./runState');
     var stepResult = event.getPayloadItem('stepResult');
-    var isStepFailed = stepResult.getStatus() === Cucumber.Status.FAILED;
-    var isStepSuccessful = stepResult.getStatus() === Cucumber.Status.PASSED;
 
-    if (isStepSuccessful) {
-      stepResults.assertions.push({passed: true});
-      stepResults.duration += stepResult.getDuration();
-    } else if (isStepFailed) {
-      scenarioFailed = true;
-      var failureMessage = stepResult.getFailureException();
-      stepResults.assertions.push({
-        passed: false,
-        errorMsg: failureMessage.message,
-        stackTrace: failureMessage.stack
-      });
-      stepResults.duration += stepResult.getDuration();
+    switch (stepResult.getStatus()) {
+      case Cucumber.Status.PASSED:
+        stepResults.assertions.push({passed: true});
+        break;
+      case Cucumber.Status.FAILED:
+        scenarioFailed = true;
+        var failureMessage = stepResult.getFailureException();
+        stepResults.assertions.push({
+          passed: false,
+          errorMsg: failureMessage.message,
+          stackTrace: failureMessage.stack
+        });
+        break;
+      case Cucumber.Status.UNDEFINED:
+        if (state.strict) {
+          scenarioFailed = true;
+          stepResults.assertions.push({
+            passed: false,
+            errorMsg: "Undefined steps are not allowed in strict mode"
+          });
+        }
+        break;
     }
 
+    stepResults.duration += stepResult.getDuration();
     callback();
   });
 };

lib/runState.js

 var state = {};
 
-state.initialize = function (runner, results) {
+state.initialize = function (runner, results, strict) {
   state.runner = runner;
   state.results = results;
+  state.strict = strict;
 };
 
 module.exports = state;

package.json

 {
   "name": "protractor-cucumber-framework",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Protractor framework for Cucumber.js",
@@ -36,3 +36,3 @@ "main": "index.js",
     "debug": "^2.2.0",
-    "glob": "^6.0.1",
+    "glob": "^6.0.4",
     "object-assign": "^4.0.1",
@@ -46,7 +46,7 @@ "q": "^1.4.1"
     "chai": "^3.4.1",
-    "chai-as-promised": "^5.1.0",
+    "chai-as-promised": "^5.2.0",
     "cucumber": "^0.9.1",
     "httpster": "^1.0.1",
-    "protractor": "^2.5.1"
+    "protractor": "^3.0.0"
   }
 }

New alerts

SPDX disjunction

License

SPDX disjunction for an artifact's license information

Found 1 instance in 1 package

Fixed alerts

SPDX disjunction

License

SPDX disjunction for an artifact's license information

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

9558

increased by2.67%

Lines of code

168

increased by7.69%

Dependency changes

• Updatedglob@^6.0.4