pullstream - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

package.json

 {
   "name": "pullstream",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "A stream you can pull data from.",
   "main": "pullstream.js",
   "scripts": {
-    "test": "./node_modules/.bin/nodeunit ./test/"
+    "test": "nodeunit test"
   },
@@ -22,12 +22,12 @@ "license": "MIT",
   "devDependencies": {
-    "nodeunit": "~0.7.4",
-    "stream-buffers": "~0.2.3",
-    "async": "~0.1.22"
+    "nodeunit": ">= 0.9.0 < 1",
+    "stream-buffers": ">= 0.2.6 < 1",
+    "async": ">= 0.9.0 <"
   },
   "dependencies": {
-    "over": "~0.0.5",
-    "readable-stream": "~1.0.0",
-    "setimmediate": "~1.0.1",
-    "slice-stream": "0.0.0"
+    "over": ">= 0.0.5 < 1",
+    "readable-stream": "~1.0.31",
+    "setimmediate": ">= 1.0.2 < 2",
+    "slice-stream": ">= 1.0.0 < 2"
   }
 }

pullstream.js

@@ -7,10 +7,6 @@ 'use strict';
 var inherits = require("util").inherits;
-var PassThrough = require('stream').PassThrough;
+var PassThrough = require('readable-stream/passthrough');
 var over = require('over');
 var SliceStream = require('slice-stream');
 
-if (!PassThrough) {
-  PassThrough = require('readable-stream/passthrough');
-}
-
 function PullStream(opts) {
@@ -49,3 +45,3 @@ var self = this;
       if (data) {
-        process.nextTick(callback.bind(null, null, data));
+        setImmediate(callback.bind(null, null, data));
       } else {
@@ -114,3 +110,3 @@ self._serviceRequests = pullServiceRequest;
   if (bytesDrained === len) {
-     process.nextTick(callback);
+     setImmediate(callback);
   } else if (bytesDrained > 0) {
@@ -143,3 +139,3 @@ this.drain(len - bytesDrained, callback);
   }
-  process.nextTick(callback);
-};
+  setImmediate(callback);
+};

README.md

@@ -1,2 +0,2 @@
-pullstream [![Build Status](https://travis-ci.org/nearinfinity/node-pullstream.png)](https://travis-ci.org/nearinfinity/node-pullstream)
+pullstream [![Build Status](https://travis-ci.org/EvanOxfeld/node-pullstream.png)](https://travis-ci.org/EvanOxfeld/node-pullstream)
 ==========
@@ -3,0 +3,0 @@

test/pullStreamTest.js

@@ -22,5 +22,5 @@ 'use strict';
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
@@ -64,5 +64,5 @@ ps.pull('Hello'.length, function (err, data) {
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
@@ -110,2 +110,4 @@ ps.pull('Hello'.length, function (err, data) {
     });
+
+    sourceStream.pipe(ps);
     values.forEach(function(val) {
@@ -115,4 +117,2 @@ sourceStream.put(val);
 
-    sourceStream.pipe(ps);
-
     async.forEachSeries(values, function (val, callback) {
@@ -142,5 +142,5 @@ ps.pull(4, function (err, data) {
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
@@ -168,8 +168,7 @@ ps.pull('Hello'.length, function (err, data) {
     var sourceStream = new streamBuffers.ReadableStreamBuffer({
-      frequency: 0,
       chunkSize: 1000
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
@@ -219,8 +218,8 @@ ps.pull(0, function (err, data) {
     var sourceStream = new streamBuffers.ReadableStreamBuffer({
-      frequency: 0,
+      frequency: 1,
       chunkSize: 1000
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
@@ -305,5 +304,5 @@ ps.pull('Hello World!'.length, function (err, data) {
     });
-    sourceStream.put(aVals);
 
     sourceStream.pipe(ps);
+    sourceStream.put(aVals);
 
@@ -333,5 +332,5 @@ var writableStream = new streamBuffers.WritableStreamBuffer({
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
@@ -358,6 +357,7 @@ ps.pull('Hello'.length, function (err, data) {
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
+
     ps.pull('Hello'.length, function (err, data) {
@@ -383,5 +383,5 @@ if (err) {
     });
-    sourceStream.put("Hello World!");
 
     sourceStream.pipe(ps);
+    sourceStream.put("Hello World!");
 
@@ -400,22 +400,23 @@ ps.pull('Hello'.length, function (err, data) {
 
-  "prepend": function (t) {
-    t.expect(1);
-    var ps = new PullStream();
+// TODO: node PassThrough stream doesn't handle unshift the same way anymore.
+//  "prepend": function (t) {
+//    t.expect(1);
+//    var ps = new PullStream();
+//
+//    var sourceStream = new streamBuffers.ReadableStreamBuffer();
+//
+//    sourceStream.pipe(ps);
+//    sourceStream.put("World!");
+//    ps.prepend("Hello ");
+//
+//    ps.pull('Hello World!'.length, function (err, data) {
+//      if (err) {
+//        return t.done(err);
+//      }
+//      t.equal('Hello World!', data.toString());
+//      sourceStream.destroy();
+//      t.done();
+//    });
+//  },
 
-    var sourceStream = new streamBuffers.ReadableStreamBuffer();
-
-    sourceStream.pipe(ps);
-    sourceStream.put("World!");
-    ps.prepend("Hello ");
-
-    ps.pull('Hello World!'.length, function (err, data) {
-      if (err) {
-        return t.done(err);
-      }
-      t.equal('Hello World!', data.toString());
-      sourceStream.destroy();
-      t.done();
-    });
-  },
-
   "drain": function (t) {
@@ -422,0 +423,0 @@ t.expect(1);

No alert changes

Improved metrics

Total package byte prevSize

24575

increased by0.27%

Number of package files

11

increased by10%

Lines of code

490

increased by0.2%

Dependency changes

• + Addedslice-stream@1.0.0(transitive)

• - Removedslice-stream@0.0.0(transitive)

• Updatedover@>= 0.0.5 < 1

• Updatedreadable-stream@~1.0.31

• Updatedsetimmediate@>= 1.0.2 < 2

• Updatedslice-stream@>= 1.0.0 < 2