q3-schema-utils - npm Package Compare versions

Comparing version 1.18.3 to 1.18.4

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [1.18.4](https://github.com/3merge/q3-api/compare/v1.18.3...v1.18.4) (2021-07-22)
+
+
+### Bug Fixes
+
+* handle sub doc remove error ([078f0c5](https://github.com/3merge/q3-api/commit/078f0c58dd62b3f6625044ed4efcb1d60ee0f410))
+
+
+
+
+
 ## [1.18.3](https://github.com/3merge/q3-api/compare/v1.18.2...v1.18.3) (2021-07-19)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "q3-schema-utils",
-  "version": "1.18.3",
+  "version": "1.18.4",
   "main": "index.js",
@@ -10,6 +10,6 @@ "dependencies": {
     "mongoose": "^5.11.8",
-    "q3-core-responder": "^1.18.3"
+    "q3-core-responder": "^1.18.4"
   },
   "devDependencies": {
-    "q3-test-utils": "^1.18.3"
+    "q3-test-utils": "^1.18.4"
   },
@@ -24,3 +24,3 @@ "jest": {
   },
-  "gitHead": "f1c6525359b94b0b840ea6750a40ac4391be83ee"
+  "gitHead": "86a02401aec2df22b4877b5b461a224915a2fafa"
 }

plugins/common.js

@@ -109,8 +109,14 @@ /* eslint-disable func-names, no-param-reassign */
 async function removeSubDocument(field, id) {
-  const removeChild = (v) => {
+  const removeChild = async (v) => {
     const subdoc = this.getSubDocument(field, v);
-    subdoc.remove();
+
+    return new Promise((res, rej) =>
+      subdoc.remove((err, product) => {
+        if (err) rej(err);
+        else res(product);
+      }),
+    );
   };
 
-  executeOn(id, removeChild);
+  await executeOn(id, removeChild);
 
@@ -117,0 +123,0 @@ return this.save({

No alert changes

Improved metrics

Total package byte prevSize

49745

increased by0.76%

Lines of code

757

increased by0.66%

Dependency changes

• Updatedq3-core-responder@^1.18.4