readable-stream - npm Package Compare versions

Comparing version 2.3.5 to 2.3.6

lib/_stream_duplex.js

@@ -55,6 +55,9 @@ // Copyright Joyent, Inc. and other Node contributors.
 
-var keys = objectKeys(Writable.prototype);
-for (var v = 0; v < keys.length; v++) {
-  var method = keys[v];
-  if (!Duplex.prototype[method]) Duplex.prototype[method] = Writable.prototype[method];
+{
+  // avoid scope creep, the keys array can then be collected
+  var keys = objectKeys(Writable.prototype);
+  for (var v = 0; v < keys.length; v++) {
+    var method = keys[v];
+    if (!Duplex.prototype[method]) Duplex.prototype[method] = Writable.prototype[method];
+  }
 }
@@ -78,2 +81,12 @@
 
+Object.defineProperty(Duplex.prototype, 'writableHighWaterMark', {
+  // making it explicit this property is not enumerable
+  // because otherwise some prototype manipulation in
+  // userland will fail
+  enumerable: false,
+  get: function () {
+    return this._writableState.highWaterMark;
+  }
+});
+
 // the no-half-open enforcer
@@ -120,8 +133,2 @@ function onend() {
   pna.nextTick(cb, err);
-};
-
-function forEach(xs, f) {
-  for (var i = 0, l = xs.length; i < l; i++) {
-    f(xs[i], i);
-  }
-}
+};

lib/_stream_readable.js

@@ -879,2 +879,12 @@ // Copyright Joyent, Inc. and other Node contributors.
 
+Object.defineProperty(Readable.prototype, 'readableHighWaterMark', {
+  // making it explicit this property is not enumerable
+  // because otherwise some prototype manipulation in
+  // userland will fail
+  enumerable: false,
+  get: function () {
+    return this._readableState.highWaterMark;
+  }
+});
+
 // exposed for testing purposes only.
@@ -1005,8 +1015,2 @@ Readable._fromList = fromList;
 
-function forEach(xs, f) {
-  for (var i = 0, l = xs.length; i < l; i++) {
-    f(xs[i], i);
-  }
-}
-
 function indexOf(xs, x) {
@@ -1013,0 +1017,0 @@ for (var i = 0, l = xs.length; i < l; i++) {

lib/_stream_writable.js

@@ -371,2 +371,12 @@ // Copyright Joyent, Inc. and other Node contributors.
 
+Object.defineProperty(Writable.prototype, 'writableHighWaterMark', {
+  // making it explicit this property is not enumerable
+  // because otherwise some prototype manipulation in
+  // userland will fail
+  enumerable: false,
+  get: function () {
+    return this._writableState.highWaterMark;
+  }
+});
+
 // if we're already writing something, then just put this
@@ -373,0 +383,0 @@ // in the queue, and wait our turn.  Otherwise, call _write

package.json

 {
   "name": "readable-stream",
-  "version": "2.3.5",
+  "version": "2.3.6",
   "description": "Streams3, a user-land copy of the stream library from Node.js",
@@ -12,3 +12,3 @@ "main": "readable.js",
     "safe-buffer": "~5.1.1",
-    "string_decoder": "~1.0.3",
+    "string_decoder": "~1.1.1",
     "util-deprecate": "~1.0.1"
@@ -23,4 +23,3 @@ },
     "tap": "^0.7.0",
-    "tape": "^4.8.0",
-    "zuul": "^3.11.1"
+    "tape": "^4.8.0"
   },
@@ -30,5 +29,2 @@ "scripts": {
     "ci": "tap test/parallel/*.js test/ours/*.js --tap | tee test.tap && node test/verify-dependencies.js",
-    "browser": "npm run write-zuul && zuul --browser-retries 2 -- test/browser.js",
-    "write-zuul": "printf \"ui: tape\nbrowsers:\n  - name: $BROWSER_NAME\n    version: $BROWSER_VERSION\n\">.zuul.yml",
-    "local": "zuul --local 3000 --no-coverage -- test/browser.js",
     "cover": "nyc npm test",
@@ -35,0 +31,0 @@ "report": "nyc report --reporter=lcov"

README.md

 # readable-stream
 
-***Node-core v8.9.4 streams for userland*** [![Build Status](https://travis-ci.org/nodejs/readable-stream.svg?branch=master)](https://travis-ci.org/nodejs/readable-stream)
+***Node-core v8.11.1 streams for userland*** [![Build Status](https://travis-ci.org/nodejs/readable-stream.svg?branch=master)](https://travis-ci.org/nodejs/readable-stream)
 
@@ -21,3 +21,3 @@
 
-Full documentation may be found on the [Node.js website](https://nodejs.org/dist/v8.9.4/docs/api/stream.html).
+Full documentation may be found on the [Node.js website](https://nodejs.org/dist/v8.11.1/docs/api/stream.html).
 
@@ -24,0 +24,0 @@ If you want to guarantee a stable streams base, regardless of what version of

No alert changes

Improved metrics

Total package byte prevSize

87961

increased by0.56%

Dev dependency count

7

decreased by-12.5%

Lines of code

1923

increased by1.05%

Dependency changes

• + Addedstring_decoder@1.1.1(transitive)

• - Removedstring_decoder@1.0.3(transitive)

• Updatedstring_decoder@~1.1.1