resolve - npm Package Compare versions

Comparing version 1.7.0 to 1.7.1

lib/sync.js

@@ -89,3 +89,3 @@ var core = require('./core');
         if (pkg && opts.packageFilter) {
-            pkg = opts.packageFilter(pkg, pkgfile);
+            pkg = opts.packageFilter(pkg, dir);
         }
@@ -92,0 +92,0 @@

package.json

 {
   "name": "resolve",
   "description": "resolve like require.resolve() on behalf of files asynchronously and synchronously",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "repository": {
@@ -6,0 +6,0 @@ "type": "git",

test/filter_sync.js

@@ -7,11 +7,21 @@ var path = require('path');
     var dir = path.join(__dirname, 'resolver');
+    var packageFilterArgs;
     var res = resolve.sync('./baz', {
         basedir: dir,
-        packageFilter: function (pkg) {
+        packageFilter: function (pkg, dir) {
             pkg.main = 'doom';
+            packageFilterArgs = [pkg, dir];
             return pkg;
         }
     });
-    t.equal(res, path.join(dir, 'baz/doom.js'));
+
+    t.equal(res, path.join(dir, 'baz/doom.js'), 'changing the package "main" works');
+
+    var packageData = packageFilterArgs[0];
+    t.equal(packageData.main, 'doom', 'package "main" was altered');
+
+    var packageFile = packageFilterArgs[1];
+    t.equal(packageFile, path.join(dir, 'baz'), 'second packageFilter argument is "dir"');
+
     t.end();
 });

test/filter.js

@@ -6,8 +6,10 @@ var path = require('path');
 test('filter', function (t) {
-    t.plan(2);
+    t.plan(4);
     var dir = path.join(__dirname, 'resolver');
+    var packageFilterArgs;
     resolve('./baz', {
         basedir: dir,
-        packageFilter: function (pkg) {
+        packageFilter: function (pkg, pkgfile) {
             pkg.main = 'doom';
+            packageFilterArgs = [pkg, pkgfile];
             return pkg;
@@ -17,5 +19,18 @@ }
         if (err) t.fail(err);
-        t.equal(res, path.join(dir, 'baz/doom.js'));
-        t.equal(pkg.main, 'doom');
+
+        t.equal(res, path.join(dir, 'baz/doom.js'), 'changing the package "main" works');
+
+        var packageData = packageFilterArgs[0];
+        t.equal(pkg, packageData, 'first packageFilter argument is "pkg"');
+        t.equal(packageData.main, 'doom', 'package "main" was altered');
+
+        var packageFile = packageFilterArgs[1];
+        t.equal(
+            packageFile,
+            path.join(dir, 'baz/package.json'),
+            'second packageFilter argument is "pkgfile"'
+        );
+
+        t.end();
     });
 });

No alert changes

Improved metrics

Total package byte prevSize

76446

increased by1.38%

Lines of code

1699

increased by1.01%

Number of lines in readme file

174

increased by2.35%

No dependency changes