rsmq - npm Package Compare versions

Comparing version 0.2.0 to 0.2.1

index.js

@@ -214,2 +214,6 @@ // Generated by CoffeeScript 1.6.2
           }
+          if (resp[0][0] === null) {
+            _this._handleError(cb, "queueNotFound");
+            return;
+          }
           o = {
@@ -216,0 +220,0 @@ vt: parseInt(resp[0][0], 10),

package.json

 {
     "name": "rsmq",
     "description": "A really simple message queue based on Redis",
-    "version": "0.2.0",
+    "version": "0.2.1",
     "author": "P. Liess <[e-mail]>",
@@ -6,0 +6,0 @@ "engines": {

README.md

@@ -19,4 +19,3 @@ # rsmq
   * Durability depends on your Redis setup.
-  * No ReceiptHandle. A message is deleted by the message id.
-    * This means that a message can be deleted if you store the id that is returned from the `sendMessage` method. 
+  * No ReceiptHandle. A message is deleted by the message id. A message can be deleted if you store the id that is returned from the `sendMessage` method.
   * No MessageRetentionPeriod: Messages stay in the queue unless deleted.
@@ -127,7 +126,4 @@ * No bulk operations (SendMessageBatch, DeleteMessageBatch)
 
-Errors:
 
-* `"Queue not found"`
 
-
 ### createQueue
@@ -148,9 +144,4 @@
 
-Errors:
 
-* `"Invalid qname format"`
-* `"Queue exists"`
 
-
-
 ### deleteMessage
@@ -167,8 +158,4 @@
 
-Errors:
 
-* `"Queue not found"`
 
-
-
 ### deleteQueue
@@ -186,8 +173,4 @@
 
-Errors:
 
-* `"Invalid qname format"`
-* `"Queue not found"`
 
-
 ### getQueueAttributes
@@ -201,3 +184,3 @@
 
-Returns:
+Returns an object:
 
@@ -212,5 +195,6 @@ * `vt`: The visibility timeout for the queue in seconds
 * `msgs`: Current number of messages in the queue
-* `hiddenmsgs`: Current number of hidden / not visible messages. A message can hidden while "in flight" due to a `vt` parameter or when sent with a `delay`.
+* `hiddenmsgs`: Current number of hidden / not visible messages. A message can hidden while "in flight" due to a `vt` parameter or when sent with a `delay`
 
 
+
 ### listQueues
@@ -220,7 +204,8 @@
 
-Returns:
+Returns an array:
 
-* Array of queues (e.g. ["qname1", "qname2"])
+* `["qname1", "qname2"]`
 
 
+
 ### receiveMessage
@@ -235,3 +220,3 @@
 
-Returns:
+Returns an object:
 
@@ -246,8 +231,4 @@ * `message`: The message's contents.
 
-Errors:
 
-* `"Queue not found"`
 
-
-
 ### sendMessage
@@ -267,11 +248,6 @@
 
-Error:
 
-* `"Queue not found"`
 
 
 
-
-
-
 ## Not implemented yet
@@ -278,0 +254,0 @@

test/test.js

@@ -39,3 +39,2 @@ // Generated by CoffeeScript 1.6.2
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("Invalid qname format");
@@ -49,3 +48,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("Invalid qname format");
@@ -60,3 +58,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("vt must be between 0 and 9999999");
@@ -71,3 +68,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("vt must be between 0 and 9999999");
@@ -82,3 +78,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("vt must be between 0 and 9999999");
@@ -93,3 +88,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("delay must be between 0 and 9999999");
@@ -104,3 +98,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("delay must be between 0 and 9999999");
@@ -115,3 +108,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("delay must be between 0 and 9999999");
@@ -126,3 +118,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("maxsize must be between 1024 and 65536");
@@ -137,3 +128,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("maxsize must be between 1024 and 65536");
@@ -148,3 +138,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("maxsize must be between 1024 and 65536");
@@ -159,3 +148,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("maxsize must be between 1024 and 65536");
@@ -185,3 +173,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("Queue exists");
@@ -218,2 +205,10 @@ done();
       });
+      it('Should fail: GetQueueAttributes of bogus queue', function(done) {
+        rsmq.getQueueAttributes({
+          qname: "sdfsdfsdf"
+        }, function(err, resp) {
+          err.message.should.equal("Queue not found");
+          done();
+        });
+      });
     });
@@ -226,3 +221,2 @@ describe('Messages', function() {
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("Queue not found");
@@ -234,3 +228,2 @@ done();
         rsmq.sendMessage({}, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("No qname supplied");
@@ -245,3 +238,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("Message must be a string");
@@ -256,3 +248,2 @@ done();
         }, function(err, resp) {
-          should.exist(err);
           err.message.should.equal("Message must be a string");
@@ -259,0 +250,0 @@ done();

No alert changes

Worsened metrics

Total package byte prevSize

63403

decreased by-0.7%

Lines of code

927

decreased by-0.54%

Number of lines in readme file

262

decreased by-8.39%

No dependency changes