searchitunes - npm Package Compare versions

Comparing version 2.0.1 to 2.1.1

package.json

@@ -8,4 +8,4 @@ {
   "name":                 "searchitunes",
-  "description":          "Light module to search the Apple iTunes Store and App Store",
-  "version":              "2.0.1",
+  "description":          "Search the Apple iTunes Store and App Store with this lightweight module",
+  "version":              "2.1.1",
   "repository": {
@@ -19,3 +19,5 @@ "type":               "git",
   "main":                 "searchitunes.js",
-  "dependencies":         {},
+  "dependencies": {
+    "httpreq":            "0.4.x"
+  },
   "devDependencies":      {},
@@ -27,6 +29,3 @@ "optionalDependencies": {},
   "keywords":             ["itunes", "apps", "music", "appstore", "apple", "api"],
-  "license": {
-    "type":               "Public Domain",
-    "url":                "https://github.com/fvdm/nodejs-searchitunes/raw/master/UNLICENSE"
-  },
+  "license":              "Unlicense",
   "scripts": {
@@ -33,0 +32,0 @@ "test":               "node test.js"

searchitunes.js

@@ -12,69 +12,34 @@ /*
 
-var http = require ('http');
-var querystring = require ('querystring');
+var http = require ('httpreq');
 
-module.exports = function (params, cb) {
-  // prevent multiple callbacks
-  var complete = false;
-  function doCallback (err, res) {
-    if (!complete) {
-      complete = true;
-      cb (err, res || null);
-    }
-  }
-
-  // check input
+module.exports = function (params, callback) {
   if (!params || !(params instanceof Object)) {
-    doCallback (new Error('invalid params'));
-    return;
+    return callback (new Error ('invalid params'));
   }
 
-  // build request
   params.version = params.version || 2;
 
-  var options = {
-    host: 'itunes.apple.com',
-    path: '/WebObjects/MZStoreServices.woa/ws/wsSearch?'+ querystring.stringify (params),
-    method: 'GET',
-    headers: {
-      'Accept': 'application/json',
-      'User-Agent': 'searchitunes.js'
-    }
-  };
-
-  var request = http.request (options);
-
-  // response
-  request.on ('response', function (response) {
-    var data = [];
-    var size = 0;
-    
-    response.on ('data', function (ch) {
-      data.push(ch);
-      size += ch.length;
-    });
-
-    response.on ('close', function () {
-      doCallback (new Error ('request closed'));
-    });
-    
-    response.on ('end', function () {
-      data = new Buffer.concat (data, size).toString ('utf8').trim ();
-
-      if( response.statusCode >= 300 ) {
+  http.get (
+    'http://itunes.apple.com/WebObjects/MZStoreServices.woa/ws/wsSearch',
+    {
+      parameters: params,
+      headers: {
+        'Accept': 'application/json',
+        'User-Agent': 'searchitunes.js'
+      }
+    },
+    function (err, res) {
+      if (err) {
         var error = new Error ('http error');
-        error.code = response.statusCode;
-        error.body = data;
-        doCallback (error);
-        return;
+        error.code = res.statusCode;
+        error.body = res.body;
+        return callback (error);
       }
 
       try {
-        data = JSON.parse (data);
-
+        data = JSON.parse (res.body);
         if (!(data.results instanceof Array) || data.results.length === 0) {
-          doCallback (new Error('no results'));
-        } else {
-          doCallback (null, data);
+          return callback (new Error ('no results'));
         }
+        return callback (null, data);
       }
@@ -84,16 +49,6 @@ catch (e) {
         error.error = e;
-        doCallback (error);
+        callback (error);
       }
-    });
-  });
-
-  // request failed
-  request.on ('error', function (err) {
-    var error = new Error ('request failed');
-    error.error = err;
-    doCallback (error);
-  });
-
-  // run it
-  request.end ();
+    }
+  );
 };

New alerts

Network access

Supply chain risk

This module accesses the network.

Found 1 instance in 1 package

SPDX disjunction

License

SPDX disjunction for an artifact's license information

Found 1 instance in 1 package

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Network access

Supply chain risk

This module accesses the network.

Found 1 instance in 1 package

SPDX disjunction

License

SPDX disjunction for an artifact's license information

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

1

decreased by-50%

Worsened metrics

Total package byte prevSize

13421

decreased by-6.75%

Dependency count

1

increased byInfinity%

Lines of code

159

decreased by-18.04%

Dependency changes

• + Addedhttpreq@0.4.x

• + Addedhttpreq@0.4.24(transitive)