select - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

bower.json

 {
   "name": "select",
-  "version": "1.0.1",
-  "description": "Lightweight DOM selection",
+  "version": "1.0.2",
+  "description": "Programmatically select the text of a HTML element",
   "license": "MIT",
@@ -6,0 +6,0 @@ "main": "dist/select.js",

dist/select.js

@@ -6,3 +6,4 @@ (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.select = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
     if (element.nodeName === 'INPUT' || element.nodeName === 'TEXTAREA') {
-        element.select();
+        element.selectionStart = 0;
+        element.selectionEnd = element.value.length;
     }
@@ -23,2 +24,2 @@ else {
 },{}]},{},[1])(1)
-});
+});

package.json

 {
   "name": "select",
-  "description": "Lightweight DOM selection",
-  "version": "1.0.1",
+  "description": "Programmatically select the text of a HTML element",
+  "version": "1.0.2",
   "main": "src/select.js",
@@ -15,2 +15,3 @@ "repository": "zenorocha/select",
     "browserify": "^11.2.0",
+    "chai": "^3.3.0",
     "karma": "^0.13.10",
@@ -20,3 +21,5 @@ "karma-browserify": "^4.4.0",
     "karma-mocha": "^0.2.0",
-    "karma-phantomjs-launcher": "^0.2.1"
+    "karma-phantomjs-launcher": "^0.2.1",
+    "mocha": "^2.3.3",
+    "phantomjs": "^1.9.18"
   },
@@ -23,0 +26,0 @@ "scripts": {

readme.md

@@ -5,3 +5,3 @@ # select
 
-Lightweight DOM selection.
+Programmatically select the text of a HTML element.
 
@@ -8,0 +8,0 @@ ## Install

src/select.js

@@ -5,3 +5,4 @@ function select(element) {
     if (element.nodeName === 'INPUT' || element.nodeName === 'TEXTAREA') {
-        element.select();
+        element.selectionStart = 0;
+        element.selectionEnd = element.value.length;
     }
@@ -8,0 +9,0 @@ else {

test/select.js

@@ -48,3 +48,3 @@ var select = require('../src/select');
 
-describe('select non-editable element with children nodes', function() {
+describe('select non-editable element with child node', function() {
     before(function() {
@@ -69,1 +69,27 @@ global.li = document.createElement('li');
 });
+
+describe('select non-editable svg element w/ multiple text children', function() {
+    before(function() {
+        global.text1 = document.createElement('text');
+        global.text1.textContent = 'lorem ipsum';
+
+        global.text2 = document.createElement('text');
+        global.text2.textContent = 'dolor zet';
+
+        global.svg = document.createElement('svg');
+        global.svg.appendChild(global.text1);
+        global.svg.appendChild(global.text2);
+
+        document.body.appendChild(global.svg);
+    });
+
+    after(function() {
+        document.body.innerHTML = '';
+    });
+
+    it('should return the selected text', function() {
+        var result = select(global.svg);
+        assert.equal(result, global.text1.textContent +
+                             global.text2.textContent);
+    });
+});

No alert changes

Improved metrics

Total package byte prevSize

9135

increased by15.75%

Lines of code

185

increased by14.2%

Worsened metrics

Dev dependency count

9

increased by50%

No dependency changes