selfsigned - npm Package Compare versions

Comparing version 1.10.1 to 1.10.2

package.json

 {
   "name": "selfsigned",
-  "version": "1.10.1",
+  "version": "1.10.2",
   "description": "Generate self signed certificates private and public keys",
@@ -28,3 +28,3 @@ "main": "index.js",
       "name": "Charles Bushong",
-      "email": "[e-mail]  ",
+      "email": "[e-mail]",
       "url": "http://github.com/bushong1"
@@ -35,3 +35,3 @@ }
   "dependencies": {
-    "node-forge": "0.6.33"
+    "node-forge": "0.7.1"
   },
@@ -38,0 +38,0 @@ "devDependencies": {

README.md

@@ -38,2 +38,6 @@ Generate a self signed x509 certificate from node.js.
 
+## Attributes
+
+for attributes, please refer to: https://github.com/digitalbazaar/forge/blob/master/js/x509.js#L121
+
 ## Options
@@ -40,0 +44,0 @@

test/tests.js

@@ -36,3 +36,3 @@ var assert  = require('assert');
   it('should include pkcs7', function (done) {
-    var pems = generate(null, {pkcs7: true});
+    var pems = generate([{ name: 'commonName', value: 'contoso.com' }], {pkcs7: true});
 
@@ -42,9 +42,24 @@ assert.ok(!!pems.pkcs7, 'has a pkcs7');
     try {
-      fs.unlinkSync('/tmp/tmp.crt');
-    } catch(er){}
+      fs.unlinkSync('/tmp/tmp.pkcs7');
+    } catch (er) {}
 
-    fs.writeFileSync('/tmp/tmp.crt', pems.cert);
-    exec('openssl crl2pkcs7 -nocrl -certfile /tmp/tmp.crt', function (err, stdout, stderr) {
-      var expected = stdout.toString().replace(/\n/g, '\r\n'); //node-forge uses \r\n
-      assert.equal(pems.pkcs7, expected);
+    fs.writeFileSync('/tmp/tmp.pkcs7', pems.pkcs7);
+    exec('openssl pkcs7 -print_certs -in /tmp/tmp.pkcs7', function (err, stdout, stderr) {
+      if (err) {
+        return done(err);
+      }
+
+      const errorMessage = stderr.toString();
+      if (errorMessage.length) {
+        return done(new Error(errorMessage));
+      }
+
+      const expected = stdout.toString().replace(/\n/g, '\r\n'); //node-forge uses \r\n
+      assert.equal(
+        `subject=/CN=contoso.com\r\nissuer=/CN=contoso.com\r\n` +
+          pems.cert +
+          '\r\n',
+        expected
+      );
+
       done();
@@ -92,14 +107,29 @@ });
     it('should include pkcs7', function (done) {
-      generate(null, {pkcs7: true}, function (err, pems) {
+      generate([{ name: 'commonName', value: 'contoso.com' }], {pkcs7: true}, function (err, pems) {
         if (err) done(err);
         assert.ok(!!pems.pkcs7, 'has a pkcs7');
 
-        try{
-          fs.unlinkSync('/tmp/tmp.crt');
-        }catch(er){}
+        try {
+          fs.unlinkSync('/tmp/tmp.pkcs7');
+        } catch (er) {}
 
-        fs.writeFileSync('/tmp/tmp.crt', pems.cert);
-        exec('openssl crl2pkcs7 -nocrl -certfile /tmp/tmp.crt', function (err, stdout, stderr) {
-          var expected = stdout.toString().replace(/\n/g, '\r\n'); //node-forge uses \r\n
-          assert.equal(pems.pkcs7, expected);
+        fs.writeFileSync('/tmp/tmp.pkcs7', pems.pkcs7);
+        exec('openssl pkcs7 -print_certs -in /tmp/tmp.pkcs7', function (err, stdout, stderr) {
+          if (err) {
+            return done(err);
+          }
+
+          const errorMessage = stderr.toString();
+          if (errorMessage.length) {
+            return done(new Error(errorMessage));
+          }
+
+          const expected = stdout.toString().replace(/\n/g, '\r\n'); //node-forge uses \r\n
+          assert.equal(
+            `subject=/CN=contoso.com\r\nissuer=/CN=contoso.com\r\n` +
+              pems.cert +
+              '\r\n',
+            expected
+          );
+
           done();
@@ -106,0 +136,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

21599

increased by4.12%

Lines of code

286

increased by9.16%

Number of lines in readme file

86

increased by4.88%

Dependency changes

• + Addednode-forge@0.7.1(transitive)

• - Removednode-forge@0.6.33(transitive)

• Updatednode-forge@0.7.1