spdy-transport - npm Package Compare versions

Comparing version 2.0.14 to 2.0.15

lib/spdy-transport/connection.js

@@ -512,3 +512,3 @@ 'use strict';
     try {
-      state.pair.decompress.updateTableSize(settings.header_table_size);
+      state.pair.compress.updateTableSize(settings.header_table_size);
     } catch (e) {
@@ -515,0 +515,0 @@ this._goaway({

package.json

 {
   "name": "spdy-transport",
-  "version": "2.0.14",
+  "version": "2.0.15",
   "description": "SPDY v2, v3, v3.1 and HTTP2 transport",
@@ -19,3 +19,3 @@ "license": "MIT",
     "debug": "^2.2.0",
-    "hpack.js": "^2.1.4",
+    "hpack.js": "^2.1.6",
     "obuf": "^1.1.0",
@@ -22,0 +22,0 @@ "readable-stream": "^2.0.1",

test/both/transport/connection-test.js

@@ -428,5 +428,6 @@ var assert = require('assert');
     if (version >= 4) {
-      it('should error on too large HPACK table in SETTINGS', function(done) {
-        client._spdyState.framer.settingsFrame({
-          header_table_size: 0xffffffff
+      it('should ignore too large HPACK table in SETTINGS', function(done) {
+        var limit = 0xffffffff;
+        server._spdyState.framer.settingsFrame({
+          header_table_size: limit
         }, function(err) {
@@ -436,5 +437,37 @@ assert(!err);
 
+        var headers = {};
+        for (var i = 0; i < 2048; i++)
+          headers['h' + i] = (i % 250).toString();
+
         client.on('frame', function(frame) {
-          if (frame.type === 'GOAWAY') done();
+          if (frame.type !== 'SETTINGS' ||
+              frame.settings.header_table_size !== 0xffffffff) {
+            return;
+          }
+
+          // Time for request!
+          var one = client.request({
+            headers: headers,
+            path: '/hello'
+          });
+          one.end();
+          one.resume();
         });
+
+        server.on('frame', function(frame) {
+          if (frame.type === 'SETTINGS') {
+            // Emulate bigger table on server-side
+            server._spdyState.pair.decompress._table.protocolMaxSize = limit;
+            server._spdyState.pair.decompress._table.maxSize = limit;
+          }
+
+          if (frame.type !== 'HEADERS')
+            return;
+
+          assert.equal(server._spdyState.pair.decompress._table.size, 4062);
+          assert.equal(client._spdyState.pair.compress._table.size, 4062);
+          assert.equal(client._spdyState.pair.compress._table.maxSize,
+                       client._spdyState.constants.HEADER_TABLE_SIZE);
+          done();
+        });
       });
@@ -441,0 +474,0 @@

No alert changes

Improved metrics

Total package byte prevSize

250373

increased by0.44%

Lines of code

7822

increased by0.36%

Dependency changes

• Updatedhpack.js@^2.1.6