twilio - npm Package Compare versions

Comparing version 0.6.1 to 0.6.2

lib/resources/Queues.js

+/**
+ @module resources/Queues
+ The Twilio "Queues" Resource.
+ */
+var generate = require('./generate'),
+    ListInstanceResource = require('./ListInstanceResource');
+
+module.exports = function (client, accountSid) {
+    var baseResourceUrl = '/Accounts/' + accountSid + '/Queues';
+
+    //Instance requests
+    function Queues(sid) {
+        var resourceApi = {};
+
+        //Add standard instance resource functions
+        generate.restFunctions(resourceApi,client,['GET', 'POST', 'DELETE', {update:'POST'}], baseResourceUrl + '/' + sid);
+
+        //Add special call queue sub resources
+        resourceApi.members = ListInstanceResource(client, sid, 'Queues/Members',
+            ['GET', 'POST', {update:'POST'}],
+            ['GET']
+        );
+
+        //There's also a special resource for a call at the front of the queue, not specified by SID
+        resourceApi.members.front.get = resourceApi.members('Front').get;
+        resourceApi.members.front.post = resourceApi.members('Front').post;
+        resourceApi.members.front.update = resourceApi.members('Front').update;
+
+        return resourceApi;
+    }
+
+    //List requests
+    generate.restFunctions(Queues, client, ['GET', 'POST', {create:'POST'}], baseResourceUrl);
+
+
+    return Queues;
+};

lib/resources/Accounts.js

@@ -47,6 +47,3 @@ /**
             conferences:require('./Conferences')(client, sid),
-            queues:ListInstanceResource(client, sid, 'Queues',
-                ['GET', 'POST', 'DELETE', {update:'POST'}],
-                ['GET', 'POST', {create:'POST'}]
-            ),
+            queues:require('./Queues')(client, sid),
             recordings:require('./Recordings')(client, sid),
@@ -89,2 +86,3 @@ transcriptions:ListInstanceResource(client, sid, 'Transcriptions',
         resourceApi.update = resourceApi.put;
+        resourceApi.list = resourceApi.get;
 
@@ -101,2 +99,3 @@ //Mix in sub resources
     Accounts.create = Accounts.post;
+    Accounts.list = Accounts.get;
 
@@ -103,0 +102,0 @@ //Define other sub-resources of Accounts for master account

lib/resources/AvailablePhoneNumbers.js

@@ -19,2 +19,6 @@ /**
         };
+
+        resourceApi.local.list = resourceApi.local.get;
+        resourceApi.tollFree.list = resourceApi.tollFree.get;
+
         return resourceApi;
@@ -21,0 +25,0 @@ }

lib/resources/Calls.js

@@ -25,2 +25,5 @@ /**
 
+        resourceApi.recordings.list = resourceApi.recordings.get;
+        resourceApi.notifications.list = resourceApi.notifications.get;
+
         return resourceApi;
@@ -27,0 +30,0 @@ }

lib/resources/Conferences.js

@@ -21,2 +21,5 @@ /**
 
+        resourceApi.list = resourceApi.get;
+        resourceApi.participants.list = resourceApi.participants.get;
+
         return resourceApi;
@@ -23,0 +26,0 @@ }

lib/resources/generate.js

@@ -75,3 +75,3 @@ var _ = require('underscore');
             if (method === 'GET') {
-                object.get = generate(client, method, resource);
+                object.get = object.list = generate(client, method, resource);
             } else if (method === 'POST') {
@@ -78,0 +78,0 @@ object.post = generate(client, method, resource);

lib/resources/Recordings.js

@@ -22,2 +22,5 @@ /**
 
+        resourceApi.list = resourceApi.get;
+        resourceApi.transcriptions.list = resourceApi.transcriptions.get;
+
         return resourceApi;
@@ -24,0 +27,0 @@ }

lib/RestClient.js

@@ -101,2 +101,5 @@ /**
 
+            //hang response off the JSON-serialized data
+            data.nodeClientResponse = response;
+
             callback.call(client, err, data, response);
@@ -103,0 +106,0 @@ }

package.json

 {
     "name":"twilio",
     "description":"A Twilio helper library",
-    "version":"0.6.1",
+    "version":"0.6.2",
     "author":"Kevin Whinnery <[e-mail]>",
     "contributors":[
         {
+            "name":"Carter Rabasa",
+            "email":"[e-mail]"
+        },
+        {
             "name":"Stephen Walters",
@@ -9,0 +13,0 @@ "email":""

spec/client.accounts.spec.js

@@ -9,3 +9,3 @@ var config = require('../config'),
     it('gets an unfiltered list of Accounts associated with this master account', function (done) {
-        client.accounts.get(function (err, data, response) {
+        client.accounts.list(function (err, data, response) {
             expect(data.accounts.length).toBeGreaterThan(0);
@@ -12,0 +12,0 @@ done();

spec/client.applications.spec.js

@@ -30,3 +30,3 @@ var config = require('../config'),
     it('lists all apps with the friendly name we created (should be one)', function(done) {
-        client.applications.get({
+        client.applications.list({
             friendlyName:app.FriendlyName
@@ -33,0 +33,0 @@ }, function(err, data) {

spec/client.availablenumbers.spec.js

@@ -16,3 +16,3 @@ var config = require('../config'),
     it('gets a list of available phone numbers for a given country, with an area code filter', function (done) {
-        client.accounts.availablePhoneNumbers('US').local.get({
+        client.accounts.availablePhoneNumbers('US').local.list({
             areaCode:651
@@ -19,0 +19,0 @@ }, function (err, data) {

spec/client.calls.spec.js

@@ -51,3 +51,3 @@ var config = require('../config'),
     it('gets a list of calls for a specific number', function(done) {
-        client.calls.get({
+        client.calls.list({
             from:config.from
@@ -54,0 +54,0 @@ }, function(err, data) {

spec/client.connect.spec.js

@@ -11,3 +11,3 @@ var config = require('../config'),
     it('gets a list of all connect apps', function(done) {
-        client.accounts.connectApps.get(function(err, data) {
+        client.accounts.connectApps.list(function(err, data) {
             expect(data.connect_apps.length).toBeGreaterThan(0);
@@ -14,0 +14,0 @@ instanceSid = data.connect_apps[0].sid;

spec/client.incoming.spec.js

@@ -12,3 +12,3 @@ var config = require('../config'),
     it('gets a list of already purchased incoming phone numbers', function(done) {
-        client.accounts.incomingPhoneNumbers.get(function(err, data) {
+        client.accounts.incomingPhoneNumbers.list(function(err, data) {
             expect(data.incoming_phone_numbers.length).toBeGreaterThan(0);
@@ -15,0 +15,0 @@ instanceSid = data.incoming_phone_numbers[0].sid;

spec/client.outgoing.spec.js

@@ -24,3 +24,3 @@ var config = require('../config'),
     it('gets a list of verified caller IDs', function(done) {
-        client.accounts.outgoingCallerIds.get(function(err, data) {
+        client.accounts.outgoingCallerIds.list(function(err, data) {
             expect(data.outgoing_caller_ids.length).toBeGreaterThan(0);
@@ -27,0 +27,0 @@ instanceSid = data.outgoing_caller_ids[0].sid;

New alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Fixed alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

60993

3.24%

Number of package files

35

2.94%

Lines of code

1218

3.13%

No dependency changes