twitter-ads - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

History.md

 # History
 
+### 0.1.3
+Support for Node 0.10.x versions added.
+
 ## 0.1.2
@@ -4,0 +7,0 @@ Added support for Twitter TON API.

lib/helpers.js

@@ -13,3 +13,9 @@ var querystring = require('querystring'),
 helpers.makeQueryString = function(obj) {
-  return querystring.stringify(obj, null, null, {encodeURIComponent: fixedEncodeURIComponent});
+  let nodeVersionParts = process.versions.node.split('.');
+  
+  if (nodeVersionParts[1] === '10') { // Node <= 0.10.x version (No encodeURIComponent overriding) ...
+    return querystring.stringify(obj).replace(/[!'()*]/g, function(c) {
+      return '%' + c.charCodeAt(0).toString(16);
+    });
+  } else return querystring.stringify(obj, null, null, {encodeURIComponent: fixedEncodeURIComponent});
 };
@@ -16,0 +22,0 @@

lib/twitter_ads.js

@@ -51,10 +51,10 @@ var util = require('util'),
     
-    // Let's not change the params object user changes.
+    // Let's not change the params object user passes
     var paramsClone = JSON.parse(JSON.stringify(params)),
-        finalURL = Object.keys(paramsClone).length? helpers.moveParamsIntoPath(url, paramsClone) : url;
+        finalURL = Object.keys(paramsClone).length ? helpers.moveParamsIntoPath(url, paramsClone) : url;
 
     paramsClone = helpers.normalizeParams(paramsClone);
     request({
-      baseUrl: (self.config.sandbox? constants.API_SANDBOX_HOST : constants.API_HOST) + self.config.api_version + '/',
-      url: Object.keys(paramsClone).length? finalURL + '?' + helpers.makeQueryString(paramsClone) : finalURL,
+      baseUrl: (self.config.sandbox ? constants.API_SANDBOX_HOST : constants.API_HOST) + self.config.api_version + '/',
+      url: Object.keys(paramsClone).length ? finalURL + '?' + helpers.makeQueryString(paramsClone) : finalURL,
       method: type.toUpperCase(),
@@ -153,3 +153,3 @@ //useQuerystring: true,
       if (err) return cb(err);
-      if (resp.statusCode == 201) {
+      if (resp.statusCode === 201) {
         var urlPathForChunks = resp.headers.location;
@@ -187,3 +187,3 @@ var minChunkSize = Number(resp.headers['X-TON-Min-Chunk-Size'.toLowerCase()]);
       if (err) return cb(err);
-      if (resp.statusCode == 200) {
+      if (resp.statusCode === 200) {
         try {
@@ -190,0 +190,0 @@ fs.writeSync(fd, body, 0, 'utf-8');

package.json

 {
   "name": "twitter-ads",
   "description": "Twitter Ads API for NodeJS",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "author": "Talha Asad <[e-mail]>",
@@ -10,3 +10,3 @@ "license": "MIT",
   "engines": {
-    "node": ">=0.12.0"
+    "node": ">=0.10.0"
   },
@@ -13,0 +13,0 @@ "dependencies": {

No alert changes

Worsened metrics

Total package byte prevSize

16505

decreased by-1.39%

Number of package files

10

decreased by-9.09%

Lines of code

262

decreased by-3.32%

No dependency changes