ubivar - npm Package Compare versions

Comparing version 1.7.1 to 1.8.0

lib/index.js

@@ -13,2 +13,3 @@ /* Ubivar API client factory
     , {"name": "RouterData"             , "path": "router_data"}
+    , {"name": "RouterDataFeature"      , "path": "router_data_features"}
     , {"name": "RouterFlow"             , "path": "router_flows"}
@@ -15,0 +16,0 @@ , {"name": "RouterFlowBackup"       , "path": "router_flow_backups"}

package.json

 {
   "name"        : "ubivar",
-  "version"     : "1.7.1",
+  "version"     : "1.8.0",
   "description" : "API wrapper to Ubivar",
@@ -5,0 +5,0 @@ "main"        : "lib/index.js",

README.md

@@ -108,8 +108,9 @@ # Ubivar node.js bindings
 | **Settings**  | Auth, Credentials       |   |   |   |   |       | | 
-| **Router**    | Router                  |   | [`123`](https://ubivar.com/docs/nodejs#retrieve_router) |  |  | [`{}`](https://ubivar.com/docs/nodejs#list_router) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/Router/spec.js) | 
-|               | RouterParameter         |   | [`123`](https://ubivar.com/docs/nodejs#retrieve_routerparameter) | [`123, {}`](https://ubivar.com/docs/nodejs#update_routerparameter) |  | [`{}`](https://ubivar.com/docs/nodejs#list_routerparameter) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/RouterParameter/spec.js) | 
-|               | RouterData              |   | [`123`](https://ubivar.com/docs/nodejs#retrieve_routerdata) | [`123, {}`](https://ubivar.com/docs/nodejs#update_routerdata) |  | [`{}`](https://ubivar.com/docs/nodejs#list_routerdata) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/RouterData/spec.js) | 
+| **Router**    | Router                  |   | [`123`](https://ubivar.com/docs/nodejs#retrieve_router) |  |  |  | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/Router/spec.js) | 
+|               | RouterParameter         |   |   | [`123, {}`](https://ubivar.com/docs/nodejs#update_routerparameter) |  | [`{}`](https://ubivar.com/docs/nodejs#list_routerparameter) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/RouterParameter/spec.js) | 
+|               | RouterData              |   |   | [`123, {}`](https://ubivar.com/docs/nodejs#update_routerdata) |  | [`{}`](https://ubivar.com/docs/nodejs#list_routerdata) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/RouterData/spec.js) | 
+|               | RouterDataFeature       |   |   |   |   | [`{}`](https://ubivar.com/docs/nodejs#list_routerdatafeature) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/RouterDataFeature/spec.js) | 
 |               | RouterFlow              | [`{}`](https://ubivar.com/docs/nodejs#create_routerflow) |  | [`123, {}`](https://ubivar.com/docs/nodejs#update_routerflow) | [`{}`](https://ubivar.com/docs/nodejs#delete_routerflow) | [`{}`](https://ubivar.com/docs/nodejs#list_routerflow) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/RouterFlow/spec.js)| 
 |               | RouterFlowBackup        | [`{}`](https://ubivar.com/docs/nodejs#create_routerflowbackup) | [`{}`](https://ubivar.com/docs/nodejs#retrieve_routerflowbackup) |  | [`{}`](https://ubivar.com/docs/nodejs#delete_routerflowbackup) | [`{}`](https://ubivar.com/docs/nodejs#list_routerflowbackup) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/RouterFlowBackup/spec.js)| 
-|               | RouterTest              |   | [`123`](https://ubivar.com/docs/nodejs#retrieve_routertest) |  |  | [`{}`](https://ubivar.com/docs/nodejs#list_routertest) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/routertest/Resources/RouterTest/spec.js) | 
+|               | RouterTest              |   | - |  |  | - | - | 
 | **Event data**| Event                   | [`{}`](https://ubivar.com/docs/nodejs#create_event)| [`123`](https://ubivar.com/docs/nodejs#retrieve_event) | [`123, {}`](https://ubivar.com/docs/nodejs#update_event) | [`123`](https://ubivar.com/docs/nodejs#delete_event) | [`{}`](https://ubivar.com/docs/nodejs#list_event) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/Event/spec.js) | 
@@ -121,3 +122,3 @@ |               | EventNotification       |  | [`123`](https://ubivar.com/docs/nodejs#retrieve_eventnotification) |  |  | [`{}`](https://ubivar.com/docs/nodejs#list_eventnotification) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/EventNotification/spec.js)|
 |               | EventReview             | | [`123`](https://ubivar.com/docs/nodejs#retrieve_eventreview) | [`123, {}`](https://ubivar.com/docs/nodejs#update_eventreview) | [`123`](https://ubivar.com/docs/nodejs#delete_eventreview) | [`{}`](https://ubivar.com/docs/nodejs#list_eventreview) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/EventReview/spec.js)| 
-|  **Flow filters** | Filters        | | | [`123, {}`](https://ubivar.com/docs/nodejs#update_filters) |  | [`{}`](https://ubivar.com/docs/nodejs#list_filters) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/Filters/spec.js)| 
+|  **Flow filters** | Filter         | | | [`123, {}`](https://ubivar.com/docs/nodejs#update_filter) |  | [`{}`](https://ubivar.com/docs/nodejs#list_filter) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/Filter/spec.js)| 
 |               | FilterWhitelist        | [`{}`](https://ubivar.com/docs/nodejs#create_filterwhitelist)| | [`123, {}`](https://ubivar.com/docs/nodejs#update_filterwhitelist) | [`123`](https://ubivar.com/docs/nodejs#delete_filterwhitelist) | [`{}`](https://ubivar.com/docs/nodejs#list_filterwhitelist) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/FilterWhitelist/spec.js)| 
@@ -129,3 +130,3 @@ |               | FilterBlacklist        |   |  | [`123, {}`](https://ubivar.com/docs/nodejs#update_filterblacklist) |  | [`{}`](https://ubivar.com/docs/nodejs#list_filterblacklist) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/FilterBlacklist/spec.js)|
 |               | FilterScoringsDedicated |   |  | [`123, {}`](https://ubivar.com/docs/nodejs#update_filterscoringsdedicated) |  | [`{}`](https://ubivar.com/docs/nodejs#list_filterscoringsdedicated) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/FilterScoringsDedicated/spec.js)| 
-| **Flow notifiers**   | Notifiers | | | [`123, {}`](https://ubivar.com/docs/nodejs#update_notifiers) |  | [`{}`](https://ubivar.com/docs/nodejs#list_notifiers) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/Notifiers/spec.js)| 
+| **Flow notifiers**   | Notifier | | | [`123, {}`](https://ubivar.com/docs/nodejs#update_notifier) |  | [`{}`](https://ubivar.com/docs/nodejs#list_notifier) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/Notifier/spec.js)| 
 |                 | NotifierEmail      | [`{}`](https://ubivar.com/docs/nodejs#create_notifieremail)|  | [`123, {}`](https://ubivar.com/docs/nodejs#update_notifieremail) | [`123`](https://ubivar.com/docs/nodejs#delete_notifieremail) | [`{}`](https://ubivar.com/docs/nodejs#list_notifieremail) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/NotifierEmail/spec.js)| 
@@ -132,0 +133,0 @@ |               | NotifierSms             | [`{}`](https://ubivar.com/docs/nodejs#create_notifiersms)|  | [`123, {}`](https://ubivar.com/docs/nodejs#update_notifiersms) | [`123`](https://ubivar.com/docs/nodejs#delete_notifiersms) | [`{}`](https://ubivar.com/docs/nodejs#list_notifiersms) | [See on github](https://github.com/ubivar/ubivar-node/blob/master/test/Resources/NotifierSms/spec.js)|

test/Resources/EventQueue/spec.js

@@ -88,7 +88,16 @@ var _                 = require("lodash")
       ubivar["EventQueue"].list(function(err, res){
-        if(!err && res.data.length === 3 && _.contains(_.keys(res.data[0]), "queues")) {
+        if(err){
+          console.log(err, res)
+          done(new Error("Should have no error")) 
+        } else if(res.data.length !== 1){
+          console.log(res)
+          done(new Error("Should return only one element for this dataset")) 
+        } else if(!_.contains(_.keys(res.data[0]), "queue")){
+          console.log(res)
+          done(new Error("Should have an attribute named 'queue' in 'data'")) 
+        } else if(!_.contains(_.keys(res), "summary")){
+          console.log(res)
+          done(new Error("Should have an attribute named 'summary'")) 
+        } else {
           done()
-        } else {
-          console.log(res)
-          done(new Error("Should have only one returned element")) 
         }
@@ -95,0 +104,0 @@ })

test/Resources/EventReview/spec.js

@@ -49,13 +49,20 @@ var _                 = require("lodash")
     it("Should create", function(done){
+      var now       = (new Date()).toISOString().slice(0,16)
       ubivar["EventReview"].update(idResource
-      , {"message": "a review", "reviewer_id": "123"}
+      , {"message": now, "reviewer_id": "123"}
       , function(err, res){
-        if(err){ done(new Error("Did not create")) }
-
-        var review  = res.data[0].reviews.reverse()[0]
-        if(!err && res.data.length === 1 && review.reviewer_id === "123" && review.message === "a review"){
-          done()
-        } else {
+        if(err){ 
           console.log(err, res)
-          done(new Error("Did not create"))
+          done(new Error("Did not create (err)")) 
+        } else if(res.data.length <= 0){
+          console.log(res)
+          done(new Error("Did not create (empty result)")) 
+        } else  {
+          var reviews = res.data.reverse()
+          if(reviews[0].review.message !== now){
+            console.log(json)
+            done(new Error("Did not create (now !=)"))
+          } else {
+            done()
+          }
         }
@@ -66,9 +73,10 @@ })
     it("Should update", function(done){
+      var reviewId  = 0
       ubivar["EventReview"].update(idResource
-      , {"review_id": 0, "reviewer_id": "124"}
+      , {"review_id": reviewId, "reviewer_id": "124"}
       , function(err, res){
         if(err){ done(new Error("Did not create")) }
 
-        var reviews = res.data[0].reviews
-        if(!err && res.data.length === 1 && reviews[0].reviewer_id === "124"){
+        var reviews = res.data
+        if(!err && reviews[reviewId].review.reviewer_id === "124"){
           done()
@@ -83,9 +91,14 @@ } else {
     it("Should update", function(done){
+      var reviewId  = 0
       ubivar["EventReview"].update(idResource
-      , {"review_id": 0, "reviewer_id": "123"}
+      , {"review_id": reviewId, "reviewer_id": "123"}
       , function(err, res){
-        if(err){ done(new Error("Did not create")) }
+        if(err){ 
+          console.log(err, res)
+          done(new Error("Did not create")) 
+        }
 
-        var reviews = res.data[0].reviews
-        if(!err && res.data.length === 1 && reviews[0].reviewer_id === "123"){
+        var reviews = res.data
+        
+        if(!err && reviews[reviewId].review.reviewer_id === "123"){
           done()
@@ -100,19 +113,17 @@ } else {
     it("Should delete", function(done){
-      ubivar["EventReview"].del(idResource
-      , {"review_id": 0}
-      , function(err, res){
-        if(err){ done(new Error("Did not create")) }
-
-        var reviews = res.data[0].reviews
-        if(!err && res.data.length === 1){
-          ubivar["EventReview"].update(idResource
-          , {"reviewer_id": "123", "message": "a review"}
-          , function(err, res){
-            if(err){return done(new Error("Failed to re-create after delete"))}
-            done()
-          })
-        } else {
-          console.log(err, res)
-          done(new Error("Did not update"))
-        }
+      ubivar["EventReview"].retrieve(idResource, function(err, res){
+        var nReviews = res.data.length
+        ubivar["EventReview"].del(idResource
+        , {"review_id": 0}
+        , function(err, res){
+          if(err){ 
+            console.log(err, res)
+            return done(new Error("Did not delete")) 
+          } else if(res.data.length === nReviews - 1){
+            return done()
+          } else {
+            console.log(res.data.length, nReviews)
+            done(new Error("Did not delete"))
+          }
+        })
       })
@@ -119,0 +130,0 @@ })

test/Resources/Router/spec.js

@@ -38,17 +38,3 @@ var _                 = require("lodash")
     })
-
-    it("Should list", function(done){
-      ubivar["Router"].list(function(err, res){
-        if(err) {
-          console.log(err, res)
-          done(new Error("Did not list")) 
-        } else if(!err && res.data.length === 1) {
-          done()
-        } else {
-          console.log(res)
-          done(new Error("Should have only one returned element")) 
-        }
-      })
-    })
   })
 })

test/Resources/RouterFlow/spec.js

@@ -29,3 +29,2 @@ var _                 = require("lodash")
   describe("Methods", function(){
-
     it("Should create and delete RouterFlow", function(done){ 
@@ -59,6 +58,8 @@ ubivar["RouterFlow"].list(function(err, res){
       , function(err, res){
-        if(err){ return done(new Error("Did not update")) }
+        if(err){ 
+          return done(new Error("Did not update")) 
+        }
 
-        var rule = res.data[ruleId]
-        if(rule.is_active === "true"){
+        var flow = res.data
+        if(flow.is_active === "true"){
           // roll back
@@ -65,0 +66,0 @@ ubivar["RouterFlow"].update(ruleId

test/Resources/RouterTest/spec.js

@@ -28,2 +28,41 @@ var _                 = require("lodash")
   describe("Methods", function(){
+    it("Should update", function(done){
+      var now1        = (new Date()).toISOString().slice(0,16) + "_abc"
+        , now2        = (new Date()).toISOString().slice(0,16) + "_def"
+        , ssize       = parseInt(Math.random() * 1000)
+      ubivar["RouterTest"].update(0, {
+        "query_target": now1
+      , "query_base"  : now2
+      , "from"        : "filter_rules_base"
+      , "to"          : "notifier_emails"
+      , "sample_size" : ssize
+      , "use_cache"   : "true"
+      }, function(err, res){
+        if(err) {
+          console.log(err, res)
+          done(err) 
+        } else if(now1 !== res.data.query_target) {
+          done(new Error("Failed to update (query_target)"))
+        } else if(now2 !== res.data.query_base) {
+          done(new Error("Failed to update (query_base)"))
+        } else if(ssize !== res.data.sample_size) {
+          done(new Error("Failed to update (sample_size)"))
+        } else {
+          done()
+        }
+      })
+    })
+
+    it("Should create", function(done){
+      var disregarded = {}
+      ubivar["RouterTest"].create(disregarded, function(err, res){
+        if(err){
+          console.log(err, res)
+          done(err)
+        } else {
+          done()
+        }
+      })
+    })
+
     it("Should list", function(done){
@@ -33,3 +72,3 @@ ubivar["RouterTest"].list(function(err, res){
           console.log(err, res)
-          done(new Error("Did not list")) 
+          done(err) 
         } else {
@@ -36,0 +75,0 @@ done()

No alert changes

Improved metrics

Total package byte prevSize

112510

increased by2.44%

Number of package files

50

increased by2.04%

Lines of code

2570

increased by3.34%

Number of lines in readme file

191

increased by0.53%

No dependency changes