view-list - npm Package Compare versions

Comparing version 1.1.0 to 1.2.0

package.json

 {
   "name": "view-list",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "",
@@ -5,0 +5,0 @@ "main": "index.js",

view-list.js

@@ -7,10 +7,11 @@ var h = require('virtual-dom/h')
   var self = this
-  Object.defineProperty(this, 'height', {
-    get: function() {
-      return this.style.height || 0
-    },
-    set: function(val) {
-      this.style.height = val || 0
-    }
-  })
+
+  // Calculate height outside of the style.height
+  function OnHeight() {}
+  OnHeight.prototype.hook = function(node) {
+    setTimeout(function() {
+      self.height = node.offsetHeight
+    }, 10)
+  }
+
   xtend(this, {
@@ -20,3 +21,3 @@ tagName: 'ul',
     className: 'view-list',
-    data: [],
+    onHeight: new OnHeight(),
     onscroll: function () {
@@ -32,7 +33,4 @@ self._scrollTop = this.scrollTop
     },
+    height: 500,
     rowHeight: 30,
-    style: {
-      height: 500,
-      overflow: 'auto'
-    },
     _scrollTop: 0,
@@ -39,0 +37,0 @@ _visibleStart: 0,

No alert changes

Improved metrics

Total package byte prevSize

6239

increased by0.5%

Worsened metrics

Lines of code

147

decreased by-1.34%

No dependency changes