vinyl - npm Package Compare versions

Comparing version 0.2.3 to 0.3.0

index.js

 var path = require('path');
 
 var cloneStats = require('clone-stats');
+var cloneDeep = require('lodash.clonedeep');
 
@@ -46,12 +47,14 @@ var isBuffer = require('./lib/isBuffer');
 File.prototype.clone = function() {
-  var clonedContents = this.isBuffer() ? cloneBuffer(this.contents) : this.contents;
-  var clonedStat = this.stat ? cloneStats(this.stat) : null;
+  var clone = new File();
 
-  return new File({
-    cwd: this.cwd,
-    base: this.base,
-    path: this.path,
-    stat: clonedStat,
-    contents: clonedContents
-  });
+  Object.keys(this).forEach(function(key) {
+    if (key !== '_contents' && key !== 'stat') {
+      clone[key] = cloneDeep(this[key]);
+    }
+  }, this);
+
+  clone.contents = this.isBuffer() ? cloneBuffer(this.contents) : this.contents;
+  clone.stat = this.stat ? cloneStats(this.stat) : null;
+
+  return clone;
 };
@@ -78,4 +81,2 @@
   }
-
-  return stream;
 };
@@ -82,0 +83,0 @@

package.json

 {
   "name": "vinyl",
   "description": "A virtual file format",
-  "version": "0.2.3",
+  "version": "0.3.0",
   "homepage": "http://github.com/wearefractal/vinyl",
@@ -10,3 +10,4 @@ "repository": "git://github.com/wearefractal/vinyl.git",
   "dependencies": {
-    "clone-stats": "~0.0.1"
+    "clone-stats": "~0.0.1",
+    "lodash.clonedeep": "^2.4.1"
   },
@@ -13,0 +14,0 @@ "devDependencies": {

README.md

@@ -28,3 +28,3 @@ # vinyl [![NPM version][npm-image]][npm-url] [![Build Status][travis-image]][travis-url] [![Coveralls Status][coveralls-image]][coveralls-url] [![Dependency Status](https://david-dm.org/wearefractal/vinyl.png?theme=shields.io)](https://david-dm.org/wearefractal/vinyl)
   base: "/test/",
-  path: "/test/file.coffee"
+  path: "/test/file.coffee",
   contents: new Buffer("test = 123")
@@ -83,3 +83,3 @@ });
 
-Returns a new File object with all attributes cloned.
+Returns a new File object with all attributes cloned. Custom attributes are deep-cloned.
 
@@ -94,3 +94,3 @@ ### pipe(stream[, opt])
 
-If opt.end is true, the destination stream will not be ended (same as node core).
+If opt.end is false, the destination stream will not be ended (same as node core).
 
@@ -126,2 +126,2 @@ Returns the stream.
 [depstat-url]: https://david-dm.org/wearefractal/vinyl
-[depstat-image]: https://david-dm.org/wearefractal/vinyl.png
+[depstat-image]: https://david-dm.org/wearefractal/vinyl.png

test/File.js

 var File = require('../');
 var Stream = require('stream');
 var fs = require('fs');
+var path = require('path');
 
@@ -253,2 +254,25 @@ var should = require('should');
     });
+  
+    it('should copy custom properties', function(done) {
+      var options = {
+        cwd: "/",
+        base: "/test/",
+        path: "/test/test.coffee",
+        contents: null
+      };
+
+      var file = new File(options);
+      file.custom = { a: 'custom property' };
+
+      var file2 = file.clone();
+
+      file2.should.not.equal(file, 'refs should be different');
+      file2.cwd.should.equal(file.cwd);
+      file2.base.should.equal(file.base);
+      file2.path.should.equal(file.path);
+      file2.custom.should.not.equal(file.custom);
+      file2.custom.a.should.equal(file.custom.a);
+
+      done();
+    });
   });
@@ -536,3 +560,3 @@
       });
-      file.relative.should.equal("test/test.coffee");
+      file.relative.should.equal(path.join("test","test.coffee"));
       done();
@@ -539,0 +563,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

29606

increased by2.78%

Lines of code

758

increased by2.57%

Number of lines in readme file

124

increased by0.81%

Worsened metrics

Dependency count

2

increased by100%

Dependency changes

• + Addedlodash.clonedeep@^2.4.1

• + Addedlodash._arraypool@2.4.1(transitive)

• + Addedlodash._basebind@2.4.1(transitive)

• + Addedlodash._baseclone@2.4.1(transitive)

• + Addedlodash._basecreate@2.4.1(transitive)

• + Addedlodash._basecreatecallback@2.4.1(transitive)

• + Addedlodash._basecreatewrapper@2.4.1(transitive)

• + Addedlodash._createwrapper@2.4.1(transitive)

• + Addedlodash._getarray@2.4.1(transitive)

• + Addedlodash._isnative@2.4.1(transitive)

• + Addedlodash._maxpoolsize@2.4.1(transitive)

• + Addedlodash._objecttypes@2.4.1(transitive)

• + Addedlodash._releasearray@2.4.1(transitive)

• + Addedlodash._setbinddata@2.4.1(transitive)

• + Addedlodash._shimkeys@2.4.1(transitive)

• + Addedlodash._slice@2.4.1(transitive)

• + Addedlodash.assign@2.4.1(transitive)

• + Addedlodash.bind@2.4.1(transitive)

• + Addedlodash.clonedeep@2.4.1(transitive)

• + Addedlodash.foreach@2.4.1(transitive)

• + Addedlodash.forown@2.4.1(transitive)

• + Addedlodash.identity@2.4.1(transitive)

• + Addedlodash.isarray@2.4.1(transitive)

• + Addedlodash.isfunction@2.4.1(transitive)

• + Addedlodash.isobject@2.4.1(transitive)

• + Addedlodash.keys@2.4.1(transitive)

• + Addedlodash.noop@2.4.1(transitive)

• + Addedlodash.support@2.4.1(transitive)