w3wconverter - npm Package Compare versions

Comparing version 1.0.222 to 2.0.0

package.json

 {
   "name": "w3wconverter",
-  "version": "1.0.222",
+  "version": "2.0.0",
   "description": "Coverts postcodes to lat-long coordinates via Google Places API, then into What3Words addresses.",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "jest"
   },
@@ -29,3 +29,6 @@ "repository": {
     "neat-csv": "^6.0.1"
+  },
+  "devDependencies": {
+    "jest": "^27.1.1"
   }
 }

src/lib/w3wc.js

@@ -23,2 +23,3 @@ /**** W3WConverter turns a postcode into a set of lat-long coordinates via the Google Places API
 const WriteNewCsvFile = require('./write-new-csv-file');
+const WebResponseV2 = require('./web-response-v2');
 
@@ -61,5 +62,24 @@ class W3WConverter {
 
+    countRows(postcodesArr) {
+        let numberOfRows = 0;
+        postcodesArr.forEach(e => {
+            numberOfRows++;
+        });
+        return numberOfRows;
+    }
+
+    webResponseV2(informationArr) {
+        const response = WebResponseV2;
+        response.numberOfRows = informationArr['rows'];
+        return response;
+    }
+
+
     async convertData() {
         console.log('Converting data...');
         const postcodes = await this.getPostcodes();
+        const numberOfRows = this.countRows(postcodes);
+        const informationArr = [];
+        informationArr['rows'] = numberOfRows;
+        const response = this.webResponseV2(informationArr);
 
@@ -89,3 +109,6 @@ for(let i = 0; i < postcodes.length; i++) {
         this.writeNewCsvFile();
-        return this.giveWebResponse();
+        //return this.giveWebResponse();
+
+
+        return response;
         
@@ -92,0 +115,0 @@ }

Fixed alerts

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

48531

increased by4.15%

Number of package files

13

increased by18.18%

Lines of code

323

increased by15.77%

Number of low quality alerts

1

decreased by-50%

Worsened metrics

Dev dependency count

1

increased byInfinity%

No dependency changes