watch - npm Package Compare versions

Comparing version 0.8.0 to 0.9.0

main.js

@@ -50,3 +50,3 @@ // Copyright 2010-2011 Mikeal Rogers
             if (options.ignoreDotFiles && path.basename(f)[0] === '.') return done && callback(null, callback.files);
-            if (options.filter && options.filter(f, stat)) return done && callback(null, callback.files);
+            if (options.filter && !options.filter(f, stat)) return done && callback(null, callback.files);
             callback.files[f] = stat;
@@ -108,2 +108,4 @@ if (stat.isDirectory()) walk(f, options, callback);
   var monitor = new events.EventEmitter();
+
+  var prevFile = {file: null,action: null};
   exports.watchTree(root, options, function (f, curr, prev) {
@@ -114,9 +116,15 @@ if (typeof f == "object" && prev == null && curr === null) {
     }
-    if (prev === null) {
+    if (prev === null && (prevFile.file != f || prevFile.action != "created")) {
+      prevFile = { file: f, action: "created" };
       return monitor.emit("created", f, curr);
     }
-    if (curr.nlink === 0) {
+    if (curr.nlink === 0 && (prevFile.file != f || prevFile.action != "removed")) {
+      prevFile = { file: f, action: "removed" };
       return monitor.emit("removed", f, curr);
     }
-    monitor.emit("changed", f, curr, prev);
+    if (prevFile.file != null) {
+      prevFile = {file: null,action: null};
+    } else {
+      monitor.emit("changed", f, curr, prev);
+    }
   })
@@ -123,0 +131,0 @@ }

package.json

@@ -10,3 +10,3 @@ {
   ],
-  "version": "0.8.0",
+  "version": "0.9.0",
   "homepage": "https://github.com/mikeal/watch",
@@ -13,0 +13,0 @@ "bugs": {

test/test_watchTree.js

@@ -1,9 +0,20 @@
-var watch = require('../main')
+var fs = require('fs')
+  , watch = require('../main')
   , assert = require('assert')
   ;
 
-watch.watchTree(__dirname, function (f, curr, prev) {
-  // console.log('file '+f+' prev '+prev+' curr '+curr);
-  // console.dir(curr)
-  // console.dir(prev)
-});
+//
+// Demonstrate that the function of 'filter' is semantically inconsistent with
+// usual convention, that returning true means 'keep this'.
+//
+function isDirOrQ(f, stat) { return stat.isDirectory() || f === 'Q'; }
+
+watch.watchTree(__dirname, { filter: isDirOrQ }, function (f, curr, prev) {
+  if (typeof f == 'object' && prev === null && curr === null) {
+    Object.keys(f).forEach(function(name) {
+      var stat = f[name];
+      assert(isDirOrQ(name, stat));
+      fs.unwatchFile(name);
+    });
+  }
+});

No alert changes

Improved metrics

Total package byte prevSize

19105

increased by8.96%

Number of package files

9

increased by12.5%

Lines of code

192

increased by28.86%

Worsened metrics

Number of low supply chain risk alerts

4

increased by100%

No dependency changes