waterline - npm Package Compare versions

Comparing version 0.14.0-3 to 0.14.0-4

ARCHITECTURE.md

@@ -10,3 +10,7 @@ # How Waterline Works
 
+#### Computational complexity of various kinds of association mutations
 
+[Link, tweeze, & splice performance for associations in Waterline ≥0.13 (by # of native queries)](https://twitter.com/mikermcneil/status/792179005348655104)
+
+
 ## Overview: Talking to the database
@@ -13,0 +17,0 @@

lib/waterline/methods/find-one.js

@@ -275,3 +275,5 @@ /**
               message:
-              'More than one matching record found for `.findOne()`:\n'+
+              'More than one matching record found for `'+
+              modelIdentity[0].toUpperCase()+modelIdentity.substring(1)+
+              '.findOne()`:\n'+
               '···\n'+
@@ -278,0 +280,0 @@ _.pluck(populatedRecords, WLModel.primaryKey)+'\n'+

lib/waterline/utils/query/forge-adapter-error.js

@@ -255,3 +255,38 @@ /**
 
+        //  ███╗   ██╗ ██████╗     ███████╗██╗   ██╗ ██████╗██╗  ██╗
+        //  ████╗  ██║██╔═══██╗    ██╔════╝██║   ██║██╔════╝██║  ██║
+        //  ██╔██╗ ██║██║   ██║    ███████╗██║   ██║██║     ███████║
+        //  ██║╚██╗██║██║   ██║    ╚════██║██║   ██║██║     ██╔══██║
+        //  ██║ ╚████║╚██████╔╝    ███████║╚██████╔╝╚██████╗██║  ██║
+        //  ╚═╝  ╚═══╝ ╚═════╝     ╚══════╝ ╚═════╝  ╚═════╝╚═╝  ╚═╝
+        //
+        //  ██████╗ ██╗  ██╗██╗   ██╗███████╗██╗ ██████╗ █████╗ ██╗
+        //  ██╔══██╗██║  ██║╚██╗ ██╔╝██╔════╝██║██╔════╝██╔══██╗██║
+        //  ██████╔╝███████║ ╚████╔╝ ███████╗██║██║     ███████║██║
+        //  ██╔═══╝ ██╔══██║  ╚██╔╝  ╚════██║██║██║     ██╔══██║██║
+        //  ██║     ██║  ██║   ██║   ███████║██║╚██████╗██║  ██║███████╗
+        //  ╚═╝     ╚═╝  ╚═╝   ╚═╝   ╚══════╝╚═╝ ╚═════╝╚═╝  ╚═╝╚══════╝
+        //
+        //  ███╗   ███╗ ██████╗ ██████╗ ███████╗██╗
+        //  ████╗ ████║██╔═══██╗██╔══██╗██╔════╝██║
+        //  ██╔████╔██║██║   ██║██║  ██║█████╗  ██║
+        //  ██║╚██╔╝██║██║   ██║██║  ██║██╔══╝  ██║
+        //  ██║ ╚═╝ ██║╚██████╔╝██████╔╝███████╗███████╗
+        //  ╚═╝     ╚═╝ ╚═════╝ ╚═════╝ ╚══════╝╚══════╝
+        //
+        case 'noSuchPhysicalModel': return (function(){
+          return {
+            message: 'Database says there is no such table/collection/etc.  '+err.message,
+            code: 'E_NO_SUCH_PHYSICAL_MODEL',
+            toJSON: function (){
+              return {
+                code: this.code,
+                message: this.message,
+                modelIdentity: this.modelIdentity,
+              };
+            }
+          };
+        })();
 
+
         //   ██████╗ █████╗ ████████╗ ██████╗██╗  ██╗ █████╗ ██╗     ██╗
@@ -266,5 +301,3 @@ //  ██╔════╝██╔══██╗╚══██╔══╝██╔════╝██║  ██║██╔══██╗██║     ██║
           return {
-
             message: 'Unexpected error from database adapter: '+err.message
-
           };
@@ -271,0 +304,0 @@ })();

lib/waterline/utils/query/private/normalize-criteria.js

@@ -242,2 +242,5 @@ /**
       '\n'+
+      'Alternatively, if you are using `groupBy` as a column/attribute name then '+
+      'please be advised that some things won\'t work as expected.\n'+
+      '\n'+
       'For more info, visit:\n'+
@@ -269,2 +272,5 @@ 'http://sailsjs.com/docs/upgrading/to-v1.0'
       '```\n'+
+      'Alternatively, if you are using `sum` as a column/attribute name then '+
+      'please be advised that some things won\'t work as expected.\n'+
+      '\n'+
       'For more info, see:\n'+
@@ -293,2 +299,5 @@ 'http://sailsjs.com/docs/reference/waterline-orm/models/sum'
       '```\n'+
+      'Alternatively, if you are using `average` as a column/attribute name then '+
+      'please be advised that some things won\'t work as expected.\n'+
+      '\n'+
       'For more info, see:\n'+
@@ -328,2 +337,5 @@ 'http://sailsjs.com/docs/reference/waterline-orm/models/avg'
       '```\n'+
+      'Alternatively, if you are using `min` as a column/attribute name then '+
+      'please be advised that some things won\'t work as expected.\n'+
+      '\n'+
       'For more info, see:\n'+
@@ -363,2 +375,5 @@ 'http://sailsjs.com/docs/reference/waterline-orm/models/find'
       '```\n'+
+      'Alternatively, if you are using `max` as a column/attribute name then '+
+      'please be advised that some things won\'t work as expected.\n'+
+      '\n'+
       'For more info, see:\n'+
@@ -365,0 +380,0 @@ 'http://sailsjs.com/docs/reference/waterline-orm/models/find'

lib/waterline/utils/system/transformer-builder.js

@@ -136,3 +136,3 @@ /**
 
-  // Recursivly parse attributes to handle nested criteria
+  // Recursively parse attributes to handle nested criteria
   recursiveParse(values);
@@ -139,0 +139,0 @@

package.json

 {
   "name": "waterline",
   "description": "An ORM for Node.js and the Sails framework",
-  "version": "0.14.0-3",
+  "version": "0.14.0-4",
   "homepage": "http://waterlinejs.org",
@@ -6,0 +6,0 @@ "contributors": [

test/unit/query/query.createEach.js

@@ -108,3 +108,3 @@ var assert = require('assert');
           assert(_.isArray(values));
-          assert.notEqual(values[0].arr !== values[1].arr);
+          assert.notEqual(values[0].arr, values[1].arr);
 
@@ -111,0 +111,0 @@ // Add an item to one array

No alert changes

Improved metrics

Total package byte prevSize

1291538

increased by0.11%

Lines of code

22416

increased by0.23%

Worsened metrics

Number of package files

140

decreased by-0.71%

No dependency changes