web3-core - npm Package Compare versions

Comparing version 1.0.0-beta.14 to 1.0.0-beta.15

package.json

 {
     "name": "web3-core",
-    "version": "1.0.0-beta.14",
+    "version": "1.0.0-beta.15",
     "description": "Web3 core tools for sub packages. This is an internal package.",
@@ -9,7 +9,7 @@ "repository": "https://github.com/ethereum/web3.js/tree/master/packages/web3-core",
     "dependencies": {
-        "web3-core-helpers": "^1.0.0-beta.14",
-        "web3-core-method": "^1.0.0-beta.14",
-        "web3-requestmanager": "^1.0.0-beta.14",
-        "web3-utils": "^1.0.0-beta.14"
+        "web3-core-helpers": "^1.0.0-beta.15",
+        "web3-core-method": "^1.0.0-beta.15",
+        "web3-core-requestmanager": "^1.0.0-beta.15",
+        "web3-utils": "^1.0.0-beta.15"
     }
 }

src/index.js

@@ -26,3 +26,3 @@ /*
 
-var requestManager = require('web3-requestmanager');
+var requestManager = require('web3-core-requestmanager');
 var extend = require('./extend.js');
@@ -38,7 +38,4 @@
 
-        // if (!args[0]) {
-        //     throw new Error('You must pass in a provider as argument!');
-        // }
 
-        // make write only property of pkg.provider
+        // make property of pkg._provider, which can properly set providers
         Object.defineProperty(pkg, 'currentProvider', {
@@ -48,6 +45,7 @@ get: function () {
             },
-            set: function () {
-                return pkg._provider;
+            set: function (value) {
+                return pkg.setProvider(value);
             },
-            enumerable: true
+            enumerable: true,
+            configurable: true
         });
@@ -71,8 +69,10 @@
 
-        // add SETPROVIDER function
-        pkg.setProvider = function (provider, net) {
-            pkg._requestManager.setProvider(provider, net);
-            pkg._provider = pkg._requestManager.provider;
-            return true;
-        };
+        // add SETPROVIDER function (don't overwrite if already existing)
+        if (!pkg.setProvider) {
+            pkg.setProvider = function (provider, net) {
+                pkg._requestManager.setProvider(provider, net);
+                pkg._provider = pkg._requestManager.provider;
+                return true;
+            };
+        }
 
@@ -79,0 +79,0 @@ // attach batch request creation

No alert changes

Improved metrics

Total package byte prevSize

5790

increased by1.12%

Worsened metrics

Published versions last months

27

decreased by-3.57%

Dependency changes

• + Addedweb3-core-requestmanager@^1.0.0-beta.15

• + Addedavailable-typed-arrays@1.0.7(transitive)

• + Addedcall-bind@1.0.7(transitive)

• + Addeddefine-data-property@1.1.4(transitive)

• + Addedes-define-property@1.0.0(transitive)

• + Addedes-errors@1.3.0(transitive)

• + Addedfor-each@0.3.3(transitive)

• + Addedfunction-bind@1.1.2(transitive)

• + Addedget-intrinsic@1.2.4(transitive)

• + Addedgopd@1.0.1(transitive)

• + Addedhas-property-descriptors@1.0.2(transitive)

• + Addedhas-proto@1.0.3(transitive)

• + Addedhas-symbols@1.0.3(transitive)

• + Addedhas-tostringtag@1.0.2(transitive)

• + Addedhasown@2.0.2(transitive)

• + Addedis-arguments@1.1.1(transitive)

• + Addedis-callable@1.2.7(transitive)

• + Addedis-generator-function@1.0.10(transitive)

• + Addedis-typed-array@1.1.13(transitive)

• + Addedpossible-typed-array-names@1.0.0(transitive)

• + Addedset-function-length@1.2.2(transitive)

• + Addedutil@0.12.5(transitive)

• + Addedweb3-core-requestmanager@1.10.4(transitive)

• + Addedwhich-typed-array@1.1.15(transitive)

• - Removedweb3-requestmanager@^1.0.0-beta.14

• - Removedunderscore@1.8.3(transitive)

• - Removedweb3-requestmanager@1.0.0-beta.14(transitive)

• Updatedweb3-core-helpers@^1.0.0-beta.15

• Updatedweb3-core-method@^1.0.0-beta.15

• Updatedweb3-utils@^1.0.0-beta.15