webpack-build-notifier - npm Package Compare versions

Comparing version 0.1.29 to 0.1.30

CHANGELOG.md

 # Changelog
 
+#### 0.1.30
+###### _October 7, 2018_
+
+- Fix for [#29](/../../issues/29) where error occurs on Windows 7 when attempting to register the SnoreToast app ID for notifications.
+
 #### 0.1.29
@@ -4,0 +9,0 @@ ###### _August 21, 2018_

index.js

@@ -14,23 +14,30 @@ /**
 // ensure the SnoreToast appId is registered, which is needed for Windows Toast notifications
-// this is necessary post Windows build 1709, where all notifications must be generated by a valid application.
+// this is necessary in Windows 8 and above, (Windows 10 post build 1709), where all notifications must be generated
+// by a valid application.
 // see: https://github.com/KDE/snoretoast, https://github.com/RoccoC/webpack-build-notifier/issues/20
 var appName;
 if (process.platform === 'win32') {
-    var cp = require('child_process');
-    var snoreToast = path.join(require.resolve('node-notifier'), '../vendor/snoreToast/SnoreToast.exe');
-    try {
-        cp.execFileSync(
-            snoreToast,
-            [
-                '-appID',
-                'Snore.DesktopToasts',
-                '-install',
-                'SnoreToast.lnk',
+    var os = require('os');
+    var versionParts = os.release().split('.');
+    var winVer = +(`${versionParts[0]}.${versionParts[1]}`)
+    if (winVer >= 6.2) {
+        // Windows version >= 8
+        var cp = require('child_process');
+        var snoreToast = path.join(require.resolve('node-notifier'), '../vendor/snoreToast/SnoreToast.exe');
+        try {
+            cp.execFileSync(
                 snoreToast,
-                'Snore.DesktopToasts'
-            ]
-        );
-        appName = 'Snore.DesktopToasts';
-    } catch(e) {
-        console.error("An error occurred while attempting to install the SnoreToast AppID!", e);
+                [
+                    '-appID',
+                    'Snore.DesktopToasts',
+                    '-install',
+                    'SnoreToast.lnk',
+                    snoreToast,
+                    'Snore.DesktopToasts'
+                ]
+            );
+            appName = 'Snore.DesktopToasts';
+        } catch(e) {
+            console.error("An error occurred while attempting to install the SnoreToast AppID!", e);
+        }
     }
@@ -37,0 +44,0 @@ }

package.json

 {
   "name": "webpack-build-notifier",
-  "version": "0.1.29",
+  "version": "0.1.30",
   "description": "A Webpack plugin that generates OS notifications for build steps using node-notifier.",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Improved metrics

Total package byte prevSize

102643

increased by0.45%

Lines of code

271

increased by2.65%

No dependency changes