webvr-libs - npm Package Compare versions

Comparing version 1.0.10 to 1.0.11

package.json

 {
   "name": "webvr-libs",
-  "version": "1.0.10",
+  "version": "1.0.11",
   "description": "WebVR libraries",
@@ -5,0 +5,0 @@ "keywords": [

VREffect.js

@@ -15,3 +15,3 @@ /**
 	var vrHMD;
-	var deprecatedAPI = false;
+	var deprecatedAPI = 'getVRDevices' in navigator;
 	var eyeTranslationL = new THREE.Vector3();
@@ -29,3 +29,2 @@ var eyeTranslationR = new THREE.Vector3();
 				vrHMD = devices[ i ];
-				deprecatedAPI = false;
 				break; // We keep the first we encounter
@@ -36,3 +35,2 @@
 				vrHMD = devices[ i ];
-				deprecatedAPI = true;
 				break; // We keep the first we encounter
@@ -49,3 +47,2 @@
 		}
-
 	}
@@ -74,3 +71,3 @@
 
-	// fullscreen
+	// fullscreen / VR mode
 
@@ -80,10 +77,37 @@ var isPresenting = false;
 	var canvas = renderer.domElement;
-	var fullscreenchange = canvas.mozRequestFullScreen ? 'mozfullscreenchange' : 'webkitfullscreenchange';
+	var deprecatedAPIMethod;
+	var fullscreenchange;
+	var fullscreenElement;
 
-	document.addEventListener( fullscreenchange, function () {
+	if ( canvas.requestFullscreen ) {
 
-		if ( vrHMD && deprecatedAPI ) {
+		deprecatedAPIMethod = 'requestFullscreen';
+		fullscreenchange = 'fullscreenchange';
+		fullscreenElement = 'fullscreenElement';
 
-			isPresenting = document.mozFullScreenElement || document.webkitFullscreenElement;
+	} else if ( canvas.mozRequestFullScreen ) {
 
+		deprecatedAPIMethod = 'mozRequestFullScreen';
+		fullscreenchange = 'mozfullscreenchange';
+		fullscreenElement = 'mozFullScreenElement';
+
+	} else if ( canvas.webkitRequestFullscreen ) {
+
+		deprecatedAPIMethod = 'webkitRequestFullscreen';
+		fullscreenchange = 'webkitfullscreenchange';
+		fullscreenElement = 'webkitFullscreenElement';
+
+	} else if ( canvas.msRequestFullscreen ) {
+
+		fullscreenchange = 'msfullscreenchange';
+		fullscreenElement = 'msFullscreenElement';
+
+	}
+
+	document.addEventListener( fullscreenchange, function (e) {
+
+		if ( fullscreenchange && deprecatedAPI ) {
+
+			isPresenting = document[fullscreenElement] === canvas;
+
 		}
@@ -93,2 +117,9 @@
 
+	if ( !fullscreenchange ) {
+
+		// Assume we are presenting for browsers that don't yet support the Fullscreen API (e.g., Safari/IE10).
+		isPresenting = true;
+
+	}
+
 	window.addEventListener( 'vrdisplaypresentchange', function () {
@@ -131,12 +162,7 @@
 
-				if ( canvas.mozRequestFullScreen ) {
+				if ( deprecatedAPIMethod ) {
 
-					canvas.mozRequestFullScreen( { vrDisplay: vrHMD } );
+					canvas[deprecatedAPIMethod]( { vrDisplay: vrHMD } );
 					resolve();
 
-				} else if ( canvas.webkitRequestFullscreen ) {
-
-					canvas.webkitRequestFullscreen( { vrDisplay: vrHMD } );
-					resolve();
-
 				} else {
@@ -143,0 +169,0 @@

New alerts

Uses eval

Supply chain risk

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

284206

increased by69.21%

Lines of code

6792

increased by36.71%

Worsened metrics

Number of low supply chain risk alerts

7

increased by40%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes