yubigen - npm Package Compare versions

Comparing version 0.1.0 to 0.2.0

HISTORY.md

 # YUBIGEN History
 
+## 0.2.0
+- Add linter configuration files.
+- Replace error printing with error throwing per linter rules.
+
 ## 0.1.0
@@ -4,0 +8,0 @@ - Introduce and document `predict` and `outToFile` functions

index.js

 const gm = require('gm'), https = require('https'), fs = require('fs'),
-      path = require('path'), url = require('url');
+      url = require('url');
 
@@ -18,3 +18,4 @@ const FORMATS = ['ART', 'AVS', 'BMP', 'CALS', 'CIN', 'CGM', 'CMYK', 'CUR',
 
-var bufferProcessHelper = (imgBuf, paramObj) => new Promise((resolve, reject) => {
+var bufferProcessHelper = (imgBuf, paramObj) => new Promise(
+  (resolve, reject) => {
   var img =
@@ -30,7 +31,9 @@ (paramObj.imageMagick ? gm.subClass({imageMagick: true}) : gm)(imgBuf);
   });
-}), bufferProcess = (buff, paramObj, cb) => {
+}),
+bufferProcess = (buff, paramObj, cb) => {
   var func = bufferProcessHelper(buff, paramObj);
   func.then(cb);
-  func.catch(() => { console.log("There was a problem."); });
-}, writeToFile = function(path, cb) {
+  func.catch((error) => { throw error });
+},
+writeToFile = function(path, cb) {
   return function (result, err) {
@@ -45,5 +48,4 @@ if (!err && result) {
   }
-};
-
-var fromUrl = (url, paramObj, cb) => {
+},
+fromUrl = (url, paramObj, cb) => {
   var imgBuf = new Buffer('');
@@ -58,10 +60,12 @@ https.get(url, (response) => {
   }).on('error', (err) => {
-    console.log("There was an error processing the image.");
+    throw err;
   });
-}, fromFile = (path, paramObj, cb) => {
+},
+fromFile = (path, paramObj, cb) => {
   fs.readFile(path, (err, data) => {
     if (!err) bufferProcess(data, paramObj, cb);
-    else console.log(err);
+    else throw err;
   });
-}, fromBuffer = (buffer, paramObj, cb) => {
+},
+fromBuffer = (buffer, paramObj, cb) => {
   bufferProcess(buffer, paramObj, cb);
@@ -68,0 +72,0 @@ };

package.json

 {
   "name": "yubigen",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "Node Thumbnail generation without limits",
@@ -8,2 +8,4 @@ "main": "index.js",
     "chai": "^4.1.2",
+    "eslint": "^4.19.1",
+    "eslint-plugin-mocha": "^4.12.1",
     "mocha": "^5.0.4"
@@ -10,0 +12,0 @@ },

test/test.js

 const yubigen = require('yubigen'), fs = require('fs'),
-      expect = require('chai').expect;
+      expect = require('chai').expect, assert = require('chai').assert;
 
@@ -8,2 +8,6 @@ describe('It just works like magic.', function () {
     { resizeParams: [100] }, (result, err) => {
+      if (err) {
+        assert.fail(0, 1);
+        done();
+      }
       fs.writeFile("test/images/bruh.png", result, (e) => {
@@ -20,2 +24,6 @@ expect(result).to.not.be.undefined;
     format: "JPEG"}, (result, err) => {
+      if (err) {
+        assert.fail(0, 1);
+        done();
+      }
       fs.writeFile("test/images/alpha.jpg", result, (e) => {
@@ -33,2 +41,6 @@ expect(result).to.not.be.undefined;
       format: "PNG"}, (result, err) => {
+        if (err) {
+          assert.fail(0, 1);
+          done();
+        }
         fs.writeFile("test/images/gamma.png", result, (e) => {
@@ -35,0 +47,0 @@ expect(result).to.not.be.undefined;

New alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

36832

increased by92.68%

Number of package files

15

increased by36.36%

Lines of code

762

increased by305.32%

Worsened metrics

Dev dependency count

4

increased by100%

Number of medium supply chain risk alerts

2

increased by100%

No dependency changes