zip-dir - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

index.js

 var fs = require('fs');
 var path = require('path');
+var asyncLib = require('async');
+
 // Use local version of JSZip, as the version in `npm` is a fork
@@ -11,3 +13,2 @@ // and not up to date, and failing on v0.8, so this is an unfortunate
 var maxOpenFiles = 500;
-var openFiles = 0;
 
@@ -66,2 +67,12 @@ module.exports = function zipWrite (rootDir, options, callback) {
 
+  var fileQueue = asyncLib.queue(function (task, callback) {
+    fs.readFile(task.fullPath, function (err, data) {
+      if (options.each) {
+        options.each(path.join(task.dir, task.file));
+      }
+      folders[task.dir].file(task.file, data);
+      callback(err);
+    });
+  }, maxOpenFiles);
+
   function addItem (fullPath, cb) {
@@ -82,16 +93,3 @@ fs.stat(fullPath, function (err, stat) {
       } else {
-        if (openFiles < maxOpenFiles) {
-          openFiles++;
-          fs.readFile(fullPath, function (err, data) {
-            if (options.each) {
-              options.each(path.join(dir, file));
-            }
-            folders[dir].file(file, data);
-            openFiles--;
-            cb(err);
-          });
-        }
-        else {
-          addItem(fullPath, cb);
-        }
+        fileQueue.push({ fullPath: fullPath, dir: dir, file: file }, cb);
       }
@@ -98,0 +96,0 @@ });

package.json

 {
   "name": "zip-dir",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Zips up directories into buffers or saves zipped files to disk",
@@ -23,4 +23,5 @@ "main": "index.js",
   "dependencies": {
-    "jszip": "^2.4.0"
+    "jszip": "^2.4.0",
+    "async": "^1.5.2"
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

12522

increased by0.22%

Worsened metrics

Dependency count

2

increased by100%

Lines of code

278

decreased by-1.42%

Dependency changes

• + Addedasync@^1.5.2

• + Addedasync@1.5.2(transitive)