@adobe/fetch - npm Package Compare versions

Comparing version 4.1.3 to 4.1.4

package.json

 {
   "name": "@adobe/fetch",
-  "version": "4.1.3",
+  "version": "4.1.4",
   "description": "Light-weight Fetch implementation transparently supporting both HTTP/1(.1) and HTTP/2",
@@ -5,0 +5,0 @@ "main": "./src/index.js",

src/core/h1.js

@@ -39,3 +39,16 @@ /*
     // use default (global) agent
-    return undefined;
+    /* c8 ignore next 13 */
+    /* => code coverage depends on the node version */
+    if (https.globalAgent.keepAlive) /* node >= 19 */ {
+      // As of Node.js v19 the global agent has keep-alive enabled by default:
+      // https://nodejs.org/api/http.html#class-httpagent
+      // https://github.com/nodejs/node/issues/37184
+      // https://github.com/nodejs/node/pull/43522/files#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944L334-R334
+      // In order to guarantee consistent behavior across node versions we
+      // always create a new agent with keep-alive enabled on Node.js v19+.
+      h1.httpsAgent = new https.Agent({ keepAlive: false });
+      return h1.httpsAgent;
+    } else /* node <= 18 */ {
+      return undefined;
+    }
   } else {
@@ -51,3 +64,16 @@ // plain http
     // use default (global) agent
-    return undefined;
+    /* c8 ignore next 13 */
+    /* => code coverage depends on the node version */
+    if (https.globalAgent.keepAlive) /* node >= 19 */ {
+      // As of Node.js v19 the global agent has keep-alive enabled by default:
+      // https://nodejs.org/api/http.html#class-httpagent
+      // https://github.com/nodejs/node/issues/37184
+      // https://github.com/nodejs/node/pull/43522/files#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944L334-R334
+      // In order to guarantee consistent behavior across node versions we
+      // always create a new agent with keep-alive enabled on Node.js v19+.
+      h1.httpAgent = new http.Agent({ keepAlive: false });
+      return h1.httpAgent;
+    } else /* node <= 18 */ {
+      return undefined;
+    }
   }
@@ -54,0 +80,0 @@ };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

144645

increased by1.04%

Lines of code

3317

increased by0.79%

No dependency changes